-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmsTriton bug fixes and improvements #43814
Conversation
cms-bot internal usage |
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43814/38622
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
4b4b16f
to
6a7f03a
Compare
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43814/38624
|
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4df92d/37258/summary.html Comparison SummarySummary:
|
+heterogeneous |
+Upgrade |
@cms-sw/pdmv-l2 please sign (from your side, just expanding a special workflow to another fragment) |
+pdmv |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Rollup of several pending bug fixes and improvements, primarily aimed at the
cmsTriton
server management script:/cvms/unpacked.cern.ch
) is not already loaded in the worker node's cache. It does not appear to be possible for a non-privileged user to check if something is in the cvmfs cache or not, so the default server start timeout is just extended to minimize these failures.TritonService
will print the local fallback server log if the process is terminated because of an exception that could be related to the local fallback server. (This is denoted by a third argument in theTRITON_THROW_IF_ERROR
macro.) During inference requests, which can be retried, an exception does not necessarily lead to process termination, so the notification to theTritonService
can be undone in that case.TritonService
itself can all be targeted separately.VarParsing
toargparse
, now that the latter works properly withcmsRun
.checksum
andversioncheck
modes ofcmsTritonConfigTool
TritonMemResource
destructors (addresses TritonService throwing multiple exceptions #38260)PR validation:
Unit tests pass.
The following command was used to test item 5:
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
Not intended to be backported.