Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[13_2_X] Set HF FG bit thresholds for 2023 HI run #43532

Merged
merged 1 commit into from
Dec 19, 2023

Conversation

mitaylor
Copy link
Contributor

@mitaylor mitaylor commented Dec 8, 2023

PR description:

This PR updates the values of the HF thresholds in the HCAL TP emulator with those used during the 2023 PbPb run (as documented in https://twiki.cern.ch/twiki/bin/view/CMS/L1HIOverview2023).

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Backport for CMSSW_13_2_X for HI MC

@mandrenguyen

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 8, 2023

A new Pull Request was created by @mitaylor (Molly Taylor) for CMSSW_13_2_X.

It involves the following packages:

  • Configuration/Eras (operations)
  • SimCalorimetry/HcalTrigPrimProducers (l1)

@aloeliger, @fabiocos, @davidlange6, @rappoccio, @cmsbuild, @epalencia, @antoniovilela can you please review it and eventually sign? Thanks.
@AnnikaStein, @makortel, @missirol, @fabiocos, @Martin-Grunewald, @rovere, @abdoulline, @bsunanda, @sameasy this is something you requested to watch as well.
@antoniovilela, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@mandrenguyen
Copy link
Contributor

backport of #43413

@mandrenguyen
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 9, 2023

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f576da/36390/summary.html
COMMIT: 52514b0
CMSSW: CMSSW_13_2_X_2023-12-08-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/43532/36390/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 1 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3198785
  • DQMHistoTests: Total failures: 143
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3198620
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@mandrenguyen
Copy link
Contributor

@cms-sw/l1-l2 can you please review/sign?

@epalencia
Copy link
Contributor

+l1

@antoniovilela
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_0_X is complete. This pull request will be automatically merged.

@cmsbuild cmsbuild merged commit ae8073c into cms-sw:CMSSW_13_2_X Dec 19, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants