Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set HF FG bit thresholds for 2023 HI run #43413

Merged
merged 1 commit into from
Nov 30, 2023

Conversation

mitaylor
Copy link
Contributor

PR description:

This PR updates the values of the HF thresholds in the HCAL TP emulator with those used during the 2023 PbPb run (as documented in https://twiki.cern.ch/twiki/bin/view/CMS/L1HIOverview2023).

PR validation:

Normal tests performed and passed.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Will submit backports for CMSSW_13_3_X and CMSSW_13_2_X

@mandrenguyen @stahlleiton @icali

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43413/37917

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mitaylor (Molly Taylor) for master.

It involves the following packages:

  • Configuration/Eras (operations)
  • SimCalorimetry/HcalTrigPrimProducers (l1)

@rappoccio, @fabiocos, @antoniovilela, @davidlange6, @epalencia, @cmsbuild, @aloeliger can you please review it and eventually sign? Thanks.
@fabiocos, @abdoulline, @Martin-Grunewald, @makortel, @bsunanda, @AnnikaStein, @rovere, @missirol, @sameasy this is something you requested to watch as well.
@sextonkennedy, @rappoccio, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

@abdoulline
Copy link

FYI @Michael-Krohn

@mandrenguyen
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-99b0e1/36123/summary.html
COMMIT: 1e23c11
CMSSW: CMSSW_14_0_X_2023-11-28-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43413/36123/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 319 lines to the logs
  • Reco comparison results: 3 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3367918
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3367895
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 214 log files, 167 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@aloeliger
Copy link
Contributor

+l1

@rappoccio
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

@cmsbuild cmsbuild merged commit dda12d5 into cms-sw:master Nov 30, 2023
@mitaylor mitaylor deleted the CMSSW_14_0_X_HI_HF_2023 branch December 8, 2023 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants