Trigger Filter Bit fixes for Run 3 (Tau Trigger Objects)

[Ksavva1021]

PR description:
This PR fixes the trigger filter bits for Run 3 to allow proper matching between online and offline tau trigger objects.

PR validation:
All filter bits were checked to ensure all the correct filters are selected. Code was checked to make sure, filter bits were not altered for Run 2 by these modifications as expected. Checked that the code stored the filter bits for Run 3 samples.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
This PR is a backport of #43453

@mbluj @cardinia @danielwinterbottom

[cmsbuild]

A new Pull Request was created by @Ksavva1021 (Klitos Savva) for CMSSW_13_3_X.

It involves the following packages:

• PhysicsTools/NanoAOD (xpog)

@vlimant, @simonepigazzini, @cmsbuild can you please review it and eventually sign? Thanks.
@gpetruc, @AnnikaStein this is something you requested to watch as well.
@antoniovilela, @sextonkennedy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[danielwinterbottom]

Hello, could someone please review this PR ASAP? It is needed by tomorrow (deadline for cutting the release towards v13-nano production)

[vlimant]

enable nano

[vlimant]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ee1115/36308/summary.html
COMMIT: dca1fa4
CMSSW: CMSSW_13_3_X_2023-12-04-1100/el8_amd64_gcc12
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/43470/36308/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 82 lines from the logs
• Reco comparison results: 35 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3364206
• DQMHistoTests: Total failures: 1453
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3362731
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
• Checked 214 log files, 167 edm output root files, 50 DQM output files
• TriggerResults: no differences found

NANO Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 88 differences found in the comparisons
• DQMHistoTests: Total files compared: 15
• DQMHistoTests: Total histograms compared: 16335
• DQMHistoTests: Total failures: 176
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 16159
• DQMHistoTests: Total skipped: 0
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 14 files compared)
• Checked 34 log files, 16 edm output root files, 15 DQM output files

Nano size comparison Summary:

Sample	kb/ev	ref kb/ev	diff kb/ev	ev/s/thd	ref ev/s/thd	diff rate	mem/thd	ref mem/thd
2500.0	2.539	2.539	0.000 ( +0.0% )	5.27	5.27	+0.1%	2.124	1.976
2500.001	2.685	2.685	0.000 ( +0.0% )	4.67	4.69	-0.4%	2.532	1.993
2500.002	2.622	2.622	0.000 ( +0.0% )	4.88	4.90	-0.4%	2.523	1.999
2500.01	1.310	1.310	0.000 ( +0.0% )	9.76	9.59	+1.8%	2.240	1.824
2500.011	1.726	1.726	0.000 ( +0.0% )	5.22	5.18	+0.8%	2.424	1.857
2500.012	1.572	1.572	0.000 ( +0.0% )	7.52	7.43	+1.2%	2.241	1.851
2500.1	2.187	2.190	-0.003 ( -0.1% )	5.09	5.37	-5.2%	1.983	1.840
2500.2	2.301	2.301	0.000 ( +0.0% )	6.07	6.08	-0.0%	1.897	1.717
2500.21	1.177	1.177	-0.000 ( -0.0% )	4.35	4.34	+0.3%	2.175	1.761
2500.211	1.539	1.539	-0.000 ( -0.0% )	3.72	3.83	-3.0%	2.256	1.850
2500.3	2.056	2.056	0.000 ( +0.0% )	12.55	12.85	-2.3%	1.884	1.857
2500.31	1.253	1.253	0.000 ( +0.0% )	19.59	20.60	-4.9%	2.251	1.962
2500.311	1.639	1.639	0.000 ( +0.0% )	13.04	14.41	-9.5%	2.328	1.959
2500.4	2.056	2.056	0.000 ( +0.0% )	12.59	12.93	-2.6%	1.879	1.861
2500.5	19.544	19.544	0.000 ( +0.0% )	1.28	1.04	+23.3%	1.291	1.291

[vlimant]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_3_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

[danielwinterbottom]

Hello @rappoccio, @sextonkennedy, @antoniovilela can you please check this PR so it can be merged? - the deadline to have it merged for the nano v13 production is today. I understand that the backports are usually discussed in the release meeting but I think this is cancelled today due to CMS week.

[jordan-martins]

Hi guys,

In the scope of the nanov13 (133X) closure, we would like to have this merged. Could you kindly consider this PR asap, please? We need to close the nanov13 dev for (initially) the H->GG analysis.

Thanks,
PPD

[rappoccio]

+1