Trigger Filter Bit fixes for Run 3 (Tau Trigger Objects)

[Ksavva1021]

PR description:

This PR fixes the trigger filter bits for Run 3 to allow proper matching between online and offline tau trigger objects.

PR validation:

All filter bits were checked to ensure all the correct filters are selected. Code was checked to make sure, filter bits were not altered for Run 2 by these modifications as expected. Checked that the code stored the filter bits for Run 3 samples.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Backport is planned for CMSSW_13_3_X.

@mbluj @cardinia @danielwinterbottom

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43453/38003

• This PR adds an extra 24KB to repository

[cmsbuild]

A new Pull Request was created by @Ksavva1021 (Klitos Savva) for master.

It involves the following packages:

• PhysicsTools/NanoAOD (xpog)

@vlimant, @simonepigazzini, @cmsbuild can you please review it and eventually sign? Thanks.
@gpetruc, @AnnikaStein this is something you requested to watch as well.
@antoniovilela, @sextonkennedy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[vlimant]

enable nano

[vlimant]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e6dd28/36242/summary.html
COMMIT: 205aeb0
CMSSW: CMSSW_14_0_X_2023-11-30-2300/el8_amd64_gcc12
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43453/36242/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 270 lines from the logs
• Reco comparison results: 22 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3370032
• DQMHistoTests: Total failures: 149
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3369861
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
• Checked 214 log files, 167 edm output root files, 50 DQM output files
• TriggerResults: no differences found

NANO Comparison Summary

Summary:

• You potentially removed 3 lines from the logs
• Reco comparison results: 88 differences found in the comparisons
• DQMHistoTests: Total files compared: 15
• DQMHistoTests: Total histograms compared: 16335
• DQMHistoTests: Total failures: 176
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 16159
• DQMHistoTests: Total skipped: 0
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 14 files compared)
• Checked 38 log files, 18 edm output root files, 15 DQM output files

Nano size comparison Summary:

Sample	kb/ev	ref kb/ev	diff kb/ev	ev/s/thd	ref ev/s/thd	diff rate	mem/thd	ref mem/thd
2500.0	2.539	2.539	0.000 ( +0.0% )	5.26	5.28	-0.3%	1.868	2.146
2500.001	2.686	2.686	0.000 ( +0.0% )	4.78	4.71	+1.5%	2.292	2.586
2500.002	2.622	2.622	0.000 ( +0.0% )	4.90	4.89	+0.2%	2.282	2.569
2500.01	1.310	1.310	0.000 ( +0.0% )	9.79	9.81	-0.2%	2.168	2.271
2500.011	1.726	1.726	0.000 ( +0.0% )	5.29	5.31	-0.4%	2.252	2.468
2500.012	1.572	1.572	0.000 ( +0.0% )	7.51	7.66	-2.0%	2.348	2.372
2500.1	2.187	2.190	-0.003 ( -0.1% )	5.28	5.36	-1.7%	1.720	2.011
2500.2	2.302	2.301	0.001 ( +0.0% )	6.11	6.14	-0.5%	1.630	1.920
2500.21	1.177	1.177	-0.000 ( -0.0% )	4.37	4.40	-0.5%	1.891	2.223
2500.211	1.540	1.540	-0.000 ( -0.0% )	3.82	3.83	-0.1%	2.032	2.304
2500.3	2.057	2.057	0.000 ( +0.0% )	12.69	13.18	-3.7%	1.613	1.903
2500.31	1.253	1.253	-0.000 ( -0.0% )	20.26	20.89	-3.0%	2.009	2.308
2500.311	1.639	1.639	0.000 ( +0.0% )	13.97	14.45	-3.3%	2.072	2.382
2500.312	7.025	7.025	0.000 ( +0.0% )	1.46	1.35	+7.8%	1.654	1.648
2500.313	1.471	1.471	0.000 ( +0.0% )	6.82	7.04	-3.1%	0.980	0.984
2500.4	2.057	2.057	0.000 ( +0.0% )	12.86	12.92	-0.4%	1.594	1.911
2500.5	19.575	19.575	0.000 ( +0.0% )	1.24	1.40	-11.6%	1.297	1.298

[vlimant]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

[antoniovilela]

+1