-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix SiStripHashedDetId
constructor / operator and add more SiStripLorentzAngle PCL unit testings
#43469
Fix SiStripHashedDetId
constructor / operator and add more SiStripLorentzAngle PCL unit testings
#43469
Conversation
…d more per-module histograms
type bug-fix |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43469/38025
|
A new Pull Request was created by @mmusich (Marco Musich) for master. It involves the following packages:
@saumyaphor4252, @cmsbuild, @consuegs, @perrotta can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild, please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-58b2f7/36249/summary.html Comparison SummarySummary:
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
This PR is a follow up to #43423 and implements several different fixes and improvements.
First it fixes the
SiStripHashedDetId
class, both in terms of the copy constructor (5b7f10a) and assignment operator (3eda318). It also adds a newsize()
public method (349ac88).Then it adds a
catch2
-based unit test for basicSiStripHashedDetId
operations (done in commits f20b63e, 8b2231d and 5f34bdd).Finally it improves the filling of the per-module histograms in SiStripLorentzAnglePCLMonitor (commits 6fb57ae, 6e38f12) as well as adding a dedicated unit test of both the AlCASkimming and AlCaHarvesting steps (519df2c).
PR validation:
The validation of this PR relies on running the augment battery of unit tests of this package.
Running
scam b runtests
returnsIf this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
Not a backport, but might be backported in case there is prolonged cosmics data-taking in 13_3_X foreseen at some point.