MTD Geometry: Optimize speed of MTD ideal geometry dump and improve verbosity

[fabiocos]

PR description:

This PR updates the verbosity of the tests in Geometry/MTDCommonData dumping the BTL and ETL geometry structure and DetId calculation, and optimizes them for better speed in regular unit tests. Just activating the python MessageLogger commented lines brings back the full dump, when needed for visual inspection.

PR validation:

Code compiles and runs, unit tests are OK, and now significantly faster.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43388/37881

• This PR adds an extra 16KB to repository

[cmsbuild]

A new Pull Request was created by @fabiocos (Fabio Cossutti) for master.

It involves the following packages:

• Geometry/MTDCommonData (geometry, upgrade)

@srimanob, @mdhildreth, @bsunanda, @civanch, @Dr15Jones, @cmsbuild, @makortel can you please review it and eventually sign? Thanks.
@bsunanda this is something you requested to watch as well.
@sextonkennedy, @rappoccio, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

[fabiocos]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ef193e/36055/summary.html
COMMIT: 61b9f6e
CMSSW: CMSSW_14_0_X_2023-11-24-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/43388/36055/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 46 lines from the logs
• Reco comparison results: 3 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3367918
• DQMHistoTests: Total failures: 4
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3367892
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
• Checked 214 log files, 167 edm output root files, 50 DQM output files
• TriggerResults: no differences found

[civanch]

+1

[srimanob]

+Upgrade

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

[srimanob]

Note to @fabiocos on warning showed in the static check, not related to this PR.

data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_14_0_X_2023-11-24-1100/src/Geometry/MTDCommonData/src/ETLNumberingScheme.cc:40:7: warning: Value stored to 'ringCopy' during its initialization is never read [deadcode.DeadStores]
   40 |   int ringCopy(::atoi(baseName.data() + 4));
      |       ^~~~~~~~ ~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 warning generated.

[fabiocos]

@srimanob thanks for noticing, this likely was left behind when I finally removed code to support the old D49 like ETL geometry. @pablom @24LopezR since you are about to update this code, could you please add a fix for this as well? Just remove that line, and move the int declaration where ringCopy is really filled for its final use.

[24LopezR]

@fabiocos noted! I will add a fix in my upcoming PR.

[rappoccio]

+1