Run3 HZZ electron ID #43369
Run3 HZZ electron ID #43369
Conversation
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43369/37839
|
|
A new Pull Request was created by @apetkovi1 (Andro Petkovic) for master. It involves the following packages:
@mandrenguyen, @cmsbuild, @vlimant, @jfernan2, @simonepigazzini can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
please test with cms-data/RecoEgamma-ElectronIdentification#28 |
|
-1 Failed Tests: UnitTests RelVals RelVals-INPUT Unit TestsI found 1 errors in the following unit tests: ---> test runtestRecoEgammaElectronIdentification had ERRORS RelValsExpand to see more relval errors ...RelVals-INPUT
Expand to see more relval errors ...
|
cmsbuild
added
tests-pending
code-checks-pending
and removed
tests-rejected
requires-external
code-checks-approved
labels
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43369/37858
|
|
Pull request #43369 was updated. @vlimant, @jfernan2, @cmsbuild, @mandrenguyen, @simonepigazzini can you please check and sign again. |
|
@apetkovi1 Did you do private tests with runTheMatrix? If you can share those, that would be nice. Moreover, did you validate this ID once it has appeared in Mini and nano? It would be useful to see that, for example, the signal efficiency is indeed what you think it is. |
|
Hi @a-kapoor, no I just ran testElectronMVARun3 to see if it appears in nano and calculated manually sig eff as a check. I am not aware there is another test runTheMatrix. Can you please share this script. Also, if there is a script that validates if ID appears in nano and Mini outside of testElectronMVARun3, can you also share it ? |
|
Hi @apetkovi1, If you have the results of the manual check, please share those too. (You can update the description of the PR) |
|
@a-kapoor I ran runTheMatrix test and it fails: in: /grid_mnt/vol_home/llr/cms/apetkovic/CMSSW_13_3_0/src going to execute cd 12434.0_TTbar_14TeV+2023cmsDriver.py TTbar_14TeV_TuneCP5_cfi -s GEN,SIM -n 10 --conditions auto:phase1_2023_realistic --beamspot Realistic25ns13p6TeVEarly2023Collision --datatier GEN-SIM --eventcontent FEVTDEBUG --geometry DB:Extended --era Run3_2023 --relval 9000,100 --fileout file:step1.root > step1_TTbar_14TeV+2023.log 2>&1 in: /grid_mnt/vol_home/llr/cms/apetkovic/CMSSW_13_3_0/src going to execute cd 12434.0_TTbar_14TeV+2023cmsDriver.py step2 -s DIGI:pdigi_valid,L1,DIGI2RAW,HLT:@relval2023 --conditions auto:phase1_2023_realistic --datatier GEN-SIM-DIGI-RAW -n 10 --eventcontent FEVTDEBUGHLT --geometry DB:Extended --era Run3_2023 --filein file:step1.root --fileout file:step2.root > step2_TTbar_14TeV+2023.log 2>&1 in: /grid_mnt/vol_home/llr/cms/apetkovic/CMSSW_13_3_0/src going to execute cd 12434.0_TTbar_14TeV+2023cmsDriver.py step3 -s RAW2DIGI,L1Reco,RECO,RECOSIM,PAT,NANO,VALIDATION:@standardValidation+@miniAODValidation,DQM:@standardDQM+@ExtraHLT+@miniAODDQM+@nanoAODDQM --conditions auto:phase1_2023_realistic --datatier GEN-SIM-RECO,MINIAODSIM,NANOAODSIM,DQMIO -n 10 --eventcontent RECOSIM,MINIAODSIM,NANOEDMAODSIM,DQM --geometry DB:Extended --era Run3_2023 --filein file:step2.root --fileout file:step3.root > step3_TTbar_14TeV+2023.log 2>&1 ERROR executing cd 12434.0_TTbar_14TeV+2023; cmsDriver.py step3 -s RAW2DIGI,L1Reco,RECO,RECOSIM,PAT,NANO,VALIDATION:@standardValidation+@miniAODValidation,DQM:@standardDQM+@ExtraHLT+@miniAODDQM+@nanoAODDQM --conditions auto:phase1_2023_realistic --datatier GEN-SIM-RECO,MINIAODSIM,NANOAODSIM,DQMIO -n 10 --eventcontent RECOSIM,MINIAODSIM,NANOEDMAODSIM,DQM --geometry DB:Extended --era Run3_2023 --filein file:step2.root --fileout file:step3.root > step3_TTbar_14TeV+2023.log 2>&1; ret= 16640 Will have to solve this |
|
-1 Failed Tests: RelVals RelVals-INPUT RelValsExpand to see more relval errors ...RelVals-INPUT |
Hey. You need to look at the log files like these "step3_TTbar_14TeV+2023.log". This might shed some light on the errors. |
|
Hi @a-kapoor, after changing few things, I am now able to |
|
Hi @apetkovi1, this time it seems the test is successful. You have all the output files Hint: The log file will contain something like below for an example: |
|
Hi @Prasant1993 - unfortunately when I check step3_TTbar_14TeV+2023.log it seems that it fails to add this ID. It is strange why it did not crash. Do you perhaps now what could cause these logic errors in log: %MSG %MSG %MSG %MSG %MSG FastJet release 3.4.1M. Cacciari, G.P. Salam and G. SoyezA software package for jet finding and analysis at collidershttp://fastjet.frPlease cite EPJC72(2012)1896 [arXiv:1111.6097] if you use this packagefor scientific work and optionally PLB641(2006)57 [hep-ph/0512210].FastJet is provided without warranty under the GNU GPL v2 or higher.It uses T. Chan's closest pair algorithm, S. Fortune's Voronoi codeand 3rd party plugin jet algorithms. See COPYING file for details.#-------------------------------------------------------------------------- %MSG
|
|
I am just curious about the msg : Given the above, If that's the case, can you also make it true here : https://github.com/apetkovi1/cmssw/blob/Run3_HZZelectronID_V1p1/RecoEgamma/ElectronIdentification/python/Identification/mvaElectronID_Winter22_HZZ_V1_cff.py#L49 mvaEleID_Winter22_HZZ_V1.isPOGApproved = cms.untracked.bool(False) |
|
Hi @Prasant1993 - it is not approved. I presented this ID on EGM meeting - in the meanwhile I recomputed weights so that ID uses cluster iso variables instead of particle. If I change POGapproved to true log looks like this (I still do not see in the log any info that my ID has been added. Checking step3_inNANOEDMAODSIM.root I only see branches that correspond to some tables, not even sure what does it mean): %MSG %MSG %MSG %MSG FastJet release 3.4.1M. Cacciari, G.P. Salam and G. SoyezA software package for jet finding and analysis at collidershttp://fastjet.frPlease cite EPJC72(2012)1896 [arXiv:1111.6097] if you use this packagefor scientific work and optionally PLB641(2006)57 [hep-ph/0512210].FastJet is provided without warranty under the GNU GPL v2 or higher.It uses T. Chan's closest pair algorithm, S. Fortune's Voronoi codeand 3rd party plugin jet algorithms. See COPYING file for details.#-------------------------------------------------------------------------- %MSG
|
|
Hi @apetkovi1 Since in the log file I don't see the msg appearing whether the ID is added or not. python3 printEgammaUserData.py step3_inMINIAODSIM.root You can paste here the output of the above command. |
|
Hi @Prasant1993 yes it has been added - output looks like this: |
|
Hi @apetkovi1, You can produce a NanoAOD file from the above MiniAOD file produced using the cmsDriver.py command. cmsDriver.py step2 -s NANO,DQM:@nanoAODDQM --process NANO --mc --eventcontent NANOAODSIM,DQM --datatier NANOAODSIM,DQMIO -n 10000 --customise "Configuration/DataProcessing/Utils.addMonitoring" --era Run3 --conditions auto:phase1_2022_realistic --filein file:12434.0_TTbar_14TeV+2023/step3_inMINIAODSIM.root You can check the root file produced for your new ID: step2_NANO_DQM.root You may need to add the ID in Nano DQM histograms as well here : https://github.com/cms-sw/cmssw/blob/master/PhysicsTools/NanoAOD/python/nanoDQM_cfi.py#L49 |
|
Hi @Prasant1993. I created step2_NANO_DQM.root in a way you wrote. I went to check the content |
|
Hi @apetkovi1, When you print the Event tree, You should be able to see the Electron branches in the tree as well as other physics objects like photon, jets etc. For example in the Electron branch shoud look like the following: *Br 72 :Electron_lostHits : UChar_t number of missing inner hits * |
|
Hi @Prasant1993 ok now I see that the command had error Product not found (Photon ID ???): NANO,DQM:@nanoAODDQM %MSG %MSG %MSG FastJet release 3.4.1M. Cacciari, G.P. Salam and G. SoyezA software package for jet finding and analysis at collidershttp://fastjet.frPlease cite EPJC72(2012)1896 [arXiv:1111.6097] if you use this packagefor scientific work and optionally PLB641(2006)57 [hep-ph/0512210].FastJet is provided without warranty under the GNU GPL v2 or higher.It uses T. Chan's closest pair algorithm, S. Fortune's Voronoi codeand 3rd party plugin jet algorithms. See COPYING file for details.#-------------------------------------------------------------------------- %MSG
|
|
Hi @apetkovi1, This PR has nothing to do with Photon. There should not be any error for accessing the existing photonIDs. I am just curious, did you run the above cmsDriver.py command in the CMSSW/src directory to produce the NanoAOD ? Otherwise, One more workaround can be the following: |
|
Hi @Prasant1993 , yes I am running locally from CMSSW_13_3_0/src (I am tracking master branch, not the CMSSW_13_3_0). I added photon package but message stays the same. I am suspecting now that there is some interference between master branch and my local CMSSW_13_3_0. What I do is that I first create CMSSW area EDIT: @a-kapoor can I close this PR and send it from another branch (the one created from 14_0_...) ? |
Hi @apetkovi1, If you would like to give a presentation again in the EGM POG meeting for you new IDs using PF cluster isolation variables instead of particle isolations, it will be more appreciated and help us to approve the ID. I let @a-kapoor and @RSalvatico comment more on this. |
Hi @apetkovi1 That explains it. Yes, please create another branch and start a fresh pull request. This time, attach the results of runTheMatrix and your private validation with the description. Thanks. |
|
please close |
This PR is to add Run3 HZZ electron ID. I have tested the changes privately with 1. Please, test it with this PR 2, since it hasn't been merged yet (weights are available at 3)