Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Alpaka Process Modifier #43229

Merged
merged 2 commits into from
Nov 15, 2023
Merged

Conversation

jsamudio
Copy link
Contributor

@jsamudio jsamudio commented Nov 9, 2023

PR description:

This PR is made to introduce a process modifier, alpaka, which will be utilized to enable Alpaka based modules such as those in #43130 and #41117. This PR will simply add the process modifier, but no changes to any workflows are introduced.

PR validation:

Basic battery of tests passed:
runTheMatrix.py -l limited -i all --ibeos

In the future this process modifier will be used to enable the validation of Alpaka modules.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

PR is not a backport.

@fwyzard

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 9, 2023

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43229/37581

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 9, 2023

A new Pull Request was created by @jsamudio for master.

It involves the following packages:

  • Configuration/ProcessModifiers (operations)
  • Configuration/StandardSequences (operations)

@cmsbuild, @rappoccio, @davidlange6, @antoniovilela, @fabiocos can you please review it and eventually sign? Thanks.
@VinInn, @dgulhan, @mtosi, @JanFSchulte, @missirol, @felicepantaleo, @slomeo, @VourMa, @sameasy, @Martin-Grunewald, @mmusich, @rovere, @fabiocos, @GiacomoSguazzoni, @makortel this is something you requested to watch as well.
@antoniovilela, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@@ -13,9 +13,15 @@
def _addProcessAccelerators(process):
process.load("Configuration.StandardSequences.Accelerators_cff")

def _addProcessAcceleratorsAlpaka(process):
process.load("HeterogeneousCore.AlpakaCore.ProcessAcceleratorAlpaka_cfi")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer the loading of ProcessAcceleratorAlpaka_cfi to be in Accelerators_cff. I also think that, given the state of the GPU matters in the offline side, the import there could be unconditional.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So I should instead just add

from HeterogeneousCore.AlpakaCore.ProcessAcceleratorAlpaka_cfi import ProcessAcceleratorAlpaka

to Accelerators_cff?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes.

I think adding the alpaka modifier as one of the ways to call makeProcessModifier(_addProcessAccelerators) below is fine (or, I'm not against).

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43229/37619

@cmsbuild
Copy link
Contributor

Pull request #43229 was updated. @davidlange6, @fabiocos, @rappoccio, @antoniovilela, @cmsbuild can you please check and sign again.

@makortel
Copy link
Contributor

enable gpu

@makortel
Copy link
Contributor

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-717ba1/35747/summary.html
COMMIT: 11e604f
CMSSW: CMSSW_14_0_X_2023-11-10-1100/el8_amd64_gcc12
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/43229/35747/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 102 lines from the logs
  • Reco comparison results: 133 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3363010
  • DQMHistoTests: Total failures: 1785
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3361203
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 214 log files, 167 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

GPU Comparison Summary

Summary:

  • You potentially added 26 lines to the logs
  • Reco comparison results: 48 differences found in the comparisons
  • DQMHistoTests: Total files compared: 3
  • DQMHistoTests: Total histograms compared: 39740
  • DQMHistoTests: Total failures: 1618
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 38122
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 2 files compared)
  • Checked 8 log files, 10 edm output root files, 3 DQM output files
  • TriggerResults: no differences found

@antoniovilela
Copy link
Contributor

@makortel
Are you happy with this PR?
Thanks.

@makortel
Copy link
Contributor

Yes, it looks fine as far as I'm concerned.

@antoniovilela
Copy link
Contributor

Yes, it looks fine as far as I'm concerned.

Thanks.

@antoniovilela
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants