-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Alpaka Process Modifier #43229
Add Alpaka Process Modifier #43229
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43229/37581
|
A new Pull Request was created by @jsamudio for master. It involves the following packages:
@cmsbuild, @rappoccio, @davidlange6, @antoniovilela, @fabiocos can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@@ -13,9 +13,15 @@ | |||
def _addProcessAccelerators(process): | |||
process.load("Configuration.StandardSequences.Accelerators_cff") | |||
|
|||
def _addProcessAcceleratorsAlpaka(process): | |||
process.load("HeterogeneousCore.AlpakaCore.ProcessAcceleratorAlpaka_cfi") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would prefer the loading of ProcessAcceleratorAlpaka_cfi
to be in Accelerators_cff
. I also think that, given the state of the GPU matters in the offline side, the import there could be unconditional.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So I should instead just add
from HeterogeneousCore.AlpakaCore.ProcessAcceleratorAlpaka_cfi import ProcessAcceleratorAlpaka
to Accelerators_cff
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes.
I think adding the alpaka
modifier as one of the ways to call makeProcessModifier(_addProcessAccelerators)
below is fine (or, I'm not against).
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43229/37619
|
Pull request #43229 was updated. @davidlange6, @fabiocos, @rappoccio, @antoniovilela, @cmsbuild can you please check and sign again. |
enable gpu |
@cmsbuild, please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-717ba1/35747/summary.html Comparison SummarySummary:
GPU Comparison SummarySummary:
|
@makortel |
Yes, it looks fine as far as I'm concerned. |
Thanks. |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged. |
PR description:
This PR is made to introduce a process modifier,
alpaka
, which will be utilized to enable Alpaka based modules such as those in #43130 and #41117. This PR will simply add the process modifier, but no changes to any workflows are introduced.PR validation:
Basic battery of tests passed:
runTheMatrix.py -l limited -i all --ibeos
In the future this process modifier will be used to enable the validation of Alpaka modules.
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
PR is not a backport.
@fwyzard