Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[13.3.X] customize HLT offline DQM for Run3 PbPb and introduce HI 2023A relval workflow (with reHLT) #43221

Merged
merged 2 commits into from
Nov 13, 2023

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Nov 8, 2023

backport of #43141

PR description:

In the context of CMSALCA-240 it has become clear that in order to run alca validation workflows that re-run the HLT HIon menu, the collections saved in the step2 (with data-tier FEVTDEBUGHLT) are not sufficient for the scope of monitoring objects produced at the HLT (namely tracks and vertices, but also strip and pixel clusters).
This PRs, in presence of the pp_on_PbPb_run3 modifier:

  • adds the collections needed for the validation in the FEVTDEBUGHLTEventContent;
  • introduces a bunch of modifications of input collections of various monitoring sequences in the package DQMOffline/Trigger

In order to test the whole procedure I introduce a new workflow 142.0 (starting from RunHI2023A RawPrime data) that mimics the procedure in the ticket CMSALCA-240.

PR validation:

Run successfully runTheMatrix.py -l 142.0 -t 4 -j 8.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Verbatim backport of #43141 to 13.3.X

- based on HIRun2023A HIPhysicsRawPrime data
- performs re-HLT and HLT offline monitoring
@mmusich mmusich changed the title customize HLT offline DQM for Run3 PbPb and introduce HI 2023A relval workflow (with reHLT) [13.3.X] customize HLT offline DQM for Run3 PbPb and introduce HI 2023A relval workflow (with reHLT) Nov 8, 2023
@cmsbuild cmsbuild added this to the CMSSW_13_3_X milestone Nov 8, 2023
@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 8, 2023

A new Pull Request was created by @mmusich (Marco Musich) for CMSSW_13_3_X.

It involves the following packages:

  • Configuration/EventContent (operations)
  • Configuration/PyReleaseValidation (upgrade, pdmv)
  • DQMOffline/Trigger (dqm)

@rappoccio, @tjavaid, @davidlange6, @sunilUIET, @cmsbuild, @rvenditti, @fabiocos, @nothingface0, @AdrianoDee, @srimanob, @miquork, @syuvivida, @antoniovilela, @antoniovagnerini can you please review it and eventually sign? Thanks.
@slomeo, @rociovilar, @jhgoh, @Martin-Grunewald, @trocino, @makortel, @HuguesBrun, @cericeci, @missirol, @mtosi, @Fedespring, @fabiocos this is something you requested to watch as well.
@antoniovilela, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor Author

mmusich commented Nov 8, 2023

test parameters:

  • workflow = 142.0

@mmusich
Copy link
Contributor Author

mmusich commented Nov 8, 2023

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 8, 2023

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18031e/35693/summary.html
COMMIT: 4c13db6
CMSSW: CMSSW_13_3_X_2023-11-07-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/43221/35693/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 182 lines from the logs
  • Reco comparison results: 1 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3363010
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3362987
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 214 log files, 167 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@tjavaid
Copy link

tjavaid commented Nov 8, 2023

+1

@srimanob
Copy link
Contributor

srimanob commented Nov 8, 2023

+Upgrade

@AdrianoDee
Copy link
Contributor

+pdmv

@antoniovilela
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_3_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_0_X is complete. This pull request will be automatically merged.

@cmsbuild cmsbuild merged commit 550ebb4 into cms-sw:CMSSW_13_3_X Nov 13, 2023
@mmusich mmusich deleted the add_monitoring_pp_on_AA branch November 13, 2023 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants