-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
customize HLT offline DQM for Run3 PbPb and introduce HI 2023A relval workflow (with reHLT) #43141
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43141/37420
|
A new Pull Request was created by @mmusich (Marco Musich) for master. It involves the following packages:
@AdrianoDee, @miquork, @nothingface0, @antoniovagnerini, @srimanob, @fabiocos, @sunilUIET, @tjavaid, @syuvivida, @davidlange6, @rvenditti, @rappoccio, @cmsbuild, @antoniovilela can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
test parameters:
|
@cmsbuild, please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2f2a03/35482/summary.html Comparison SummarySummary:
|
@@ -640,6 +641,19 @@ def SwapKeepAndDrop(l): | |||
FEVTDEBUGHLTEventContent.outputCommands.append('keep *_*_MergedTrackTruth_*') | |||
FEVTDEBUGHLTEventContent.outputCommands.append('keep *_*_StripDigiSimLink_*') | |||
FEVTDEBUGHLTEventContent.outputCommands.append('keep *_*_PixelDigiSimLink_*') | |||
|
|||
pp_on_PbPb_run3.toModify(FEVTDEBUGHLTEventContent, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm wondering if it would make sense to customize
HLTDebugFEVT = cms.PSet( |
instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, because that implies a charge in the confdb menu and I don't think we want this at this point (perhaps later)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm wondering if it would make sense to customize
cmssw/HLTrigger/Configuration/python/HLTrigger_EventContent_cff.py
For the record (while a bit inelegant) this was taken care in the development combined table at https://its.cern.ch/jira/browse/CMSHLT-2964. This should not stop integration of these changes though, as the ad-hoc customization can be removed once the HLT menu is updated in the release.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this has been taken care of by #43300 (and corresponding backports)
@cms-sw/dqm-l2 @cms-sw/pdmv-l2 @cms-sw/upgrade-l2 please review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some cleaning, just in case...
@cms-sw/dqm-l2 @cms-sw/pdmv-l2 @cms-sw/upgrade-l2 could you please review and/or sign this? |
Milestone for this pull request has been moved to CMSSW_14_0_X.Please open a backport if it should also go in to CMSSW_13_3_X. |
@cms-sw/dqm-l2 your signature is required here. Thank you. |
+1
|
@cms-sw/orp-l2 please consider merging this PR (and its backports). They are needed in order to pursue the latest alignment @ HLT validation at CMSALCA-240 |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged. |
PR description:
In the context of CMSALCA-240 it has become clear that in order to run alca validation workflows that re-run the HLT
HIon
menu, the collections saved in the step2 (with data-tierFEVTDEBUGHLT
) are not sufficient for the scope of monitoring objects produced at the HLT (namely tracks and vertices, but also strip and pixel clusters).This PRs, in presence of the
pp_on_PbPb_run3
modifier:FEVTDEBUGHLTEventContent
;DQMOffline/Trigger
In order to test the whole procedure I introduce a new workflow 142.0 (starting from
RunHI2023A
RawPrime data) that mimics the procedure in the ticket CMSALCA-240.PR validation:
Run successfully
runTheMatrix.py -l 142.0 -t 4 -j 8
.If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
Not a backport, perhaps to be backported to 13.2.X if there is still a necessity to run the alca validation.