Phase2-hgx348D Update HGCSiliconDetId in view of adding a fourth type of wafer: high density but thicker (backport of #43196)

[bsunanda]

PR description:

Update HGCSiliconDetId in view of adding a fourth type of wafer: high density but thicker (backport of #43196)

PR validation:

Use the runTheMatrix test workflows

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Backport of #43196

[cmsbuild]

A new Pull Request was created by @bsunanda (Sunanda Banerjee) for CMSSW_13_3_X.

It involves the following packages:

• DataFormats/ForwardDetId (simulation, upgrade)
• Geometry/HGCalCommonData (geometry, upgrade)
• Geometry/HGCalGeometry (geometry, upgrade)

@civanch, @cmsbuild, @makortel, @Dr15Jones, @bsunanda, @AdrianoDee, @mdhildreth, @srimanob can you please review it and eventually sign? Thanks.
@youyingli, @rovere, @missirol, @fabiocos, @apsallid this is something you requested to watch as well.
@sextonkennedy, @antoniovilela, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[bsunanda]

@cmsbuild Please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-639d37/35645/summary.html
COMMIT: cb09616
CMSSW: CMSSW_13_3_X_2023-11-06-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/43207/35645/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 96 lines to the logs
• Reco comparison results: 7 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3363010
• DQMHistoTests: Total failures: 10
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3362978
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
• Checked 214 log files, 167 edm output root files, 50 DQM output files
• TriggerResults: no differences found

[civanch]

+1

[bsunanda]

@srimanob Please approve this backport PR

[srimanob]

Could you please clarify the reason of backport? From #43196 (comment), it seems nothing is used. Thx.

[bsunanda]

@srimanob This was initially put for 13_3_X. Then due to a delay in signing this PR, the 14_0_X started and Shahzad transferred all unmerged PRs to 14_0_X and asked to request for back porting them to 13_3_X.

[srimanob]

Hi @bsunanda @civanch
I don't think I get answer from above comment, sorry.

My question is that why do you need to merge this PR in 13_3. This PR, alone, will not do anything, if I understand correctly. Do you plan to do more backports for future PR?

• If yes, could you please share the plan.
• If no, I assume we don't need the backport.
  In the current plan, 13_3 will not be used for any Phase-2 production. 14_0 or 14_1 (if by April/May) will be the release for the next Phase-2 production.

Thanks for clarification.

[bsunanda]

We plan to complete V18 in 14_0_X and backport this to 13_3_X. It is one essential part of that

[srimanob]

I think that is a point I don't understand. Why do we need V18 to be backport? What is the reason behind that.

[srimanob]

+Upgrade

I sign this PR as it is OK to have. However, we should have a clear reason to backport new geometry to unused release, this is the point that I don't understand. See above comment.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_3_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[rappoccio]

+1