Phase2-hgx348C Update HGCSiliconDetId in view of adding a fourth type of wafer: high density but thicker

[bsunanda]

PR description:

Update HGCSiliconDetId in view of adding a fourth type of wafer: high-density but thicker. This is going to affect the future description of modules where some of the current partial wafer type will be dropped and a new wafer type will be introduced. The changes made here should not affect any existing workflows.

PR validation:

Tested with the runTheMatrix test workflows

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for

To be backported to 13_3_X

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43196/37515

• This PR adds an extra 28KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43196/37515/code-format.patch
  e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43196/37515/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43196/37517

• This PR adds an extra 28KB to repository

[cmsbuild]

A new Pull Request was created by @bsunanda (Sunanda Banerjee) for master.

It involves the following packages:

• DataFormats/ForwardDetId (upgrade, simulation)
• Geometry/HGCalCommonData (upgrade, geometry)
• Geometry/HGCalGeometry (upgrade, geometry)

@makortel, @Dr15Jones, @mdhildreth, @cmsbuild, @AdrianoDee, @bsunanda, @srimanob, @civanch can you please review it and eventually sign? Thanks.
@apsallid, @rovere, @missirol, @youyingli, @fabiocos this is something you requested to watch as well.
@sextonkennedy, @rappoccio, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

[bsunanda]

@cmsbuild Please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4de006/35620/summary.html
COMMIT: 226996b
CMSSW: CMSSW_13_3_X_2023-11-05-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/43196/35620/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 310 lines from the logs
• Reco comparison results: 18 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3363010
• DQMHistoTests: Total failures: 1397
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3361591
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
• Checked 214 log files, 167 edm output root files, 50 DQM output files
• TriggerResults: no differences found

[smuzaffar]

Milestone for this pull request has been moved to CMSSW_14_0_X.Please open a backport if it should also go in to CMSSW_13_3_X.

[bsunanda]

Backported to 13_3_X using #43207

[civanch]

+1

[srimanob]

Hi @bsunanda
Could you please give more clear description if this PR will effect which workflow? I don't see the failure in PR test, so I assume it will not effect existing workflow, but later. Thanks.

[bsunanda]

The changes made here is more for future and not for the present workflows.

[srimanob]

+Upgrade

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

[rappoccio]

+1