Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[131X] Fix upper bound of the scale in SUEP shower simulation #43183

Merged
merged 1 commit into from
Nov 7, 2023

Conversation

tvami
Copy link
Contributor

@tvami tvami commented Nov 3, 2023

PR description:

See #43165
please note that there is no need for a customization because this only affects the SUEP simulations, and there were no officially done SUEP samples done for UL (nor any other campaigns)

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

backport of #43165

@tvami
Copy link
Contributor Author

tvami commented Nov 3, 2023

backport of #43165

@cmsbuild cmsbuild added this to the CMSSW_13_1_X milestone Nov 3, 2023
@tvami
Copy link
Contributor Author

tvami commented Nov 3, 2023

@cmsbuild , please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 3, 2023

A new Pull Request was created by @tvami (Tamas Vami) for CMSSW_13_1_X.

It involves the following packages:

  • GeneratorInterface/Pythia8Interface (generators)

@mkirsano, @SiewYan, @alberto-sanchez, @GurpreetSinghChahal, @menglu21, @bbilin can you please review it and eventually sign? Thanks.
@mkirsano, @alberto-sanchez this is something you requested to watch as well.
@antoniovilela, @sextonkennedy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 4, 2023

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24d7b4/35588/summary.html
COMMIT: 7df7320
CMSSW: CMSSW_13_1_X_2023-10-29-0000/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43183/35588/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found 1 errors in the following unit tests:

---> test TestGeneratorInterfacePythia8ConcurrentGeneratorFilter had ERRORS

Comparison Summary

Summary:

  • You potentially removed 229 lines from the logs
  • Reco comparison results: 15 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3196443
  • DQMHistoTests: Total failures: 12
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3196409
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@tvami
Copy link
Contributor Author

tvami commented Nov 4, 2023

@cmsbuild , please test with #43188

@tvami
Copy link
Contributor Author

tvami commented Nov 4, 2023

@cmsbuild , please abort

@tvami
Copy link
Contributor Author

tvami commented Nov 4, 2023

@cmsbuild , please test with #43188

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 4, 2023

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24d7b4/35606/summary.html
COMMIT: 7df7320
CMSSW: CMSSW_13_1_X_2023-11-03-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43183/35606/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 236 lines from the logs
  • Reco comparison results: 1 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3202647
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3202625
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@menglu21
Copy link
Contributor

menglu21 commented Nov 7, 2023

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 7, 2023

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit c827d75 into cms-sw:CMSSW_13_1_X Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants