Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[13_2_X] Add minETA selection to HLT filter RecoTracker/DeDx/plugins/HLTDeDxFilter #43168

Merged
merged 1 commit into from
Nov 3, 2023
Merged

Conversation

fmanteca
Copy link
Contributor

@fmanteca fmanteca commented Nov 2, 2023

PR description:

Added one parameter to the HLT filter RecoTracker/DeDx/plugins/HLTDeDxFilter to set a minimum eta cut on the reconstructed tracker track.

  • This updated filter will be used in a new HLT path in 2024 to improve the high-pt muon efficiency in the CSC acceptance region (0.9 < eta < 2.4). More technical information can be found in this talk: https://indico.cern.ch/event/1336796/#45-studies-on-trigger-efficien
  • The minETA default value is set to 0.0 to keep other HLT paths which use this filter (like HLT_MET105_IsoTrk50_v13) unaffected

PR validation:

Validated and tested with hltGetConfiguration

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Backport of #43132
Need to have the changes available in the HLT offline menu for integration purposes.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 2, 2023

A new Pull Request was created by @fmanteca (Pedro J. Fernndez Manteca) for CMSSW_13_2_X.

It involves the following packages:

  • RecoTracker/DeDx (reconstruction)

@jfernan2, @cmsbuild, @mandrenguyen can you please review it and eventually sign? Thanks.
@dgulhan, @mtosi, @JanFSchulte, @missirol, @felicepantaleo, @gpetruc, @rovere, @VourMa, @GiacomoSguazzoni, @VinInn, @mmusich this is something you requested to watch as well.
@antoniovilela, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor

mmusich commented Nov 2, 2023

backport of #43132

@mmusich
Copy link
Contributor

mmusich commented Nov 2, 2023

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 2, 2023

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ca616b/35557/summary.html
COMMIT: 4a73d2b
CMSSW: CMSSW_13_2_X_2023-11-01-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43168/35557/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 1 lines to the logs
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3198785
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3198760
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 2, 2023

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit f89f56a into cms-sw:CMSSW_13_2_X Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants