Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add minETA selection to HLT filter RecoTracker/DeDx/plugins/HLTDeDxFilter #43132

Merged
merged 1 commit into from
Nov 1, 2023
Merged

Conversation

fmanteca
Copy link
Contributor

PR description:

Added one parameter to the HLT filter RecoTracker/DeDx/plugins/HLTDeDxFilter to set a minimum eta cut on the reconstructed tracker track.

  • This updated filter will be used in a new HLT path in 2024 to improve the high-pt muon efficiency in the CSC acceptance region (0.9 < eta < 2.4). More technical information can be found in this talk: https://indico.cern.ch/event/1336796/#45-studies-on-trigger-efficien
  • The minETA default value is set to 0.0 to keep other HLT paths which use this filter (like HLT_MET105_IsoTrk50_v13) unaffected

PR validation:

Validated and tested with hltGetConfiguration

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43132/37403

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @fmanteca (Pedro J. Fernández Manteca) for master.

It involves the following packages:

  • RecoTracker/DeDx (reconstruction)

@mandrenguyen, @jfernan2, @cmsbuild can you please review it and eventually sign? Thanks.
@felicepantaleo, @rovere, @dgulhan, @missirol, @VourMa, @JanFSchulte, @VinInn, @gpetruc, @mmusich, @GiacomoSguazzoni, @mtosi this is something you requested to watch as well.
@antoniovilela, @sextonkennedy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor

mmusich commented Oct 27, 2023

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d83317/35456/summary.html
COMMIT: ab9d1e0
CMSSW: CMSSW_13_3_X_2023-10-26-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/43132/35456/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

  • 4.764.76_ZMuSkim2012D/step2_ZMuSkim2012D.log

Comparison Summary

Summary:

  • You potentially removed 5 lines from the logs
  • Reco comparison results: 24 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3357400
  • DQMHistoTests: Total failures: 1070
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3356308
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 214 log files, 167 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@Martin-Grunewald
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d83317/35464/summary.html
COMMIT: ab9d1e0
CMSSW: CMSSW_13_3_X_2023-10-26-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/43132/35464/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

  • 4.764.76_ZMuSkim2012D/step2_ZMuSkim2012D.log

Comparison Summary

Summary:

  • You potentially removed 5 lines from the logs
  • Reco comparison results: 24 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3357400
  • DQMHistoTests: Total failures: 1067
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3356311
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 214 log files, 167 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@mandrenguyen
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d83317/35499/summary.html
COMMIT: ab9d1e0
CMSSW: CMSSW_13_3_X_2023-10-29-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43132/35499/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 4 lines to the logs
  • Reco comparison results: 28 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3362691
  • DQMHistoTests: Total failures: 1070
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3361599
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 214 log files, 167 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@fwyzard
Copy link
Contributor

fwyzard commented Nov 1, 2023

@cms-sw/hlt-l2 FYI

@mmusich
Copy link
Contributor

mmusich commented Nov 1, 2023

@cms-sw/hlt-l2 FYI

We already know (see previous interaction at #43132 (comment)), thanks. This is missing @cms-sw/reconstruction-l2 signature

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 1, 2023

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@antoniovilela
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 18f34e2 into cms-sw:master Nov 1, 2023
@mmusich
Copy link
Contributor

mmusich commented Nov 1, 2023

@fmanteca, please prepare a backport to 13.2.x in case we need it for integration of your new triggers in the offline menu

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants