[JMENano] Fix GenJetIdx for AK4 jets matched to low pt genjets #43144

nurfikri89 · 2023-10-29T06:32:41Z

PR description:

This PR fixes an issue with the GenJetIdx of AK4 reco jets for JMENano. Due to PR #41039, AK4 reco jets that are matched to AK4 Gen jets with pt < 10 GeV have GenJetIdx value set to -1. For JMENano, the AK4 Gen jet collection is rebuilt with a pt cut of 5 GeV (at the clustering level) so this PR removes the Gen jet pt > 10 GeV requirement for the GenJetIdx of AK4 reco jets.

PR validation:

passes the standard runTheMatrix test: runTheMatrix.py -l limited -i all --ibeos

cmsbuild · 2023-10-29T06:38:58Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43144/37424

This PR adds an extra 24KB to repository

cmsbuild · 2023-10-29T06:39:17Z

A new Pull Request was created by @nurfikri89 (Nurfikri Norjoharuddeen) for master.

It involves the following packages:

PhysicsTools/NanoAOD (xpog)

@cmsbuild, @vlimant, @simonepigazzini can you please review it and eventually sign? Thanks.
@gpetruc, @AnnikaStein this is something you requested to watch as well.
@rappoccio, @sextonkennedy, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

smuzaffar · 2023-11-06T16:51:29Z

Milestone for this pull request has been moved to CMSSW_14_0_X.Please open a backport if it should also go in to CMSSW_13_3_X.

nurfikri89 · 2023-11-07T11:56:20Z

Hi @simonepigazzini @vlimant, can you please trigger the test for this PR?

simonepigazzini · 2023-11-07T12:30:00Z

enable nano

simonepigazzini · 2023-11-07T12:30:07Z

please test

cmsbuild · 2023-11-07T14:22:48Z

-1

Failed Tests: RelVals
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-aeca12/35664/summary.html
COMMIT: a0de880
CMSSW: CMSSW_14_0_X_2023-11-07-1100/el8_amd64_gcc12
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/43144/35664/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

25034.999

----- Begin Fatal Exception 07-Nov-2023 14:57:08 CET-----------------------
An exception of category 'FallbackFileOpenError' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=MixingModule label='mix'
   [2] Calling RootInputFileSequence::initTheFile()
   [3] Calling StorageFactory::open()
   [4] Calling XrdFile::open()
Exception Message:
Failed to open the file 'root://xrootd-cms.infn.it//store/relval/CMSSW_13_2_0_pre1/RelValMinBias_14TeV/GEN-SIM/131X_mcRun4_realistic_v5_2026D98noPU-v1/2590000/1e6ae6fd-8ac7-4eca-b727-3252ae4ff52f.root'
   Additional Info:
      [a] Calling RootInputFileSequence::initTheFile(): fail to open the file with name root://cms-xrd-global.cern.ch//eos/cms/store/relval/CMSSW_13_2_0_pre1/RelValMinBias_14TeV/GEN-SIM/131X_mcRun4_realistic_v5_2026D98noPU-v1/2590000/1e6ae6fd-8ac7-4eca-b727-3252ae4ff52f.root
      [b] Calling RootInputFileSequence::initTheFile(): fail to open the file with name root://eoscms.cern.ch//eos/cms/store/user/cmsbuild/store/relval/CMSSW_13_2_0_pre1/RelValMinBias_14TeV/GEN-SIM/131X_mcRun4_realistic_v5_2026D98noPU-v1/2590000/1e6ae6fd-8ac7-4eca-b727-3252ae4ff52f.root
      [c] Input file root://xrootd-cms.infn.it//store/relval/CMSSW_13_2_0_pre1/RelValMinBias_14TeV/GEN-SIM/131X_mcRun4_realistic_v5_2026D98noPU-v1/2590000/1e6ae6fd-8ac7-4eca-b727-3252ae4ff52f.root could not be opened.
      [d] XrdCl::File::Open(name='root://xrootd-cms.infn.it//store/relval/CMSSW_13_2_0_pre1/RelValMinBias_14TeV/GEN-SIM/131X_mcRun4_realistic_v5_2026D98noPU-v1/2590000/1e6ae6fd-8ac7-4eca-b727-3252ae4ff52f.root', flags=0x10, permissions=0660) => error '[FATAL] Redirect limit has been reached' (errno=0, code=306). No additional data servers were found.
      [e] Last URL tried: root://eoscmshlt-ip565.cern.ch:1098//store/relval/CMSSW_13_2_0_pre1/RelValMinBias_14TeV/GEN-SIM/131X_mcRun4_realistic_v5_2026D98noPU-v1/2590000/1e6ae6fd-8ac7-4eca-b727-3252ae4ff52f.root?tried=&xrdcl.requuid=3400159f-63c6-419b-adb5-32b91325b4b2
      [f] Problematic data server: eoscmshlt-ip565.cern.ch:1098
      [g] Disabled source: eoscmshlt-ip565.cern.ch:1098
----- End Fatal Exception -------------------------------------------------

NANO Comparison Summary

Summary:

You potentially added 1 lines to the logs
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 15
DQMHistoTests: Total histograms compared: 16314
DQMHistoTests: Total failures: 0
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 16314
DQMHistoTests: Total skipped: 0
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 14 files compared)
Checked 34 log files, 16 edm output root files, 15 DQM output files

Nano size comparison Summary:

Sample	kb/ev	ref kb/ev	diff kb/ev	ev/s/thd	ref ev/s/thd	diff rate	mem/thd	ref mem/thd
2500.0	2.531	2.531	0.000 ( +0.0% )	5.28	5.35	-1.3%	2.067	1.991
2500.001	2.677	2.677	0.000 ( +0.0% )	4.74	4.74	+0.1%	2.483	2.031
2500.002	2.611	2.611	0.000 ( +0.0% )	4.96	4.92	+0.8%	2.482	2.025
2500.01	1.304	1.304	0.000 ( +0.0% )	9.54	9.58	-0.4%	2.155	1.852
2500.011	1.717	1.717	0.000 ( +0.0% )	5.21	5.20	+0.4%	2.305	1.870
2500.012	1.564	1.564	0.000 ( +0.0% )	7.41	7.48	-1.0%	2.193	1.834
2500.1	2.183	2.183	0.000 ( +0.0% )	5.33	5.37	-0.9%	1.981	1.959
2500.2	2.294	2.294	0.000 ( +0.0% )	6.13	6.13	-0.0%	1.896	1.845
2500.21	1.170	1.170	0.000 ( +0.0% )	4.39	4.40	-0.2%	2.174	1.864
2500.211	1.531	1.531	0.000 ( +0.0% )	3.86	3.88	-0.5%	2.147	1.860
2500.3	2.050	2.050	0.000 ( +0.0% )	12.89	13.04	-1.2%	1.883	1.881
2500.31	1.245	1.245	0.000 ( +0.0% )	19.94	20.54	-2.9%	2.255	2.250
2500.311	1.631	1.631	0.000 ( +0.0% )	13.90	14.28	-2.7%	2.328	2.325
2500.4	2.050	2.050	0.000 ( +0.0% )	12.89	13.06	-1.3%	1.884	1.887
2500.5	19.544	19.544	0.000 ( +0.0% )	1.46	1.36	+7.6%	1.300	1.296

simonepigazzini · 2023-11-08T08:39:02Z

please test

cmsbuild · 2023-11-08T12:06:43Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-aeca12/35687/summary.html
COMMIT: a0de880
CMSSW: CMSSW_14_0_X_2023-11-07-2300/el8_amd64_gcc12
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/43144/35687/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially removed 160 lines from the logs
Reco comparison results: 134 differences found in the comparisons
DQMHistoTests: Total files compared: 50
DQMHistoTests: Total histograms compared: 3363010
DQMHistoTests: Total failures: 1788
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3361200
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
Checked 214 log files, 167 edm output root files, 50 DQM output files
TriggerResults: no differences found

NANO Comparison Summary

Summary:

You potentially removed 2 lines from the logs
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 15
DQMHistoTests: Total histograms compared: 16314
DQMHistoTests: Total failures: 0
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 16314
DQMHistoTests: Total skipped: 0
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 14 files compared)
Checked 34 log files, 16 edm output root files, 15 DQM output files

Nano size comparison Summary:

Sample	kb/ev	ref kb/ev	diff kb/ev	ev/s/thd	ref ev/s/thd	diff rate	mem/thd	ref mem/thd
2500.0	2.531	2.531	0.000 ( +0.0% )	5.34	5.32	+0.3%	2.040	2.130
2500.001	2.677	2.677	0.000 ( +0.0% )	4.79	4.76	+0.6%	2.469	2.538
2500.002	2.611	2.611	0.000 ( +0.0% )	4.96	4.98	-0.5%	2.466	2.532
2500.01	1.304	1.304	0.000 ( +0.0% )	9.59	9.99	-4.0%	2.098	2.242
2500.011	1.717	1.717	0.000 ( +0.0% )	5.24	5.35	-2.0%	2.247	2.432
2500.012	1.564	1.564	0.000 ( +0.0% )	7.54	7.64	-1.3%	2.179	2.342
2500.1	2.183	2.183	0.000 ( +0.0% )	5.35	5.35	-0.1%	1.895	1.976
2500.2	2.294	2.294	0.000 ( +0.0% )	6.17	6.19	-0.2%	1.790	1.898
2500.21	1.170	1.170	0.000 ( +0.0% )	4.38	4.42	-0.9%	2.074	2.180
2500.211	1.531	1.531	0.000 ( +0.0% )	3.86	3.89	-0.6%	2.084	2.262
2500.3	2.050	2.050	0.000 ( +0.0% )	13.09	12.96	+1.0%	1.811	1.883
2500.31	1.245	1.245	0.000 ( +0.0% )	20.48	20.62	-0.7%	2.121	2.275
2500.311	1.631	1.631	0.000 ( +0.0% )	14.23	14.60	-2.5%	2.157	2.345
2500.4	2.050	2.050	0.000 ( +0.0% )	13.00	12.96	+0.3%	1.802	1.885
2500.5	19.544	19.544	0.000 ( +0.0% )	1.36	1.27	+7.2%	1.301	1.297

vlimant · 2023-11-20T12:35:40Z

+1

cmsbuild · 2023-11-20T12:36:03Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

rappoccio · 2023-11-20T14:37:01Z

+1

Fix GenJetIdx for AK4 jets matched to low pt genjets

a0de880

cmsbuild added this to the CMSSW_13_3_X milestone Oct 29, 2023

cmsbuild added pending-signatures tests-pending orp-pending code-checks-pending xpog-pending labels Oct 29, 2023

cmsbuild added code-checks-approved and removed code-checks-pending labels Oct 29, 2023

smuzaffar modified the milestones: CMSSW_13_3_X, CMSSW_14_0_X Nov 6, 2023

cmsbuild modified the milestones: CMSSW_14_0_X, CMSSW_13_3_X Nov 6, 2023

cmsbuild added tests-started and removed tests-pending labels Nov 7, 2023

cmsbuild added tests-rejected and removed tests-started labels Nov 7, 2023

cmsbuild added tests-started and removed tests-rejected labels Nov 8, 2023

cmsbuild added tests-approved and removed tests-started labels Nov 8, 2023

cmsbuild added fully-signed xpog-approved and removed pending-signatures xpog-pending labels Nov 20, 2023

cmsbuild added orp-approved and removed orp-pending labels Nov 20, 2023

cmsbuild merged commit b57517f into cms-sw:master Nov 20, 2023

cmsbuild mentioned this pull request Nov 20, 2023

DisplacedRegionalStep track DNN #43336

Merged

nurfikri89 deleted the from1330pre4_jmenano_FixGenJetIdx branch February 25, 2024 14:21

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[JMENano] Fix GenJetIdx for AK4 jets matched to low pt genjets #43144

[JMENano] Fix GenJetIdx for AK4 jets matched to low pt genjets #43144

nurfikri89 commented Oct 29, 2023

cmsbuild commented Oct 29, 2023

cmsbuild commented Oct 29, 2023

smuzaffar commented Nov 6, 2023

nurfikri89 commented Nov 7, 2023

simonepigazzini commented Nov 7, 2023

simonepigazzini commented Nov 7, 2023

cmsbuild commented Nov 7, 2023

simonepigazzini commented Nov 8, 2023

cmsbuild commented Nov 8, 2023

vlimant commented Nov 20, 2023

cmsbuild commented Nov 20, 2023

rappoccio commented Nov 20, 2023

[JMENano] Fix GenJetIdx for AK4 jets matched to low pt genjets #43144

[JMENano] Fix GenJetIdx for AK4 jets matched to low pt genjets #43144

Conversation

nurfikri89 commented Oct 29, 2023

PR description:

PR validation:

cmsbuild commented Oct 29, 2023

cmsbuild commented Oct 29, 2023

smuzaffar commented Nov 6, 2023

nurfikri89 commented Nov 7, 2023

simonepigazzini commented Nov 7, 2023

simonepigazzini commented Nov 7, 2023

cmsbuild commented Nov 7, 2023

RelVals

NANO Comparison Summary

simonepigazzini commented Nov 8, 2023

cmsbuild commented Nov 8, 2023

Comparison Summary

NANO Comparison Summary

vlimant commented Nov 20, 2023

cmsbuild commented Nov 20, 2023

rappoccio commented Nov 20, 2023