[Nano] Fix JetTable genJetIdx matching

[swertz]

PR description:

Same as #33839 but for regular jets instead of fat jets: in some rare cases, the index of the genJet matched to a jet points to a genJet which is not stored, because of the pt cut applied to the GenJet collection.

This fix frees the user from having to check that Jet_genJetIdx < nGenJet.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41039/34585

• This PR adds an extra 12KB to repository

[cmsbuild]

A new Pull Request was created by @swertz (Sébastien Wertz) for master.

It involves the following packages:

• PhysicsTools/NanoAOD (xpog)

@cmsbuild, @swertz, @vlimant can you please review it and eventually sign? Thanks.
@gpetruc, @AnnikaStein this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[swertz]

enable nano

[swertz]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1f2fdb/31237/summary.html
COMMIT: 56c28e5
CMSSW: CMSSW_13_1_X_2023-03-12-2300/el8_amd64_gcc11
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/41039/31237/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 4 lines to the logs
• Reco comparison results: 5 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3550756
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3550733
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 213 log files, 164 edm output root files, 49 DQM output files
• TriggerResults: no differences found

NANO Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 6 differences found in the comparisons
• DQMHistoTests: Total files compared: 11
• DQMHistoTests: Total histograms compared: 10829
• DQMHistoTests: Total failures: 0
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 10829
• DQMHistoTests: Total skipped: 0
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 10 files compared)
• Checked 23 log files, 10 edm output root files, 11 DQM output files

Nano size comparison Summary:

Sample	kb/ev	ref kb/ev	diff kb/ev	ev/s/thd	ref ev/s/thd	diff rate	mem/thd	ref mem/thd
2500.31	2.224	2.224	-0.000 ( -0.0% )	9.42	9.53	-1.2%	1.496	1.460
2500.311	2.323	2.323	-0.000 ( -0.0% )	9.11	9.35	-2.6%	1.853	1.838
2500.312	2.277	2.277	-0.000 ( -0.0% )	9.23	9.52	-3.0%	1.842	1.827
2500.33	1.099	1.099	0.000 ( +0.0% )	20.77	22.29	-6.8%	1.628	1.633
2500.331	1.394	1.394	0.000 ( +0.0% )	15.57	16.36	-4.8%	1.789	1.773
2500.332	1.326	1.326	0.000 ( +0.0% )	17.47	18.36	-4.8%	1.823	1.836
2500.401	2.138	2.139	-0.000 ( -0.0% )	10.44	10.53	-0.8%	1.219	1.162
2500.501	1.711	1.711	0.000 ( +0.0% )	16.62	16.77	-0.9%	1.127	1.093
2500.511	1.124	1.124	0.000 ( +0.0% )	30.99	31.65	-2.1%	1.354	1.350
2500.601	2.050	2.050	-0.000 ( -0.0% )	12.56	12.53	+0.3%	1.198	1.143

[swertz]

+1

Slightly more jets in NanoAOD with a genJetIdx of -1, which is expected.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1