-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup CICADA/CaloSummary emulation and make CICADA versions available as templated plugins #43091
Conversation
…le as templated plugins
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43091/37326
|
A new Pull Request was created by @aloeliger (Andrew Loeliger) for master. It involves the following packages:
@epalencia, @cmsbuild, @aloeliger can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test with cms-sw/cmsdist#8781 |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43091/37327
|
Pull request #43091 was updated. @epalencia, @aloeliger can you please check and sign again. |
+l1
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
This PR cleans up several poorly formatted elements of the CaloSummary emulator, and makes it's central feature, CICADA, slightly more configurable by making template plugin versions to match the data types for CICADA versions (i.e. CICADA v1 has a plugin version defined by template, CICADA v2 has a different version defined by template, etc.).
This is in preparation to begin moving the CaloSummary emulator into the main L1 sequence, in preparation for further integration downstream.
Relies upon (somewhat, as it is in no standard sequences yet) cms-sw/cmsdist#8781
PR validation:
All code compiles and has had tests run and code formatting applied. As the emulator is not in any standard sequences yet, no changes are expected. A similar version of this code has been running our emulation studies on CICADA for a while.
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
This PR is not a backport. A backport is only foreseen if L1/HLT menu studies are performed on earlier versions of CMSSW.