Skip to content

Commit

Permalink
Merge pull request #43091 from aloeliger/cleanupCICADAEmulation
Browse files Browse the repository at this point in the history 
Cleanup CICADA/CaloSummary emulation and make CICADA versions available as templated plugins
  • Loading branch information
@cmsbuild
cmsbuild authored Oct 24, 2023
2 parents bca672b + de4e2fb commit 7d0fde6
Show file tree
Hide file tree
Showing 3 changed files with 70 additions and 102 deletions.
68 changes: 18 additions & 50 deletions L1Trigger/L1TCaloLayer1/plugins/L1TCaloSummary.cc
View file
Original file line number Diff line number Diff line change
Expand Up @@ -69,10 +69,11 @@ using namespace std;
// class declaration
//

template <class INPUT, class OUTPUT>
class L1TCaloSummary : public edm::stream::EDProducer<> {
public:
explicit L1TCaloSummary(const edm::ParameterSet&);
~L1TCaloSummary() override;
~L1TCaloSummary() override = default;

static void fillDescriptions(edm::ConfigurationDescriptions& descriptions);

Expand All @@ -81,7 +82,7 @@ class L1TCaloSummary : public edm::stream::EDProducer<> {
void produce(edm::Event&, const edm::EventSetup&) override;
//void endJob() override;

void beginRun(edm::Run const&, edm::EventSetup const&) override;
void beginRun(edm::Run const&, edm::EventSetup const&) override{};

void print();

Expand Down Expand Up @@ -122,7 +123,8 @@ class L1TCaloSummary : public edm::stream::EDProducer<> {
//
// constructors and destructor
//
L1TCaloSummary::L1TCaloSummary(const edm::ParameterSet& iConfig)
template <class INPUT, class OUTPUT>
L1TCaloSummary<INPUT, OUTPUT>::L1TCaloSummary(const edm::ParameterSet& iConfig)
: nPumBins(iConfig.getParameter<unsigned int>("nPumBins")),
pumLUT(nPumBins, std::vector<std::vector<uint32_t>>(2, std::vector<uint32_t>(13))),
caloScaleFactor(iConfig.getParameter<double>("caloScaleFactor")),
Expand Down Expand Up @@ -161,14 +163,13 @@ L1TCaloSummary::L1TCaloSummary(const edm::ParameterSet& iConfig)
produces<float>("anomalyScore");
}

L1TCaloSummary::~L1TCaloSummary() {}

//
// member functions
//

// ------------ method called to produce the data ------------
void L1TCaloSummary::produce(edm::Event& iEvent, const edm::EventSetup& iSetup) {
template <class INPUT, class OUTPUT>
void L1TCaloSummary<INPUT, OUTPUT>::produce(edm::Event& iEvent, const edm::EventSetup& iSetup) {
using namespace edm;

std::unique_ptr<L1JetParticleCollection> bJetCands(new L1JetParticleCollection);
Expand All @@ -192,8 +193,7 @@ void L1TCaloSummary::produce(edm::Event& iEvent, const edm::EventSetup& iSetup)
//Model input
//This is done as a flat vector input, but future versions may involve 2D input
//This will have to be handled later
//Would also be good to be able to configure the precision of the ap_fixed type
ap_ufixed<10, 10> modelInput[252];
INPUT modelInput[252];
for (const L1CaloRegion& i : *regionCollection) {
UCTRegionIndex r = g.getUCTRegionIndexFromL1CaloRegion(i.gctEta(), i.gctPhi());
UCTTowerIndex t = g.getUCTTowerIndexFromL1CaloRegion(r, i.raw());
Expand All @@ -212,12 +212,12 @@ void L1TCaloSummary::produce(edm::Event& iEvent, const edm::EventSetup& iSetup)
//We take 4 off of the GCT eta/iEta.
//iEta taken from this ranges from 4-17, (I assume reserving lower and higher for forward regions)
//So our first index, index 0, is technically iEta=4, and so-on.
//CICADA v1 reads this as a flat vector
//CICADA reads this as a flat vector
modelInput[14 * i.gctPhi() + (i.gctEta() - 4)] = i.et();
}
//Extract model output
//Would be good to be able to configure the precision of the result
ap_fixed<11, 5> modelResult[1] = {ap_fixed<11, 5>("0.0", 10)};
OUTPUT modelResult[1] = {
OUTPUT("0.0", 10)}; //the 10 here refers to the fact that we read in "0.0" as a decimal number
model->prepare_input(modelInput);
model->predict();
model->read_result(modelResult);
Expand Down Expand Up @@ -291,50 +291,18 @@ void L1TCaloSummary::produce(edm::Event& iEvent, const edm::EventSetup& iSetup)
iEvent.put(std::move(anomalyScore), "anomalyScore");
}

void L1TCaloSummary::print() {}

// ------------ method called once each job just before starting event loop ------------
//void L1TCaloSummary::beginJob() {}

// ------------ method called once each job just after ending the event loop ------------
//void L1TCaloSummary::endJob() {}

// ------------ method called when starting to processes a run ------------

void L1TCaloSummary::beginRun(edm::Run const& iRun, edm::EventSetup const& iSetup) {}

// ------------ method called when ending the processing of a run ------------
/*
void
L1TCaloSummary::endRun(edm::Run const&, edm::EventSetup const&)
{
}
*/

// ------------ method called when starting to processes a luminosity block ------------
/*
void
L1TCaloSummary::beginLuminosityBlock(edm::LuminosityBlock const&, edm::EventSetup const&)
{
}
*/

// ------------ method called when ending the processing of a luminosity block ------------
/*
void
L1TCaloSummary::endLuminosityBlock(edm::LuminosityBlock const&, edm::EventSetup const&)
{
}
*/

// ------------ method fills 'descriptions' with the allowed parameters for the module ------------
void L1TCaloSummary::fillDescriptions(edm::ConfigurationDescriptions& descriptions) {
template <class INPUT, class OUTPUT>
void L1TCaloSummary<INPUT, OUTPUT>::fillDescriptions(edm::ConfigurationDescriptions& descriptions) {
//The following says we do not know what parameters are allowed so do no validation
// Please change this to state exactly what you do use, even if it is no parameters
edm::ParameterSetDescription desc;
desc.setUnknown();
descriptions.addDefault(desc);
}

//define this as a plug-in
DEFINE_FWK_MODULE(L1TCaloSummary);
typedef L1TCaloSummary<ap_ufixed<10, 10>, ap_fixed<11, 5>> L1TCaloSummaryCICADAv1;
typedef L1TCaloSummary<ap_uint<10>, ap_ufixed<16, 8>> L1TCaloSummaryCICADAv2;
//define type version plugins
DEFINE_FWK_MODULE(L1TCaloSummaryCICADAv1);
DEFINE_FWK_MODULE(L1TCaloSummaryCICADAv2);
52 changes: 52 additions & 0 deletions L1Trigger/L1TCaloLayer1/python/simCaloStage2Layer1Summary_cfi.py
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,52 @@
import FWCore.ParameterSet.Config as cms

simCaloStage2Layer1Summary = cms.EDProducer('L1TCaloSummaryCICADAv2',
nPumBins = cms.uint32(18),
pumLUT00n= cms.vdouble(0.43, 0.32, 0.29, 0.36, 0.33, 0.25, 0.25, 0.25, 0.25, 0.25, 0.25, 0.25, 0.25),
pumLUT00p= cms.vdouble(0.45, 0.32, 0.29, 0.35, 0.31, 0.25, 0.25, 0.25, 0.25, 0.25, 0.25, 0.25, 0.25),
pumLUT01n= cms.vdouble(0.60, 0.39, 0.33, 0.44, 0.39, 0.26, 0.27, 0.26, 0.26, 0.25, 0.25, 0.25, 0.25),
pumLUT01p= cms.vdouble(0.60, 0.39, 0.33, 0.41, 0.35, 0.26, 0.27, 0.26, 0.26, 0.25, 0.25, 0.25, 0.25),
pumLUT02n= cms.vdouble(0.76, 0.52, 0.46, 0.57, 0.52, 0.33, 0.41, 0.34, 0.31, 0.29, 0.27, 0.26, 0.25),
pumLUT02p= cms.vdouble(0.75, 0.52, 0.46, 0.55, 0.48, 0.34, 0.42, 0.34, 0.31, 0.29, 0.27, 0.26, 0.25),
pumLUT03n= cms.vdouble(0.90, 0.63, 0.56, 0.69, 0.62, 0.39, 0.58, 0.41, 0.37, 0.33, 0.29, 0.27, 0.25),
pumLUT03p= cms.vdouble(0.90, 0.64, 0.56, 0.66, 0.57, 0.39, 0.58, 0.41, 0.37, 0.33, 0.29, 0.26, 0.25),
pumLUT04n= cms.vdouble(1.03, 0.74, 0.66, 0.80, 0.72, 0.45, 0.80, 0.50, 0.45, 0.39, 0.32, 0.28, 0.25),
pumLUT04p= cms.vdouble(1.03, 0.76, 0.67, 0.77, 0.67, 0.46, 0.81, 0.50, 0.45, 0.39, 0.32, 0.27, 0.25),
pumLUT05n= cms.vdouble(1.17, 0.86, 0.77, 0.92, 0.83, 0.53, 1.09, 0.60, 0.55, 0.47, 0.37, 0.29, 0.26),
pumLUT05p= cms.vdouble(1.18, 0.88, 0.77, 0.89, 0.77, 0.54, 1.10, 0.61, 0.55, 0.47, 0.35, 0.29, 0.26),
pumLUT06n= cms.vdouble(1.32, 0.98, 0.88, 1.04, 0.93, 0.61, 1.44, 0.72, 0.66, 0.57, 0.42, 0.31, 0.26),
pumLUT06p= cms.vdouble(1.32, 1.00, 0.89, 1.01, 0.88, 0.63, 1.46, 0.73, 0.67, 0.57, 0.41, 0.30, 0.26),
pumLUT07n= cms.vdouble(1.47, 1.11, 1.01, 1.17, 1.05, 0.71, 1.86, 0.86, 0.81, 0.69, 0.50, 0.34, 0.27),
pumLUT07p= cms.vdouble(1.48, 1.14, 1.01, 1.13, 0.99, 0.73, 1.89, 0.87, 0.82, 0.70, 0.47, 0.33, 0.27),
pumLUT08n= cms.vdouble(1.63, 1.26, 1.14, 1.30, 1.17, 0.82, 2.37, 1.02, 0.98, 0.85, 0.59, 0.37, 0.28),
pumLUT08p= cms.vdouble(1.64, 1.28, 1.15, 1.26, 1.11, 0.85, 2.41, 1.03, 0.99, 0.86, 0.56, 0.36, 0.28),
pumLUT09n= cms.vdouble(1.81, 1.41, 1.28, 1.45, 1.31, 0.95, 2.98, 1.20, 1.18, 1.03, 0.71, 0.42, 0.30),
pumLUT09p= cms.vdouble(1.82, 1.45, 1.29, 1.41, 1.24, 0.98, 3.02, 1.21, 1.19, 1.05, 0.67, 0.40, 0.29),
pumLUT10n= cms.vdouble(2.01, 1.58, 1.43, 1.62, 1.45, 1.10, 3.70, 1.41, 1.42, 1.26, 0.87, 0.48, 0.32),
pumLUT10p= cms.vdouble(2.02, 1.61, 1.46, 1.58, 1.38, 1.13, 3.73, 1.42, 1.43, 1.27, 0.82, 0.46, 0.31),
pumLUT11n= cms.vdouble(2.24, 1.78, 1.61, 1.78, 1.60, 1.27, 4.55, 1.64, 1.71, 1.55, 1.08, 0.57, 0.36),
pumLUT11p= cms.vdouble(2.21, 1.82, 1.63, 1.75, 1.53, 1.31, 4.67, 1.67, 1.71, 1.57, 1.01, 0.54, 0.36),
pumLUT12n= cms.vdouble(2.50, 2.00, 1.82, 1.91, 1.81, 1.56, 5.56, 1.85, 2.01, 1.87, 1.31, 0.68, 0.42),
pumLUT12p= cms.vdouble(2.44, 2.02, 1.90, 2.01, 1.70, 1.51, 5.61, 1.96, 2.04, 1.80, 1.24, 0.65, 0.43),
pumLUT13n= cms.vdouble(2.96, 2.40, 2.14, 2.41, 2.01, 1.76, 8.05, 2.41, 2.43, 2.17, 1.67, 0.90, 0.59),
pumLUT13p= cms.vdouble(3.28, 2.64, 2.26, 2.23, 1.97, 1.89, 7.61, 2.27, 2.33, 2.26, 1.44, 0.79, 0.52),
pumLUT14n= cms.vdouble(2.96, 2.40, 2.14, 2.41, 2.01, 1.76, 8.05, 2.41, 2.43, 2.17, 1.67, 0.90, 0.59),
pumLUT14p= cms.vdouble(3.28, 2.64, 2.26, 2.23, 1.97, 1.89, 7.61, 2.27, 2.33, 2.26, 1.44, 0.79, 0.52),
pumLUT15n= cms.vdouble(2.96, 2.40, 2.14, 2.41, 2.01, 1.76, 8.05, 2.41, 2.43, 2.17, 1.67, 0.90, 0.59),
pumLUT15p= cms.vdouble(3.28, 2.64, 2.26, 2.23, 1.97, 1.89, 7.61, 2.27, 2.33, 2.26, 1.44, 0.79, 0.52),
pumLUT16n= cms.vdouble(2.96, 2.40, 2.14, 2.41, 2.01, 1.76, 8.05, 2.41, 2.43, 2.17, 1.67, 0.90, 0.59),
pumLUT16p= cms.vdouble(3.28, 2.64, 2.26, 2.23, 1.97, 1.89, 7.61, 2.27, 2.33, 2.26, 1.44, 0.79, 0.52),
pumLUT17n= cms.vdouble(2.96, 2.40, 2.14, 2.41, 2.01, 1.76, 8.05, 2.41, 2.43, 2.17, 1.67, 0.90, 0.59),
pumLUT17p= cms.vdouble(3.28, 2.64, 2.26, 2.23, 1.97, 1.89, 7.61, 2.27, 2.33, 2.26, 1.44, 0.79, 0.52),
caloScaleFactor = cms.double(0.5),
jetSeed = cms.uint32(10),
tauSeed = cms.uint32(10),
tauIsolationFactor = cms.double(0.3),
eGammaSeed = cms.uint32(5),
eGammaIsolationFactor = cms.double(0.3),
boostedJetPtFactor = cms.double(1.5),
verbose = cms.bool(False),
# See UCTLayer1.hh for firmware version
firmwareVersion = cms.int32(1),
CICADAModelVersion = cms.string("CICADAModel_v2p1")
)
52 changes: 0 additions & 52 deletions L1Trigger/L1TCaloLayer1/python/uct2016EmulatorDigis_cfi.py
View file

This file was deleted.

0 comments on commit 7d0fde6

Please sign in to comment.