Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NanoAOD] Add pthatmax variable #43060

Merged

Conversation

nurfikri89
Copy link
Contributor

@nurfikri89 nurfikri89 commented Oct 19, 2023

PR description:

This PR switches on the flag to save the pthatmax variable in the Pileup table for central NanoAOD, beginning from v13. The event size increase is negligible (0.002 kb /event).

PR validation:

  • passes the standard runTheMatrix test: runTheMatrix.py -l limited -i all --ibeos
  • passes the following NanoAOD workflows: runTheMatrix.py -i all --ibeos -l 2500.0,2500.001,2500.002,2500.01,2500.011,2500.012,2500.1,2500.2,2500.21,2500.3,2500.31,2500.4

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43060/37263

  • This PR adds an extra 32KB to repository

  • There are other open Pull requests which might conflict with changes you have proposed:

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @nurfikri89 (Nurfikri Norjoharuddeen) for master.

It involves the following packages:

  • PhysicsTools/NanoAOD (xpog)

@cmsbuild, @vlimant, @simonepigazzini can you please review it and eventually sign? Thanks.
@gpetruc, @AnnikaStein this is something you requested to watch as well.
@sextonkennedy, @rappoccio, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

@vlimant
Copy link
Contributor

vlimant commented Oct 24, 2023

enable nano

@vlimant
Copy link
Contributor

vlimant commented Oct 24, 2023

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-915a3e/35385/summary.html
COMMIT: 9eb9e52
CMSSW: CMSSW_13_3_X_2023-10-24-1100/el8_amd64_gcc12
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/43060/35385/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 1 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 30 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3357400
  • DQMHistoTests: Total failures: 1067
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3356311
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 1.309 KiB( 49 files compared)
  • DQMHistoSizes: changed ( 11634.0,... ): 0.119 KiB Physics/NanoAODDQM
  • Checked 214 log files, 167 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

NANO Comparison Summary

Summary:

  • You potentially added 3 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 15
  • DQMHistoTests: Total histograms compared: 15925
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 15925
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.476 KiB( 14 files compared)
  • DQMHistoSizes: changed ( 2500.311,... ): 0.119 KiB Physics/NanoAODDQM
  • Checked 34 log files, 16 edm output root files, 15 DQM output files

Nano size comparison Summary:

Sample kb/ev ref kb/ev diff kb/ev ev/s/thd ref ev/s/thd diff rate mem/thd ref mem/thd
2500.0 2.500 2.500 0.000 ( +0.0% ) 5.35 5.31 +0.7% 1.968 2.049
2500.001 2.649 2.649 0.000 ( +0.0% ) 4.77 4.76 +0.2% 2.389 2.440
2500.002 2.556 2.556 0.000 ( +0.0% ) 4.97 4.86 +2.4% 2.387 2.434
2500.01 1.285 1.285 0.000 ( +0.0% ) 9.81 9.72 +0.9% 2.173 2.128
2500.011 1.659 1.659 0.000 ( +0.0% ) 5.33 5.21 +2.4% 2.315 2.267
2500.012 1.539 1.539 0.000 ( +0.0% ) 7.52 7.50 +0.2% 2.226 2.195
2500.1 2.155 2.155 0.000 ( +0.0% ) 5.36 5.37 -0.2% 1.787 1.917
2500.2 2.266 2.266 0.000 ( +0.0% ) 6.18 6.12 +1.0% 1.728 1.817
2500.21 1.147 1.147 0.000 ( +0.0% ) 4.39 4.42 -0.6% 2.003 2.105
2500.211 1.505 1.505 0.000 ( +0.0% ) 3.91 3.88 +0.6% 2.096 2.146
2500.3 2.024 2.023 0.001 ( +0.0% ) 13.04 13.12 -0.6% 1.661 1.890
2500.31 1.223 1.223 0.000 ( +0.0% ) 20.61 20.51 +0.5% 2.045 2.181
2500.311 1.606 1.606 0.000 ( +0.0% ) 14.34 14.21 +0.9% 2.123 2.225
2500.4 2.024 2.023 0.001 ( +0.0% ) 13.04 13.02 +0.2% 1.665 1.888
2500.5 19.544 19.544 0.000 ( +0.0% ) 1.41 1.49 -5.0% 1.308 1.307

@vlimant
Copy link
Contributor

vlimant commented Oct 25, 2023

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@antoniovilela
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 3c7ac38 into cms-sw:master Oct 27, 2023
@nurfikri89 nurfikri89 deleted the from133X_202310181100_nano_Addpthatmax branch October 27, 2023 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants