Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Phase2HLT][13_1_X] Change hltAK4PFPuppiJets correctors tags #42886

Merged

Conversation

theochatzis
Copy link
Contributor

PR description:

This is a backport of #42885

PR validation:

Running the standard Phase2 workflow produces no error
runTheMatrix.py -l 23634.0

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @theochatzis (Theo Chatzistavrou) for CMSSW_13_1_X.

It involves the following packages:

  • HLTrigger/Configuration (hlt)

@cmsbuild, @mmusich, @Martin-Grunewald, @missirol can you please review it and eventually sign? Thanks.
@SohamBhattacharya, @silviodonato, @Martin-Grunewald, @missirol, @rovere this is something you requested to watch as well.
@antoniovilela, @sextonkennedy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@rovere
Copy link
Contributor

rovere commented Sep 27, 2023

@theochatzis before triggering the test: are the changes in this PR enough to consume the new payload for the JEC?
I see that the payload has been added to v7 of 131X_mcRun4_realistic_v* GT.

@mmusich
Copy link
Contributor

mmusich commented Sep 27, 2023

before triggering the test: are the changes in this PR enough to consume the new payload for the JEC?
I see that the payload has been added to v7 of 131X_mcRun4_realistic_v* GT.

in this cycle the phase2_realistic autoCond key doesn't seem to have that yet.

'phase2_realistic' : '131X_mcRun4_realistic_v6'

@cms-sw/alca-l2 ping.

@mmusich
Copy link
Contributor

mmusich commented Sep 27, 2023

actually @theochatzis we don't need a new PR from alca, just update the line I pointed above #42886 (comment) to point to GT v7.

@cmsbuild
Copy link
Contributor

Pull request #42886 was updated. @cmsbuild, @perrotta, @consuegs, @saumyaphor4252, @mmusich, @Martin-Grunewald, @missirol can you please check and sign again.

@theochatzis
Copy link
Contributor Author

theochatzis commented Sep 27, 2023

Thanks @rovere and @mmusich for the comments. I did this change. For the 13_3 PR (#42885) I guess first we need a GT with this tag.

@mmusich
Copy link
Contributor

mmusich commented Sep 27, 2023

@cmsbuild, please test

@mmusich
Copy link
Contributor

mmusich commented Sep 27, 2023

I guess first we need a GT with this tag.

correct.

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e3ba8d/34935/summary.html
COMMIT: 5eda77c
CMSSW: CMSSW_13_1_X_2023-09-27-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/42886/34935/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 3 lines from the logs
  • Reco comparison results: 11 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3187455
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3187430
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: found differences in 3 / 46 workflows

@mmusich
Copy link
Contributor

mmusich commented Sep 29, 2023

+hlt

@saumyaphor4252
Copy link
Contributor

+alca

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@antoniovilela
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit b7a7171 into cms-sw:CMSSW_13_1_X Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants