Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Phase2HLT] Change hltAK4PFPuppiJets correctors tags #42885

Merged
merged 2 commits into from
Oct 2, 2023

Conversation

theochatzis
Copy link
Contributor

PR description:

The PR updates the labels used for AK4PFPuppi jets in HLT Phase2 menu. This is to use the latest updated corrections used for HLT jets/MET studies, uploaded recently in the GT

PR validation:

Running the standard Phase2 workflow produces no error
runTheMatrix.py -l 24834.0

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42885/37023

  • This PR adds an extra 36KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @theochatzis (Theo Chatzistavrou) for master.

It involves the following packages:

  • HLTrigger/Configuration (hlt)

@missirol, @cmsbuild, @mmusich, @Martin-Grunewald can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @rovere, @SohamBhattacharya, @missirol, @silviodonato this is something you requested to watch as well.
@rappoccio, @sextonkennedy, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor

mmusich commented Sep 27, 2023

@cmsbuild, please test

@mmusich
Copy link
Contributor

mmusich commented Sep 27, 2023

@cmsbuild please abort

@mmusich
Copy link
Contributor

mmusich commented Sep 27, 2023

@theochatzis @cms-sw/alca-l2 I don't see the phase-2 version of the AK4PFPuppiHLT in the current phase2_realistic GlobalTag:

'phase2_realistic' : '132X_mcRun4_realistic_v1'

conddb list 132X_mcRun4_realistic_v1 | grep AK4PFPuppiHLT
[2023-09-27 14:33:01,837] INFO: Connecting to pro [frontier://PromptProd/cms_conditions]
JetCorrectionsRecord                                    AK4PFPuppiHLT                                                      JetCorrectorParametersCollection_Run3Summer21_MC_AK4PFPuppiHLT

please provide a new Global Tag.

@mmusich
Copy link
Contributor

mmusich commented Sep 27, 2023

assign alca

@cmsbuild
Copy link
Contributor

New categories assigned: alca

@saumyaphor4252,@perrotta,@consuegs you have been requested to review this Pull request/Issue and eventually sign? Thanks

@saumyaphor4252
Copy link
Contributor

@theochatzis Here's the GT 132X_mcRun4_realistic_v2

@theochatzis
Copy link
Contributor Author

Great, thanks a lot Saumya! :) Ok added this tag in autoCond.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42885/37034

  • This PR adds an extra 32KB to repository

@saumyaphor4252
Copy link
Contributor

@cmsbuild, please test

@mmusich
Copy link
Contributor

mmusich commented Sep 28, 2023

@cmsbuild ping?

@mmusich
Copy link
Contributor

mmusich commented Sep 28, 2023

@smuzaffar the bot looks stuck here, can you please have a look? thank you.

@perrotta
Copy link
Contributor

code-checks

@smuzaffar
Copy link
Contributor

I am looking in to it

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42885/37035

  • This PR adds an extra 16KB to repository

@mmusich
Copy link
Contributor

mmusich commented Sep 28, 2023

despite this

+code-checks

It still says

Screenshot from 2023-09-28 11-25-38

@cmsbuild
Copy link
Contributor

Pull request #42885 was updated. @perrotta, @consuegs, @Martin-Grunewald, @missirol, @saumyaphor4252, @mmusich can you please check and sign again.

@mmusich
Copy link
Contributor

mmusich commented Sep 28, 2023

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3b6fa3/34955/summary.html
COMMIT: 8aa8cea
CMSSW: CMSSW_13_3_X_2023-09-28-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/42885/34955/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 1 lines from the logs
  • Reco comparison results: 10 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3358320
  • DQMHistoTests: Total failures: 34
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3358264
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 214 log files, 167 edm output root files, 50 DQM output files
  • TriggerResults: found differences in 3 / 48 workflows

@mmusich
Copy link
Contributor

mmusich commented Sep 29, 2023

+hlt

@saumyaphor4252
Copy link
Contributor

+alca

  • differences in 24834.0, 24834.911, 24896.0, 24900.0, 25034.999 expected from the GT change
  • Other diffs only in MsgLogger

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants