-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bug in defining bin edges of TH2F plots in ECAL DQM #42857
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42857/36995
|
A new Pull Request was created by @abhih1 (Abhirami Harilal) for master. It involves the following packages:
@nothingface0, @emanueleusai, @cmsbuild, @pmandrik, @syuvivida, @tjavaid, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
type ecal |
backport of #42858 |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6e34ae/34914/summary.html Comparison SummarySummary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
Hi everyone, sorry. The PR is mislabeled as b.port of 42858. Could you please help to remove it? |
PR description:
This PR fixes a bug that crept in PR #42188 in here [1] which was giving nonphysical values to the bin edges of certain TH2F plots [2] [3] in the Ecal DQM, due to which they were not being filled correctly ever since central DQM switched to CMSSW_13_2_2 from CMSSW_13_0_10.
[1] https://github.com/cms-sw/cmssw/pull/42188/files#diff-93b875a059a27e639d23a1e774ccb058f70fabea027504f8dbb22157c6080632L175-R176
[2] https://tinyurl.com/4nrwk9m7
[3] https://tinyurl.com/jkrvbw37
PR validation:
PR is validated by running the ECAL online DQM configuration and verifying the plots are correct on a test DQM GUI.
Also tested with Ecal runTheMatrix workflow 136.874.
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
This is the master PR. A backport to 13_2_X, currently used in production is here: #42858