Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in defining bin edges of TH2F plots in ECAL DQM #42857

Merged
merged 1 commit into from
Sep 26, 2023

Conversation

abhih1
Copy link
Contributor

@abhih1 abhih1 commented Sep 25, 2023

PR description:

This PR fixes a bug that crept in PR #42188 in here [1] which was giving nonphysical values to the bin edges of certain TH2F plots [2] [3] in the Ecal DQM, due to which they were not being filled correctly ever since central DQM switched to CMSSW_13_2_2 from CMSSW_13_0_10.

[1] https://github.com/cms-sw/cmssw/pull/42188/files#diff-93b875a059a27e639d23a1e774ccb058f70fabea027504f8dbb22157c6080632L175-R176
[2] https://tinyurl.com/4nrwk9m7
[3] https://tinyurl.com/jkrvbw37

PR validation:

PR is validated by running the ECAL online DQM configuration and verifying the plots are correct on a test DQM GUI.
Also tested with Ecal runTheMatrix workflow 136.874.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

This is the master PR. A backport to 13_2_X, currently used in production is here: #42858

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42857/36995

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 25, 2023

A new Pull Request was created by @abhih1 (Abhirami Harilal) for master.

It involves the following packages:

  • DQM/EcalCommon (dqm)

@nothingface0, @emanueleusai, @cmsbuild, @pmandrik, @syuvivida, @tjavaid, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks.
@rchatter, @argiro, @thomreis, @wang0jin this is something you requested to watch as well.
@rappoccio, @antoniovilela, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@tjavaid
Copy link

tjavaid commented Sep 26, 2023

please test

@tjavaid
Copy link

tjavaid commented Sep 26, 2023

type ecal

@cmsbuild cmsbuild added the ecal label Sep 26, 2023
@tjavaid
Copy link

tjavaid commented Sep 26, 2023

backport of #42858

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6e34ae/34914/summary.html
COMMIT: 9caadab
CMSSW: CMSSW_13_3_X_2023-09-26-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/42857/34914/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 5 lines to the logs
  • Reco comparison results: 5 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3358044
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 1797
  • DQMHistoTests: Total successes: 3356219
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 214 log files, 167 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@tjavaid
Copy link

tjavaid commented Sep 26, 2023

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

+1

@tjavaid
Copy link

tjavaid commented Sep 28, 2023

Hi everyone, sorry. The PR is mislabeled as b.port of 42858. Could you please help to remove it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants