Fix compilation warnings in MESet* #42188

iarspider · 2023-07-05T08:14:47Z

PR description:

Fix warnings reported here, e.g.:

/data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/de71853a65d857b5c29aa52c2674d8d1/opt/cmssw/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_13_2_X_2023-07-04-1100/src/DQM/EcalCommon/src/MESetBinningUtils.cc: In function 'formAxis':
  /data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/de71853a65d857b5c29aa52c2674d8d1/opt/cmssw/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_13_2_X_2023-07-04-1100/src/DQM/EcalCommon/src/MESetBinningUtils.cc:855:51: warning: argument 1 value '18446744073709551615' exceeds maximum object size 9223372036854775807 [-Walloc-size-larger-than=]
   855 |           axis.labels = new std::string[axis.nbins];
      |                                                   ^
/data/cmsbld/jenkins/workspace/build-any-ib/w/el8_amd64_gcc12/external/gcc/12.3.1-40d504be6370b5a30e3947a6e575ca28/include/c++/12.3.1/new:128:26: note: in a call to allocation function 'operator new []' declared here
  128 | _GLIBCXX_NODISCARD void* operator new[](std::size_t) _GLIBCXX_THROW (std::bad_alloc)
      |                          ^

PR validation:

Code compiles without warnings

cmsbuild · 2023-07-05T08:22:49Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42188/36190

This PR adds an extra 32KB to repository

cmsbuild · 2023-07-05T08:23:11Z

A new Pull Request was created by @iarspider for master.

It involves the following packages:

DQM/EcalCommon (dqm)

@nothingface0, @emanueleusai, @cmsbuild, @pmandrik, @syuvivida, @tjavaid, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks.
@rchatter, @argiro, @thomreis, @wang0jin this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

iarspider · 2023-07-05T08:39:46Z

please test

cmsbuild · 2023-07-05T13:39:05Z

-1

Failed Tests: RelVals RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7e59cf/33556/summary.html
COMMIT: 4e2a00c
CMSSW: CMSSW_13_2_X_2023-07-04-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/42188/33556/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

The relvals timed out after 4 hours.

4.224.22_RunCosmics2011A/step2_RunCosmics2011A.log
138.5138.5_ExpressCollisions2021/step2_ExpressCollisions2021.log
8.08.0_BeamHalo/step3_BeamHalo.log

Expand to see more relval errors ...

RelVals-INPUT

The relvals timed out after 4 hours.

134.813134.813_RunCosmics2015C/step2_RunCosmics2015C.log
136.733136.733_RunCosmics2016B/step2_RunCosmics2016B.log
136.897136.897_RunCosmics2021CRUZET/step2_RunCosmics2021CRUZET.log

Expand to see more relval errors ...

cmsbuild · 2023-07-05T18:29:21Z

-1

Failed Tests: RelVals RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7e59cf/33556/summary.html
COMMIT: 4e2a00c
CMSSW: CMSSW_13_2_X_2023-07-04-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/42188/33556/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

The relvals timed out after 4 hours.

138.5138.5_ExpressCollisions2021/step2_ExpressCollisions2021.log
8.08.0_BeamHalo/step3_BeamHalo.log
4.534.53_RunPhoton2012B/step3_RunPhoton2012B.log

Expand to see more relval errors ...

RelVals-INPUT

The relvals timed out after 4 hours.

4.64.6_MinimumBias2010A/step2_MinimumBias2010A.log
136.897136.897_RunCosmics2021CRUZET/step2_RunCosmics2021CRUZET.log
138.5138.5_ExpressCollisions2021/step2_ExpressCollisions2021.log

Expand to see more relval errors ...

cmsbuild · 2023-07-07T07:24:22Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42188/36221

This PR adds an extra 28KB to repository

cmsbuild · 2023-07-07T11:58:01Z

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7e59cf/33589/summary.html
COMMIT: eca8467
CMSSW: CMSSW_13_2_X_2023-07-06-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/42188/33589/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

The relvals timed out after 4 hours.

Comparison Summary

Summary:

You potentially removed 1 lines from the logs
Reco comparison results: 8 differences found in the comparisons
DQMHistoTests: Total files compared: 48
DQMHistoTests: Total histograms compared: 3193892
DQMHistoTests: Total failures: 12
DQMHistoTests: Total nulls: 1743
DQMHistoTests: Total successes: 3192115
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
Checked 207 log files, 159 edm output root files, 48 DQM output files
TriggerResults: no differences found

iarspider · 2023-07-07T12:20:01Z

please test

cmsbuild · 2023-07-07T17:26:06Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7e59cf/33592/summary.html
COMMIT: eca8467
CMSSW: CMSSW_13_2_X_2023-07-07-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/42188/33592/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

There are some workflows for which there are errors in the baseline:
136.897 step 2
140.025 step 2
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Summary:

You potentially added 11 lines to the logs
Reco comparison results: 7 differences found in the comparisons
DQMHistoTests: Total files compared: 48
DQMHistoTests: Total histograms compared: 3193892
DQMHistoTests: Total failures: 6
DQMHistoTests: Total nulls: 1743
DQMHistoTests: Total successes: 3192121
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
Checked 207 log files, 159 edm output root files, 48 DQM output files
TriggerResults: no differences found

emanueleusai · 2023-07-11T06:02:16Z

+1

cmsbuild · 2023-07-11T06:02:40Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

perrotta · 2023-07-11T07:09:03Z

+1

cmsbuild · 2023-07-11T12:45:34Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7e59cf/33633/summary.html
COMMIT: eca8467
CMSSW: CMSSW_13_2_X_2023-07-10-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/42188/33633/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially removed 15 lines from the logs
Reco comparison results: 9 differences found in the comparisons
DQMHistoTests: Total files compared: 48
DQMHistoTests: Total histograms compared: 3193892
DQMHistoTests: Total failures: 6
DQMHistoTests: Total nulls: 1743
DQMHistoTests: Total successes: 3192121
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
Checked 207 log files, 159 edm output root files, 48 DQM output files
TriggerResults: no differences found

Fix compilation warnings in MESetBinningUtils

4e2a00c

cmsbuild added this to the CMSSW_13_2_X milestone Jul 5, 2023

cmsbuild added dqm-pending pending-signatures tests-pending orp-pending code-checks-pending labels Jul 5, 2023

cmsbuild added code-checks-approved and removed code-checks-pending labels Jul 5, 2023

cmsbuild added tests-started and removed tests-pending labels Jul 5, 2023

cmsbuild added tests-rejected tests-started and removed tests-started tests-rejected labels Jul 5, 2023

cmsbuild added tests-rejected and removed tests-started labels Jul 5, 2023

Restore constructor

eca8467

cmsbuild added tests-pending code-checks-pending and removed tests-rejected code-checks-approved labels Jul 7, 2023

cmsbuild added code-checks-approved and removed code-checks-pending labels Jul 7, 2023

cmsbuild added the tests-started label Jul 7, 2023

cmsbuild added tests-rejected and removed tests-started labels Jul 7, 2023

cmsbuild added tests-started and removed tests-rejected labels Jul 7, 2023

cmsbuild added tests-approved and removed tests-started labels Jul 7, 2023

cmsbuild added dqm-approved fully-signed and removed dqm-pending pending-signatures labels Jul 11, 2023

cmsbuild added orp-approved and removed orp-pending labels Jul 11, 2023

cmsbuild merged commit 7d21739 into cms-sw:master Jul 11, 2023

cmsbuild mentioned this pull request Jul 11, 2023

Update TF to 2.12 (backport from IB/CMSSW_13_2_X/g13 branch) cms-sw/cmsdist#8565

Merged

cmsbuild added tests-started and removed tests-approved labels Jul 11, 2023

cmsbuild added tests-approved and removed tests-started labels Jul 11, 2023

cmsbuild mentioned this pull request Jul 11, 2023

[ASAN] Fix runtime error by moving std::regex code in anonymous namespace #42077

Merged

This was referenced Sep 26, 2023

Fix bug in defining bin edges of TH2F plots in ECAL DQM [13_2_X] #42858

Merged

Fix bug in defining bin edges of TH2F plots in ECAL DQM #42857

Merged

iarspider deleted the fix-dqm-ecalcommon branch February 27, 2024 10:16

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix compilation warnings in MESet* #42188

Fix compilation warnings in MESet* #42188

iarspider commented Jul 5, 2023

cmsbuild commented Jul 5, 2023

cmsbuild commented Jul 5, 2023

iarspider commented Jul 5, 2023

cmsbuild commented Jul 5, 2023

cmsbuild commented Jul 5, 2023

cmsbuild commented Jul 7, 2023

cmsbuild commented Jul 7, 2023

iarspider commented Jul 7, 2023

cmsbuild commented Jul 7, 2023

emanueleusai commented Jul 11, 2023

cmsbuild commented Jul 11, 2023

perrotta commented Jul 11, 2023

cmsbuild commented Jul 11, 2023

Fix compilation warnings in MESet* #42188

Fix compilation warnings in MESet* #42188

Conversation

iarspider commented Jul 5, 2023

PR description:

PR validation:

cmsbuild commented Jul 5, 2023

cmsbuild commented Jul 5, 2023

iarspider commented Jul 5, 2023

cmsbuild commented Jul 5, 2023

RelVals

RelVals-INPUT

cmsbuild commented Jul 5, 2023

RelVals

RelVals-INPUT

cmsbuild commented Jul 7, 2023

cmsbuild commented Jul 7, 2023

RelVals-INPUT

Comparison Summary

iarspider commented Jul 7, 2023

cmsbuild commented Jul 7, 2023

Comparison Summary

emanueleusai commented Jul 11, 2023

cmsbuild commented Jul 11, 2023

perrotta commented Jul 11, 2023

cmsbuild commented Jul 11, 2023

Comparison Summary