update HLT selection for HI mode in sistrip and l1tstage2 online-DQM clients [13_2_X]

[missirol]

backport of #42803

PR description:

From the description of #42803:

This PR applies simple fixes to the HLT selections used in the sistrip and l1tstage2 online-DQM clients, based on the latest version of the HLT menu for the 2023 HIon run (see here).

• sistrip: triggers named HLT_HICentralityVeto* in the HIon menu have been replaced by triggers named HLT_HIMinimumBias*, so this client is updated accordingly.
• l1tstage2: the HLT selection for HI mode is fixed by adding HLT_HIPhysics_v* (needed for DQM involving the inputs of all the different uGT boards sent only in "L1T fat events"); this follows what is already being done in the l1tstage2emulator client.

Minimal code-style updates are also included.

PR validation:

None.

If this PR is a backport, please specify the original PR and why you need to backport that PR. If this PR will be backported, please specify to which release cycle the backport is meant for:

#42803

Update of 2 online-DQM clients for the 2023 HIon run.

[cmsbuild]

A new Pull Request was created by @missirol (Marino Missiroli) for CMSSW_13_2_X.

It involves the following packages:

• DQM/Integration (dqm)

@nothingface0, @emanueleusai, @cmsbuild, @pmandrik, @syuvivida, @tjavaid, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks.
@threus, @batinkov, @francescobrivio this is something you requested to watch as well.
@rappoccio, @antoniovilela, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

• Backported from update HLT selection for HI mode in sistrip and l1tstage2 online-DQM clients #42803

[cmsbuild]

Pull request #42804 was updated. @nothingface0, @emanueleusai, @cmsbuild, @pmandrik, @syuvivida, @tjavaid, @micsucmed, @rvenditti can you please check and sign again.

[emanueleusai]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8060e7/34811/summary.html
COMMIT: 21ed636
CMSSW: CMSSW_13_2_X_2023-09-18-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/42804/34811/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 3 lines from the logs
• Reco comparison results: 6 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3198243
• DQMHistoTests: Total failures: 3
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3198218
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 207 log files, 159 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[syuvivida]

We tested this PR using our p5 playback machines with the Heavy Ion HLT streamers from Marino (run 362321, LS=231) [0] [1]. The results are fine. In addition, we also start seeing tracks in this histograms of siStrip client.

[0] /afs/cern.ch/work/m/missirol/public/fog/CMSHLT-2884/Test05/run362321/
[1] After updating [0] to DQM format, /eos/cms/store/group/phys_heavyions/prverma/HIDQM/streamers_CMSSW_13_2_3/

[emanueleusai]

+1

• test at p5 ok

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

[missirol]

What's the status of this PR ?

[rappoccio]

+1