-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update HLT selection for HI mode in sistrip
and l1tstage2
online-DQM clients
#42803
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just highlighting the only 2 significant changes in this PR.
DQM/Integration/python/clients/sistrip_dqm_sourceclient-live_cfg.py
Outdated
Show resolved
Hide resolved
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42803/36916
|
A new Pull Request was created by @missirol (Marino Missiroli) for master. It involves the following packages:
@nothingface0, @emanueleusai, @cmsbuild, @pmandrik, @syuvivida, @tjavaid, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
DQM/Integration/python/clients/sistrip_dqm_sourceclient-live_cfg.py
Outdated
Show resolved
Hide resolved
DQM/Integration/python/clients/sistrip_dqm_sourceclient-live_cfg.py
Outdated
Show resolved
Hide resolved
6cc4e82
to
170b35b
Compare
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42803/36925
|
Pull request #42803 was updated. @nothingface0, @emanueleusai, @cmsbuild, @pmandrik, @syuvivida, @tjavaid, @micsucmed, @rvenditti can you please check and sign again. |
@cmsbuild, please test
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-45caa6/34809/summary.html Comparison SummarySummary:
|
+1
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
This PR applies simple fixes to the HLT selections used in the
sistrip
andl1tstage2
online-DQM clients, based on the latest version of the HLT menu for the 2023 HIon run (see here).sistrip
: triggers namedHLT_HICentralityVeto*
in the HIon menu have been replaced by triggers namedHLT_HIMinimumBias*
, so this client is updated accordingly.l1tstage2
: the HLT selection for HI mode is fixed by addingHLT_HIPhysics_v*
(needed for DQM involving the inputs of all the different uGT boards sent only in "L1T fat events"); this follows what is already being done in thel1tstage2emulator
client.Minimal code-style updates are also included.
PR validation:
None.
If this PR is a backport, please specify the original PR and why you need to backport that PR. If this PR will be backported, please specify to which release cycle the backport is meant for:
CMSSW_13_2_X