Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HLT menu development for 13_2_X (3/N) [13_3_X] #42795

Merged
merged 5 commits into from
Sep 15, 2023

Conversation

missirol
Copy link
Contributor

PR description:

Development of HLT menus for CMSSW_13_2_X.

This is the PR for the master branch, which will then be backported down to 13_2_X (the latter is the release cycle currently used for Run-3 HLT-menu development).

This version of the HIon HLT menu corresponds to the "V1.0" menu for the 2023 heavy-ion data-taking period (the corresponding frozen menu is not added to the release, as not needed by any central wf).

In addition, the following changes are included.

  • fb41033 fixes HLT customisations used to run on 2018 data (introducing SCAL digis for beamspot, adjusting parameters used in the pixel local reconstruction). These customisations became relevant again when trying to use 2018 HIon data to estimate rates and timings of the 2023 HIon menu. After the 2023 data-taking, these customisations could likely be removed.
  • d56c46e updates the HLT-Validation and HLT-addon tests involving the HIon menu to use the Run3_pp_on_PbPb_2023 era
  • ccf3452 and f4f9b87 update the GTs used in TSG tests to use the latest 2023 L1T menus for "pp-ref" (L1Menu_CollisionsPPRef2023_v1_1_1_xml) and HIon (L1Menu_CollisionsHeavyIons2023_v1_1_1_xml).

This update includes the integration of the following JIRA tickets.

  • CMSHLT-2882: [HIN] core of 2023 HIon menu
  • CMSHLT-2885: [HIN,AlCa] AlCa requests for 2023 HIon menu
  • CMSHLT-2904: [HIN] split PPRefDoubleMuon, PPRefSingleMuon and PPRefHardProbes PDs and streams
  • CMSHLT-2905: [HIN] add D-meson triggers for 2023 HIon menu
  • CMSHLT-2906: [HIN] add Mu+EG/Jet cross triggers for 2023 HIon menu
  • CMSHLT-2907: [HIN] add CommissioningRawPrime PD to PRef menu
  • CMSHLT-2913: [HIN] split HIForward, HIMinimumBias and HIPhysicsRawPrime PDs and streams of HIon menu
  • CMSHLT-2914: [HIN] minimum-bias triggers of 2023 HIon menu
  • CMSHLT-2915: [TSG] add HIEphemeral* PDs to HIon menu

PR validation:

TSG tests.

If this PR is a backport, please specify the original PR and why you need to backport that PR. If this PR will be backported, please specify to which release cycle the backport is meant for:

CMSSW_13_2_X

Development of HLT menus for `CMSSW_13_2_X`.

This version of the HIon HLT menu corresponds to the "V1.0" menu for the 2023 heavy-ion data-taking period (the corresponding frozen menu is not added to the release, as not needed by any central wf).

This update includes the integration of the following JIRA tickets.

 - [CMSHLT-2882](https://its.cern.ch/jira/browse/CMSHLT-2882): [HIN] core of 2023 HIon menu
 - [CMSHLT-2885](https://its.cern.ch/jira/browse/CMSHLT-2885): [HIN,AlCa] AlCa requests for 2023 HIon menu
 - [CMSHLT-2904](https://its.cern.ch/jira/browse/CMSHLT-2904): [HIN] split `PPRefDoubleMuon`, `PPRefSingleMuon` and `PPRefHardProbes` PDs and streams
 - [CMSHLT-2905](https://its.cern.ch/jira/browse/CMSHLT-2905): [HIN] add D-meson triggers for 2023 HIon menu
 - [CMSHLT-2906](https://its.cern.ch/jira/browse/CMSHLT-2906): [HIN] add Mu+EG/Jet cross triggers for 2023 HIon menu
 - [CMSHLT-2907](https://its.cern.ch/jira/browse/CMSHLT-2907): [HIN] add `CommissioningRawPrime` PD to PRef menu
 - [CMSHLT-2913](https://its.cern.ch/jira/browse/CMSHLT-2913): [HIN] split `HIForward`, `HIMinimumBias` and `HIPhysicsRawPrime` PDs and streams of HIon menu
 - [CMSHLT-2914](https://its.cern.ch/jira/browse/CMSHLT-2914): [HIN] minimum-bias triggers of 2023 HIon menu
 - [CMSHLT-2915](https://its.cern.ch/jira/browse/CMSHLT-2915): [TSG] add `HIEphemeral*` PDs to HIon menu
@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42795/36908

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @missirol (Marino Missiroli) for master.

It involves the following packages:

  • Configuration/HLT (hlt)
  • HLTrigger/Configuration (hlt)

@cmsbuild, @missirol, @mmusich, @Martin-Grunewald can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @silviodonato, @fabiocos this is something you requested to watch as well.
@rappoccio, @antoniovilela, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@missirol
Copy link
Contributor Author

enable gpu

@missirol
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2fd4df/34770/summary.html
COMMIT: 6a3613d
CMSSW: CMSSW_13_3_X_2023-09-14-1100/el8_amd64_gcc11
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/42795/34770/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 2 lines from the logs
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3340821
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3340796
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.348 KiB( 49 files compared)
  • DQMHistoSizes: changed ( 12434.0,... ): 0.087 KiB HLT/Filters
  • Checked 214 log files, 167 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

GPU Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 11 differences found in the comparisons
  • DQMHistoTests: Total files compared: 3
  • DQMHistoTests: Total histograms compared: 40118
  • DQMHistoTests: Total failures: 465
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 39653
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 2 files compared)
  • Checked 8 log files, 10 edm output root files, 3 DQM output files
  • TriggerResults: no differences found

@missirol
Copy link
Contributor Author

missirol commented Sep 15, 2023

+hlt

  • Outputs of PR tests are in line with the update of the HLT menus (GRun and "fake" menus). Differences in DQM plots are only technical (e.g. names of menus and Paths, because of change in Path-version numbers of GRun), as there are no physics changes to those menus (the HIon menu has several physics changes, and the only PR tests for that menu are in the addOnTests).

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@missirol
Copy link
Contributor Author

@cms-sw/orp-l2 , kind ping to review this PR.

@antoniovilela
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 0ff908c into cms-sw:master Sep 15, 2023
@missirol missirol deleted the HLTdevelopment132X_for133X branch September 15, 2023 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants