Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Phase2 HLT to ticl_v4 [13_1_X] #42760

Merged
merged 4 commits into from
Sep 18, 2023

Conversation

rovere
Copy link
Contributor

@rovere rovere commented Sep 12, 2023

PR description:

Backport of #42759

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 12, 2023

A new Pull Request was created by @rovere (Marco Rovere) for CMSSW_13_1_X.

It involves the following packages:

  • HLTrigger/Configuration (hlt)
  • RecoHGCal/TICL (upgrade, reconstruction)

@Martin-Grunewald, @missirol, @cmsbuild, @AdrianoDee, @srimanob, @jfernan2, @mmusich, @mandrenguyen can you please review it and eventually sign? Thanks.
@youyingli, @missirol, @silviodonato, @felicepantaleo, @forthommel, @SohamBhattacharya, @Martin-Grunewald, @apsallid, @sobhatta, @lecriste, @hatakeyamak, @ebrondol, @sameasy this is something you requested to watch as well.
@rappoccio, @antoniovilela, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@jfernan2
Copy link
Contributor

backport of #42759

@jfernan2
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0f6941/34712/summary.html
COMMIT: 9db8da8
CMSSW: CMSSW_13_1_X_2023-09-12-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/42760/34712/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 16 lines to the logs
  • Reco comparison results: 221 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3187380
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3187352
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: found differences in 3 / 46 workflows

@mmusich
Copy link
Contributor

mmusich commented Sep 15, 2023

+hlt

@srimanob
Copy link
Contributor

+Upgrade

@jfernan2
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@antoniovilela
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 43402fc into cms-sw:CMSSW_13_1_X Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants