Move Phase2 HLT to ticl_v4

[rovere]

PR description:

The current Phase2 HLT Menu is a mixture of TICL_v3 and TICL_v4.
This PR will move the whole menu to using TICL_v4. In order to do that, a new option has been added to TICL_v4, during the tracksters' merge step, to disable the usage of MTD information that, at present, is not part of the HLT reconstruction.
As an added enhancement, a slimmed and fully L1T-seeded Phase2 HLT menu has been added to the release, named 75e33_timing, to be used to perform meaningful timing measurements.

For further information, please refer to today's HLT Upgrade meeting and presentation therein.

The old TICL_v3 iterations have been removed from the repository, since GitHub will automatically keep their history.

A backport to 13_1_X, the baseline release for the coming HLT Upgrade Annual Review, will be submitted soon.

PR validation:

Run any Phase2 workflow with HLT menu w/o crashes.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42759/36861

• This PR adds an extra 56KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File RecoHGCal/TICL/plugins/LinkingAlgoByDirectionGeometric.cc modified in PR(s): Improve MC truth information in TICL, Sim-Reco Associators, TICLDumper #42518
  • File RecoHGCal/TICL/plugins/LinkingAlgoByDirectionGeometric.h modified in PR(s): Improve MC truth information in TICL, Sim-Reco Associators, TICLDumper #42518
  • File RecoHGCal/TICL/plugins/TrackstersMergeProducer.cc modified in PR(s): Improve MC truth information in TICL, Sim-Reco Associators, TICLDumper #42518

[cmsbuild]

A new Pull Request was created by @rovere (Marco Rovere) for master.

It involves the following packages:

• HLTrigger/Configuration (hlt)
• RecoHGCal/TICL (upgrade, reconstruction)

@Martin-Grunewald, @missirol, @cmsbuild, @AdrianoDee, @srimanob, @jfernan2, @mmusich, @mandrenguyen can you please review it and eventually sign? Thanks.
@youyingli, @missirol, @silviodonato, @felicepantaleo, @forthommel, @SohamBhattacharya, @Martin-Grunewald, @apsallid, @sobhatta, @lecriste, @hatakeyamak, @ebrondol, @sameasy this is something you requested to watch as well.
@rappoccio, @antoniovilela, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[jfernan2]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-49c52c/34710/summary.html
COMMIT: eaf8d14
CMSSW: CMSSW_13_3_X_2023-09-12-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/42759/34710/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 4 lines from the logs
• Reco comparison results: 533 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3348561
• DQMHistoTests: Total failures: 143
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3348396
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
• Checked 214 log files, 167 edm output root files, 50 DQM output files
• TriggerResults: found differences in 2 / 48 workflows

[srimanob]

+Upgrade

Code related to upgrade is fine. Changes can be seen in HLT of Phase-2 workflows which are expected. For Run-3, change in MessageLogger and mkfit workflow do not related to this PR.

[mmusich]

any reason to keep this comment?

[mmusich]

for my own education what's the purpose of this file?

[rovere]

Ciao @mmusich that's the version of the simplified HLT Menu to be used when performing timing measurements.

[mmusich]

I am confused about the usage of this producer. It doesn't seem to be referenced in the menu.
What's the purpose of this configuration fragment?

[rovere]

Ciao @mmusich you are right and that will be cleaned/removed in the (near) future.

[mmusich]

+hlt

• TriggerResults: found differences in 2 / 48 workflows, seems to be expected given the premises Move Phase2 HLT to ticl_v4  #42759 (comment)
• there is a couple of minor points that can be clarified Move Phase2 HLT to ticl_v4  #42759 (comment) and Move Phase2 HLT to ticl_v4  #42759 (comment)
• given that the PR is coming directly from one of the HLT Upgrade convener, I am implicitly assuming @rovere's blessing

[jfernan2]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

[antoniovilela]

+1