Fix compilation warning in SensitiveDetectorCatalog.cc

[iarspider]

PR description:

Remove redefinition of EDM_ML_DEBUG. @bsunanda feel free to reject these changes if that debug flag is needed for non-debug IBs.

[iarspider]

please test for CMSSW_13_3_DBG_X

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42738/36828

• This PR adds an extra 16KB to repository

[cmsbuild]

A new Pull Request was created by @iarspider for master.

It involves the following packages:

• SimG4Core/Geometry (simulation)

@civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@makortel, @bsunanda, @rovere, @fabiocos, @slomeo this is something you requested to watch as well.
@rappoccio, @antoniovilela, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[smuzaffar]

please test

start product arch tests too

[cmsbuild]

-1

Failed Tests: RelVals
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e9975d/34660/summary.html
COMMIT: 92d3b30
CMSSW: CMSSW_13_3_DBG_X_2023-09-07-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/42738/34660/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

• 23234.0

----- Begin Fatal Exception 08-Sep-2023 14:32:07 CEST-----------------------
An exception of category 'Invalid DetId' occurred while
   [0] Calling method for module HGCalBackendLayer1Producer/'l1tHGCalBackEndLayer1Producer'
   [1] Prefetching for EventSetup module HGCalTriggerGeometryESProducer/'l1tHGCalTriggerGeometryESProducer'
   [2] Calling method for EventSetup module HGCalGeometryESProducer/'HFNoseGeometryESProducer'
Exception Message:
Cannot initialize HGCSiliconDetId from 6c8bd800
----- End Fatal Exception -------------------------------------------------

[iarspider]

Cannot initialize HGCSiliconDetId from 6c8bd800

Known issue, tracked in #41088

[makortel]

if that debug flag is needed for non-debug IBs.

If EDM_ML_DEBUG is needed in non-debug IBs, the code should the modified to not need it.

[civanch]

+1

this flag obviously is forgotten during heavy debugging of Phase-2 problem. It is not needed for the mainstream.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

[civanch]

Forget to say that usually such flags are commented out and uncommented for debugging. Because we are close to 13_3 cut, the removal is good indeed, next time the flag may be added.

[cmsbuild]

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e9975d/34664/summary.html
COMMIT: 92d3b30
CMSSW: CMSSW_13_3_X_2023-09-07-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/42738/34664/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

The relvals timed out after 4 hours.

Comparison Summary

Summary:

• You potentially added 8 lines to the logs
• Reco comparison results: 337 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3153414
• DQMHistoTests: Total failures: 125
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3153267
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 207 log files, 159 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[rappoccio]

please test

• refreshing tests, this looks like a glitch

[cmsbuild]

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e9975d/34701/summary.html
COMMIT: 92d3b30
CMSSW: CMSSW_13_3_X_2023-09-11-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/42738/34701/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

The relvals timed out after 4 hours.

Comparison Summary

Summary:

• You potentially added 17 lines to the logs
• Reco comparison results: 331 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3153414
• DQMHistoTests: Total failures: 119
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3153273
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 207 log files, 159 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[civanch]

We have timeout not related to this PR. I would propose to merge it.

[rappoccio]

+1

[rappoccio]

merge

• Test failures are unrelated to this PR.