-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes and modifications on GEM TnP efficiency plots (backport of #42639, 13_0_X) #42685
Conversation
A new Pull Request was created by @jo100sun (jo100) for CMSSW_13_0_X. It involves the following packages:
@nothingface0, @emanueleusai, @clacaputo, @mandrenguyen, @cmsbuild, @pmandrik, @syuvivida, @tjavaid, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
Pull request #42685 was updated. @nothingface0, @emanueleusai, @clacaputo, @mandrenguyen, @cmsbuild, @pmandrik, @syuvivida, @tjavaid, @micsucmed, @rvenditti can you please check and sign again. |
type muon, bug-fix |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e012f8/34576/summary.html Comparison SummarySummary:
|
+1 |
@cms-sw/dqm-l2 is this okay to sign for 13_0? |
+1
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_13_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
Hello @emanueleusai , can you tell me when this PR will be available to see at cmsweb? |
Hi @jo100sun as you know the HI data will be processed with 13_2_X. Do you need these plots to be fixed/displayed for HI runs? I see #42687 is merged but not yet included in 13_2_3 (current version run at Tier-0). If yes, we need to ask to build a new release to include this PR. |
Yes exactly. I saw my changes are included in 13_2_4. Will this change apply to DQM also? |
PR description:
Backport of (#42639)[https://github.com//pull/42639]. This PR introduces updates on GEM TnP efficiency plots and bugfix for the GEM edge distance calculation at TrackerMuon propagation. (#40554)[https://github.com//pull/40554]
PR validation:
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
This PR is backport of (#42639)[https://github.com//pull/42639]. We would like to introduce this changes for upcoming run.
@jshlee @watson-ij