Fixes and modifications on GEM TnP efficiency plots

[jo100sun]

PR description:

This PR introduces fixes and modifications to the GEM TnP efficiency plots.
The GEM TnP efficiency plots needed some fixes since they have inconsistent legends, overlapping stations and the wrong number of entries in some plots.

Changes:
Station Separation: GE11 and GE21 were overlapping on certain plots. These plots have been separated for each station for clarity.
Bugfix for Residual Plots: The residual plots are being filled even when there was no hit on the GEM to match the track to. This misrepresented the actual entry number. With this PR, filling occurs only when a hit is present.
Code Cleanup: Removed unnecessary parts of the code.
Legend Update: Legends have been updated for better clarity.

Bugfix on the trapezoid width calculation at the propagation of a Trackermuon.

PR validation:

Validation was performed using the command runTheMatrix.py -l 24450.0 -w upgrade. We verified that the plots after the PR reflect all the changes listed above.

@jshlee @watson-ij

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42639/36696

• This PR adds an extra 32KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42639/36696/code-format.patch
  e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42639/36696/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42639/36705

• This PR adds an extra 24KB to repository

[cmsbuild]

A new Pull Request was created by @jo100sun (jo100) for master.

It involves the following packages:

• DQMOffline/MuonDPG (dqm)
• TrackingTools/TrackAssociator (reconstruction)

@nothingface0, @emanueleusai, @clacaputo, @mandrenguyen, @cmsbuild, @pmandrik, @syuvivida, @tjavaid, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks.
@VourMa, @felicepantaleo, @abbiendi, @CeliaFernandez, @mmusich, @cericeci, @andrea21z, @JanFSchulte, @jhgoh, @missirol, @HuguesBrun, @ptcox, @trocino, @rociovilar, @barvic, @GiacomoSguazzoni, @rovere, @VinInn, @bellan, @ebrondol, @mtosi, @dgulhan, @Fedespring, @calderona, @gpetruc this is something you requested to watch as well.
@perrotta, @dpiparo, @antoniovilela, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[watson-ij]

please test

[cmsbuild]

-1

Failed Tests: Build ClangBuild
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14a12f/34458/summary.html
COMMIT: e38de0a
CMSSW: CMSSW_13_3_X_2023-08-23-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/42639/34458/install.sh to create a dev area with all the needed externals and cmssw changes.

Build

I found compilation warning when building: See details on the summary page.

Clang Build

I found compilation warning while trying to compile with clang. Command used:

USER_CUDA_FLAGS='--expt-relaxed-constexpr' USER_CXXFLAGS='-Wno-register -fsyntax-only' scram build -k -j 32 COMPILER='llvm compile'

See details on the summary page.

[jo100sun]

@mandrenguyen Yes, it has a bugfix for my previous PR #40554.
It was assuming y origin of localPosition of GEM chamber is at the bottom of a chamber, but in fact it is at the center of a chamber. It was resulting in smaller trapezoid width along x axis, excludes matches too close to edge.

With the fix in this PR, it calculates the correct edge distance which is slightly larger than previous version. As a result, it adds more GEM matches to Trackermuons.

[jo100sun]

@emanueleusai
We would like to include this in the offline dqm for the upcoming run. What are the backport versions we need to PR?

[emanueleusai]

@jo100sun we need 13_0, 13_1, and 13_2

[mandrenguyen]

+reconstruction
Changes in reco are due to a buxfix as explained in #42639 (comment)

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[rappoccio]

+1

[mandrenguyen]

type muon

[mandrenguyen]

type bug-fix