[NanoAOD] Fix typos in jetsAK4 CHS and Puppi tables #42670

hqucms · 2023-08-28T13:56:58Z

PR description:

This pull request fixes a few typos in the jetsAK4 CHS and Puppi tables:

(1) Fix to the btagRobustParTAK4CvB definition: the previous definition was using the pfDeepFlavourJetTags instead of pfParticleTransformerAK4JetTagsfor theprobbbandproblepb` scores in the denominator. This affects both the CHS and Puppi AK4 jet tables, and probably(?) affects the official production.

(2) Fix to the nanoAOD_addDeepInfoAK4() fucntion in the jetsAK4_Puppi_cff.py: this should only affects private/custom productions.

PR validation:

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Before submitting your pull requests, make sure you followed this checklist:

verify that the PR is really intended for the chosen branch
verify that changes follow CMS Naming, Coding, And Style Rules
verify that the PR passes the basic test procedure suggested in the CMSSW PR instructions

cmsbuild · 2023-08-28T14:05:32Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42670/36746

This PR adds an extra 20KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File PhysicsTools/NanoAOD/python/jetsAK4_Puppi_cff.py modified in PR(s): [NanoAOD, JMENano] Updates for Nano and JMENano #42651

cmsbuild · 2023-08-28T14:06:00Z

A new Pull Request was created by @hqucms (Huilin Qu) for master.

It involves the following packages:

PhysicsTools/NanoAOD (xpog)

@cmsbuild, @simonepigazzini, @vlimant can you please review it and eventually sign? Thanks.
@gpetruc, @AnnikaStein this is something you requested to watch as well.
@perrotta, @dpiparo, @antoniovilela, @rappoccio you are the release manager for this.

cms-bot commands are listed here

simonepigazzini · 2023-08-28T14:47:15Z

@hqucms can you elaborate on the fix? I think this affects only custom production in which either PNet or PartT are evaluated on the fly while producing NANO, right?

Thank you

hqucms · 2023-08-28T15:02:57Z

@hqucms can you elaborate on the fix? I think this affects only custom production in which either PNet or PartT are evaluated on the fly while producing NANO, right?

Thank you

Hi @simonepigazzini -- yes that's correct.

cmsbuild · 2023-08-28T17:04:22Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42670/36752

This PR adds an extra 20KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File PhysicsTools/NanoAOD/python/jetsAK4_CHS_cff.py modified in PR(s): [NanoAOD, JMENano] Updates for Nano and JMENano #42651
- File PhysicsTools/NanoAOD/python/jetsAK4_Puppi_cff.py modified in PR(s): [NanoAOD, JMENano] Updates for Nano and JMENano #42651

cmsbuild · 2023-08-28T17:04:42Z

Pull request #42670 was updated. @cmsbuild, @simonepigazzini, @vlimant can you please check and sign again.

hqucms · 2023-08-28T17:15:44Z

Hi @simonepigazzini -- it turns out that there is another typo, i.e., in the definition of btagRobustParTAK4CvB. This probably affects the official production... I updated the PR description with more info.

cmsbuild · 2023-08-28T17:20:15Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42670/36753

This PR adds an extra 20KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File PhysicsTools/NanoAOD/python/jetsAK4_CHS_cff.py modified in PR(s): [NanoAOD, JMENano] Updates for Nano and JMENano #42651
- File PhysicsTools/NanoAOD/python/jetsAK4_Puppi_cff.py modified in PR(s): [NanoAOD, JMENano] Updates for Nano and JMENano #42651

cmsbuild · 2023-08-28T17:20:37Z

Pull request #42670 was updated. @cmsbuild, @simonepigazzini, @vlimant can you please check and sign again.

simonepigazzini · 2023-08-29T08:37:41Z

@cms-sw/btv-pog-l2 please have a look.

cmsbuild · 2023-08-29T18:30:08Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42670/36775

This PR adds an extra 24KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File PhysicsTools/NanoAOD/python/custom_jme_cff.py modified in PR(s): [NanoAOD, JMENano] Updates for Nano and JMENano #42651
- File PhysicsTools/NanoAOD/python/jetsAK4_CHS_cff.py modified in PR(s): [NanoAOD, JMENano] Updates for Nano and JMENano #42651
- File PhysicsTools/NanoAOD/python/jetsAK4_Puppi_cff.py modified in PR(s): [NanoAOD, JMENano] Updates for Nano and JMENano #42651

cmsbuild · 2023-08-29T18:34:16Z

Pull request #42670 was updated. @cmsbuild, @simonepigazzini, @vlimant can you please check and sign again.

simonepigazzini · 2023-08-30T08:58:10Z

please test

simonepigazzini · 2023-08-30T09:00:34Z

PhysicsTools/NanoAOD/python/custom_jme_cff.py

-  btagRobustParTAK4CvB = Var("?(pt>=15)&&(bDiscriminator('pfParticleTransformerAK4JetTags:probc')+bDiscriminator('pfParticleTransformerAK4JetTags:probb')+bDiscriminator('pfParticleTransformerAK4JetTags:probbb')+bDiscriminator('pfParticleTransformerAK4JetTags:problepb'))>0?bDiscriminator('pfParticleTransformerAK4JetTags:probc')/(bDiscriminator('pfParticleTransformerAK4JetTags:probc')+bDiscriminator('pfParticleTransformerAK4JetTags:probb')+bDiscriminator('pfParticleTransformerAK4JetTags:probbb')+bDiscriminator('pfParticleTransformerAK4JetTags:problepb')):-1",float,doc="DeepJet c vs b+bb+lepb discriminator",precision=10),
-  btagRobustParTAK4QG  = Var("?(pt>=15)&&(bDiscriminator('pfParticleTransformerAK4JetTags:probg')+bDiscriminator('pfParticleTransformerAK4JetTags:probuds'))>0?bDiscriminator('pfParticleTransformerAK4JetTags:probg')/(bDiscriminator('pfParticleTransformerAK4JetTags:probg')+bDiscriminator('pfParticleTransformerAK4JetTags:probuds')):-1",float,doc="DeepJet g vs uds discriminator",precision=10),
+  btagRobustParTAK4B   = Var("?(pt>=15)?bDiscriminator('pfParticleTransformerAK4JetTags:probb')+bDiscriminator('pfParticleTransformerAK4JetTags:probbb')+bDiscriminator('pfParticleTransformerAK4JetTags:problepb'):-1",float,doc="RobustParTAK4 b+bb+lepb tag discriminator",precision=10),
+  btagRobustParTAK4C   = Var("?(pt>=15)?bDiscriminator('pfParticleTransformerAK4JetTags:probc'):-1",float,doc="RobustParTAK4 charm tag raw score",precision=10),


I'm puzzled that this went unnoticed in the validation @AnnikaStein .

@swertz confirmed that this needs a fix for the ongoing production

Do we have a plan? Are we stopping the production?

The production is stopped: https://its.cern.ch/jira/browse/PDMVRERECO-72?focusedId=4926345&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-4926345.

The plan is to backport this PR to 13_0 asap and restart the production.

cmsbuild · 2023-08-30T11:46:18Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6e83d2/34539/summary.html
COMMIT: 8986508
CMSSW: CMSSW_13_3_X_2023-08-29-2300/el8_amd64_gcc11
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/42670/34539/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially removed 18 lines from the logs
Reco comparison results: 338 differences found in the comparisons
DQMHistoTests: Total files compared: 48
DQMHistoTests: Total histograms compared: 3153095
DQMHistoTests: Total failures: 143
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3152930
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
Checked 207 log files, 159 edm output root files, 48 DQM output files
TriggerResults: no differences found

NANO Comparison Summary

Summary:

You potentially added 2 lines to the logs
Reco comparison results: 8 differences found in the comparisons
DQMHistoTests: Total files compared: 15
DQMHistoTests: Total histograms compared: 15526
DQMHistoTests: Total failures: 30
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 15496
DQMHistoTests: Total skipped: 0
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 14 files compared)
Checked 31 log files, 14 edm output root files, 15 DQM output files

Nano size comparison Summary:

Sample	kb/ev	ref kb/ev	diff kb/ev	ev/s/thd	ref ev/s/thd	diff rate	mem/thd	ref mem/thd
2500.0	2.448	2.448	-0.000 ( -0.0% )	5.33	5.35	-0.3%	2.176	2.180
2500.001	2.555	2.555	-0.000 ( -0.0% )	4.76	4.75	+0.3%	2.610	2.588
2500.002	2.500	2.500	-0.000 ( -0.0% )	4.95	5.01	-1.1%	2.593	2.595
2500.01	1.242	1.242	0.000 ( +0.0% )	9.96	9.95	+0.1%	2.308	2.298
2500.011	1.606	1.606	0.000 ( +0.0% )	5.35	5.33	+0.4%	2.507	2.495
2500.012	1.488	1.488	0.000 ( +0.0% )	7.74	7.59	+2.0%	2.403	2.414
2500.1	2.161	2.161	0.000 ( +0.0% )	5.42	5.37	+1.0%	2.040	2.047
2500.2	2.271	2.271	0.000 ( +0.0% )	6.20	6.12	+1.2%	1.953	1.954
2500.21	1.147	1.147	0.000 ( +0.0% )	4.45	4.47	-0.5%	2.243	2.230
2500.211	1.505	1.505	0.000 ( +0.0% )	3.92	3.92	-0.1%	2.319	2.314
2500.3	2.009	2.009	0.000 ( +0.0% )	13.16	13.01	+1.2%	1.754	1.759
2500.31	1.211	1.211	0.000 ( +0.0% )	21.04	20.80	+1.2%	2.164	2.160
2500.311	1.590	1.590	0.000 ( +0.0% )	15.27	15.02	+1.6%	2.239	2.235
2500.4	2.009	2.009	0.000 ( +0.0% )	13.15	13.07	+0.6%	1.758	1.763

simonepigazzini · 2023-08-31T12:44:52Z

@hqucms do you expect more changes?

@cms-sw/btv-pog-l2 @swertz, in the nanoDQM the test workflows we can see a change in the CvsB output node. Can you have a look and comment on the change? Do you have slides from your own comparison of the DeepJet and RobustPartT for that node?

Thank you

hqucms · 2023-08-31T13:04:53Z

@hqucms do you expect more changes?

Not from my side.

simonepigazzini · 2023-09-01T12:37:59Z

+1

@hqucms can you open a backport to 13_0 please?

cmsbuild · 2023-09-01T12:38:26Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

hqucms · 2023-09-04T10:34:03Z

+1

@hqucms can you open a backport to 13_0 please?

Hi @simonepigazzini -- sure I will do it today.

hqucms · 2023-09-04T12:15:48Z

Backport to 13_0_X created: #42710

antoniovilela · 2023-09-04T19:59:33Z

+1

…nanoDev_jmeNanoV11 [NanoAOD, JMENano] Backport of #42728 (Updates for Nano and JMENano), #42670 (Fix typos in jetsAK4 CHS and Puppi tables) and #42898 to 13_2_X

cmsbuild added this to the CMSSW_13_3_X milestone Aug 28, 2023

cmsbuild added pending-signatures tests-pending orp-pending code-checks-pending xpog-pending labels Aug 28, 2023

cmsbuild added code-checks-approved and removed code-checks-pending labels Aug 28, 2023

cmsbuild added code-checks-pending and removed code-checks-approved labels Aug 28, 2023

hqucms changed the title ~~Fix typo in jetsAK4_Puppi_cff.py~~ [NanoAOD] Fix typos in jetsAK4 CHS and Puppi tables Aug 28, 2023

cmsbuild added code-checks-approved and removed code-checks-pending labels Aug 28, 2023

hqucms and others added 2 commits August 28, 2023 19:11

Fix nanoAOD_addDeepInfoAK4 in jetsAK4_Puppi_cff.py

c5ccbca

Fix RobustParTAK4CvB definition.

c1496f5

hqucms force-pushed the patch-4 branch from 544dbc2 to c1496f5 Compare August 28, 2023 17:13

cmsbuild added code-checks-pending and removed code-checks-approved labels Aug 28, 2023

cmsbuild added code-checks-approved and removed code-checks-pending labels Aug 28, 2023

cmsbuild added the code-checks-pending label Aug 29, 2023

cmsbuild added code-checks-approved and removed code-checks-pending labels Aug 29, 2023

cmsbuild added tests-started and removed tests-pending labels Aug 30, 2023

simonepigazzini reviewed Aug 30, 2023

View reviewed changes

cmsbuild added tests-approved and removed tests-started labels Aug 30, 2023

cmsbuild added fully-signed xpog-approved and removed pending-signatures xpog-pending labels Sep 1, 2023

hqucms mentioned this pull request Sep 4, 2023

[13_0_X] Fix typos in jetsAK4 CHS and Puppi tables #42710

Merged

cmsbuild added orp-approved and removed orp-pending labels Sep 4, 2023

cmsbuild merged commit 488db28 into cms-sw:master Sep 4, 2023

nurfikri89 mentioned this pull request Sep 5, 2023

[NanoAOD, JMENano] Updates for Nano and JMENano #42651

Closed

nurfikri89 mentioned this pull request Sep 27, 2023

[NanoAOD, JMENano] Backport of #42728 (Updates for Nano and JMENano), #42670 (Fix typos in jetsAK4 CHS and Puppi tables) and #42898 to 13_2_X #42887

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[NanoAOD] Fix typos in jetsAK4 CHS and Puppi tables #42670

[NanoAOD] Fix typos in jetsAK4 CHS and Puppi tables #42670

hqucms commented Aug 28, 2023 •

edited

Loading

cmsbuild commented Aug 28, 2023

cmsbuild commented Aug 28, 2023

simonepigazzini commented Aug 28, 2023

hqucms commented Aug 28, 2023

cmsbuild commented Aug 28, 2023

cmsbuild commented Aug 28, 2023

hqucms commented Aug 28, 2023

cmsbuild commented Aug 28, 2023

cmsbuild commented Aug 28, 2023

simonepigazzini commented Aug 29, 2023

cmsbuild commented Aug 29, 2023

cmsbuild commented Aug 29, 2023

simonepigazzini commented Aug 30, 2023

simonepigazzini Aug 30, 2023

simonepigazzini Aug 31, 2023

rappoccio Sep 1, 2023

simonepigazzini Sep 4, 2023

cmsbuild commented Aug 30, 2023

simonepigazzini commented Aug 31, 2023

hqucms commented Aug 31, 2023

simonepigazzini commented Sep 1, 2023

cmsbuild commented Sep 1, 2023

hqucms commented Sep 4, 2023

hqucms commented Sep 4, 2023

antoniovilela commented Sep 4, 2023

[NanoAOD] Fix typos in jetsAK4 CHS and Puppi tables #42670

[NanoAOD] Fix typos in jetsAK4 CHS and Puppi tables #42670

Conversation

hqucms commented Aug 28, 2023 • edited Loading

PR description:

PR validation:

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

cmsbuild commented Aug 28, 2023

cmsbuild commented Aug 28, 2023

simonepigazzini commented Aug 28, 2023

hqucms commented Aug 28, 2023

cmsbuild commented Aug 28, 2023

cmsbuild commented Aug 28, 2023

hqucms commented Aug 28, 2023

cmsbuild commented Aug 28, 2023

cmsbuild commented Aug 28, 2023

simonepigazzini commented Aug 29, 2023

cmsbuild commented Aug 29, 2023

cmsbuild commented Aug 29, 2023

simonepigazzini commented Aug 30, 2023

simonepigazzini Aug 30, 2023

Choose a reason for hiding this comment

simonepigazzini Aug 31, 2023

Choose a reason for hiding this comment

rappoccio Sep 1, 2023

Choose a reason for hiding this comment

simonepigazzini Sep 4, 2023

Choose a reason for hiding this comment

cmsbuild commented Aug 30, 2023

Comparison Summary

NANO Comparison Summary

simonepigazzini commented Aug 31, 2023

hqucms commented Aug 31, 2023

simonepigazzini commented Sep 1, 2023

cmsbuild commented Sep 1, 2023

hqucms commented Sep 4, 2023

hqucms commented Sep 4, 2023

antoniovilela commented Sep 4, 2023

hqucms commented Aug 28, 2023 •

edited

Loading