[NanoAOD, JMENano] Updates for Nano and JMENano #42651

nurfikri89 · 2023-08-24T04:56:15Z

PR description:

This PR aims to add changes related to NanoAOD, JMENanoAOD and ensuring consistency of PuppiProducer instances when processing MiniAODs for production and analysis. The following changes are made:

NanoAOD

Add missing RUN3WINTER22PUPPIrunsBCDEprompt JetID version for jets.
Fix more typo in nanoAOD_addDeepInfoAK4().
Add (puppi-weighted) charged and neutral multiplicities for jets.
Add HF energy fractions for AK4 jets.
Add jet area for subjets. Improve documentation of collection.

JMENanoAOD

Add Run-3 JetIDs.
Remove AK8CHS jet collection.
Reduce content for AK4CHS collection by removing PUID/QGL tagger inputs and most flavour-tagging discriminants.
Increase pT thresholds for AK4CHS, AK4GEN, AK8GEN.
Rename some branches.

PuppiProducer consistency

Improve setupPuppiForPackedPF() in jetTools.py by adding packedpuppiNoLep instance.
In runMETCorrectionsAndUncertainties.py, make it optional to provide a different PuppiProducer module label rather than stick to a hard-coded label (puppiNoLep). Set the previously hard-coded label as the default option.

PR validation:

passes the standard runTheMatrix test: runTheMatrix.py -l limited -i all --ibeos
passes the following NanoAOD workflows: runTheMatrix.py -i all --ibeos -l 2500.0,2500.001,2500.002,2500.01,2500.011,2500.012,2500.1,2500.2,2500.21,2500.3,2500.4

If this PR will be backported please specify to which release cycle the backport is meant for:

To be backported to earlier 13_Y releases for Run-3 JMENano production.

…ets documentation and add area.

…puppiNoLep as default PuppiProducer names.

…GL input variables and most b-taggers for AK4CHS. Drop AK8 CHS jets.

… hard-coded label. 'puppiNoLep' is set as the default value.

cmsbuild · 2023-08-24T05:05:18Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42651/36704

This PR adds an extra 104KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File PhysicsTools/NanoAOD/python/nanoDQM_cfi.py modified in PR(s): Add 4 Isolation variables for Photon to NanoAOD #42255

cmsbuild · 2023-08-24T05:05:37Z

A new Pull Request was created by @nurfikri89 (Nurfikri Norjoharuddeen) for master.

It involves the following packages:

PhysicsTools/NanoAOD (xpog)
PhysicsTools/PatAlgos (xpog, reconstruction)
PhysicsTools/PatUtils (xpog, reconstruction)

@cmsbuild, @simonepigazzini, @mandrenguyen, @clacaputo, @vlimant can you please review it and eventually sign? Thanks.
@rappoccio, @gouskos, @Ming-Yan, @hatakeyamak, @emilbols, @mbluj, @ahinzmann, @demuller, @seemasharmafnal, @mmarionncern, @Senphy, @jdolen, @azotz, @jdamgov, @nhanvtran, @gkasieczka, @schoef, @andrzejnovak, @AlexDeMoor, @AnnikaStein, @JyothsnaKomaragiri, @gpetruc, @mariadalfonso this is something you requested to watch as well.
@perrotta, @dpiparo, @antoniovilela, @rappoccio you are the release manager for this.

cms-bot commands are listed here

cmsbuild · 2023-08-24T10:34:35Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42651/36709

This PR adds an extra 204KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File PhysicsTools/NanoAOD/python/nanoDQM_cfi.py modified in PR(s): Add 4 Isolation variables for Photon to NanoAOD #42255

cmsbuild · 2023-08-24T11:29:37Z

Pull request #42651 was updated. @cmsbuild, @simonepigazzini, @mandrenguyen, @clacaputo, @vlimant can you please check and sign again.

simonepigazzini · 2023-08-28T09:04:31Z

PhysicsTools/NanoAOD/python/jetsAK4_CHS_cff.py

@@ -171,11 +171,15 @@
        hfcentralEtaStripSize = Var("userInt('hfJetShowerShape:centralEtaStripSize')", int, doc="eta size of the central tower strip in HF (noise discriminating variable) "),
        hfadjacentEtaStripsSize = Var("userInt('hfJetShowerShape:adjacentEtaStripsSize')", int, doc="eta size of the strips next to the central tower strip in HF (noise discriminating variable) "),
        nConstituents = Var("numberOfDaughters()","uint8",doc="Number of particles in the jet"),
+        chMultiplicity = Var("chargedMultiplicity()","uint8",doc="Number of charged particles in the jet"),


are these changes intended? I didn't expect to see changes to the nano content in this PR

simonepigazzini · 2023-08-28T09:07:37Z

enable nano

simonepigazzini · 2023-08-28T09:07:42Z

please test

cmsbuild · 2023-08-28T12:37:39Z

-1

Failed Tests: RelVals-NANO
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e03adb/34497/summary.html
COMMIT: c751fe6
CMSSW: CMSSW_13_3_X_2023-08-27-2300/el8_amd64_gcc11
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/42651/34497/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-NANO

2500.312500.31_NANOdata130Xrun3/step2_NANOdata130Xrun3.log
2500.3112500.311_NANOdata130Xrun3/step2_NANOdata130Xrun3.log

Comparison Summary

Summary:

You potentially added 10 lines to the logs
ROOTFileChecks: Some differences in event products or their sizes found
Reco comparison results: 166 differences found in the comparisons
DQMHistoTests: Total files compared: 48
DQMHistoTests: Total histograms compared: 3153095
DQMHistoTests: Total failures: 22
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3153051
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 24.06 KiB( 47 files compared)
DQMHistoSizes: changed ( 11634.0,... ): 2.896 KiB Physics/NanoAODDQM
DQMHistoSizes: changed ( 13234.0,... ): 1.894 KiB Physics/NanoAODDQM
Checked 207 log files, 159 edm output root files, 48 DQM output files
TriggerResults: no differences found

…ts below some pt thresholds have reduced information stored (e.g multiplicities)

cmsbuild · 2023-09-05T06:19:09Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42651/36807

This PR adds an extra 160KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File PhysicsTools/NanoAOD/python/custom_jme_cff.py modified in PR(s): GenFilter for selecting events with GenPhotons #42715
- File PhysicsTools/NanoAOD/python/jetsAK4_CHS_cff.py modified in PR(s): GenFilter for selecting events with GenPhotons #42715
- File PhysicsTools/NanoAOD/python/jetsAK4_Puppi_cff.py modified in PR(s): GenFilter for selecting events with GenPhotons #42715
- File PhysicsTools/NanoAOD/python/nanoDQM_cff.py modified in PR(s): GenFilter for selecting events with GenPhotons #42715
- File PhysicsTools/NanoAOD/python/nanoDQM_cfi.py modified in PR(s): Add mu beamspot constrained pT. Increase mu eta and phi precision to 16 bits #42646, GenFilter for selecting events with GenPhotons #42715
- File PhysicsTools/NanoAOD/python/nanojmeDQM_cff.py modified in PR(s): GenFilter for selecting events with GenPhotons #42715

cmsbuild · 2023-09-05T06:19:35Z

Pull request #42651 was updated. @cmsbuild, @simonepigazzini, @jfernan2, @mandrenguyen, @vlimant can you please check and sign again.

cmsbuild · 2023-09-05T10:10:15Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42651/36810

This PR adds an extra 204KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File PhysicsTools/NanoAOD/python/custom_jme_cff.py modified in PR(s): GenFilter for selecting events with GenPhotons #42715
- File PhysicsTools/NanoAOD/python/jetsAK4_CHS_cff.py modified in PR(s): GenFilter for selecting events with GenPhotons #42715
- File PhysicsTools/NanoAOD/python/jetsAK4_Puppi_cff.py modified in PR(s): GenFilter for selecting events with GenPhotons #42715
- File PhysicsTools/NanoAOD/python/nanoDQM_cff.py modified in PR(s): GenFilter for selecting events with GenPhotons #42715
- File PhysicsTools/NanoAOD/python/nanoDQM_cfi.py modified in PR(s): Add mu beamspot constrained pT. Increase mu eta and phi precision to 16 bits #42646, GenFilter for selecting events with GenPhotons #42715
- File PhysicsTools/NanoAOD/python/nanojmeDQM_cff.py modified in PR(s): GenFilter for selecting events with GenPhotons #42715

cmsbuild · 2023-09-05T10:10:40Z

Pull request #42651 was updated. @cmsbuild, @simonepigazzini, @jfernan2, @mandrenguyen, @vlimant can you please check and sign again.

nurfikri89 · 2023-09-05T10:24:22Z

I am closing this PR and will submit another one using the latest IB release to include the changes in PR #42670.

nurfikri89 added 15 commits August 18, 2023 19:17

Fix typo. Add labelName.

31a828f

Add RUN3WINTER22PUPPIrunsBCDEprompt jetId version

307e43b

Add charged and neutral multiplicities

38f39d0

Fix jetId config. Add charged and neutral multiplicities. Update subj…

b9591a6

…ets documentation and add area.

Add charged and neutral multiplicities

4b8cdf7

Update jet variables in nanoDQM

c7ba79e

Update jet ID for Run3

3564e09

Add HF energy fractions

9b54bc4

Rename function to setup puppi for packedPFCandidates. Set puppi and …

60fc5c0

…puppiNoLep as default PuppiProducer names.

Update puppi setup by using setupPuppiForPackedPF() from jetTools.py

0b08e2a

Increase pT thresholds for AK4GEN, AK8GEN, AK4CHS jets. Remove PUID/Q…

18f3709

…GL input variables and most b-taggers for AK4CHS. Drop AK8 CHS jets.

Update nanojmeDQM

973ebda

Rename some variables. Revert to 'packedpuppi' as default.

ff7daf7

Make it optional to use a different PuppiProducer label rather than a…

292e03b

… hard-coded label. 'puppiNoLep' is set as the default value.

Rename multiplicity variables in nanojmeDQM_cff.py

e4b1523

cmsbuild added this to the CMSSW_13_3_X milestone Aug 24, 2023

cmsbuild added reconstruction-pending pending-signatures tests-pending orp-pending code-checks-pending xpog-pending labels Aug 24, 2023

cmsbuild added code-checks-approved and removed code-checks-pending labels Aug 24, 2023

Fix typo

6b1c394

cmsbuild added code-checks-pending and removed code-checks-approved labels Aug 24, 2023

simonepigazzini reviewed Aug 28, 2023

View reviewed changes

cmsbuild added tests-started and removed tests-pending labels Aug 28, 2023

cmsbuild added tests-rejected and removed tests-started labels Aug 28, 2023

This was referenced Aug 28, 2023

[NanoAOD] Fix typos in jetsAK4 CHS and Puppi tables #42670

Merged

Add 4 Isolation variables for Photon to NanoAOD #42255

Merged

Check isPFJet() for multiplicity variables because in MiniAOD, AK8 je…

d936de9

…ts below some pt thresholds have reduced information stored (e.g multiplicities)

cmsbuild added tests-pending code-checks-pending and removed tests-rejected code-checks-approved labels Sep 5, 2023

cmsbuild added code-checks-approved and removed code-checks-pending labels Sep 5, 2023

Merge branch 'master' into from1330pre1_jmenanoV11

544639f

cmsbuild added code-checks-pending and removed code-checks-approved labels Sep 5, 2023

cmsbuild added code-checks-approved and removed code-checks-pending labels Sep 5, 2023

nurfikri89 closed this Sep 5, 2023

nurfikri89 deleted the from1330pre1_jmenanoV11 branch February 25, 2024 14:26

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[NanoAOD, JMENano] Updates for Nano and JMENano #42651

[NanoAOD, JMENano] Updates for Nano and JMENano #42651

nurfikri89 commented Aug 24, 2023

cmsbuild commented Aug 24, 2023

cmsbuild commented Aug 24, 2023

cmsbuild commented Aug 24, 2023

cmsbuild commented Aug 24, 2023

simonepigazzini Aug 28, 2023

simonepigazzini commented Aug 28, 2023

simonepigazzini commented Aug 28, 2023

cmsbuild commented Aug 28, 2023

cmsbuild commented Sep 5, 2023

cmsbuild commented Sep 5, 2023

cmsbuild commented Sep 5, 2023

cmsbuild commented Sep 5, 2023

nurfikri89 commented Sep 5, 2023

[NanoAOD, JMENano] Updates for Nano and JMENano #42651

[NanoAOD, JMENano] Updates for Nano and JMENano #42651

Conversation

nurfikri89 commented Aug 24, 2023

PR description:

PR validation:

If this PR will be backported please specify to which release cycle the backport is meant for:

cmsbuild commented Aug 24, 2023

cmsbuild commented Aug 24, 2023

cmsbuild commented Aug 24, 2023

cmsbuild commented Aug 24, 2023

simonepigazzini Aug 28, 2023

Choose a reason for hiding this comment

simonepigazzini commented Aug 28, 2023

simonepigazzini commented Aug 28, 2023

cmsbuild commented Aug 28, 2023

RelVals-NANO

Comparison Summary

cmsbuild commented Sep 5, 2023

cmsbuild commented Sep 5, 2023

cmsbuild commented Sep 5, 2023

cmsbuild commented Sep 5, 2023

nurfikri89 commented Sep 5, 2023