Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to findAndChange for the new All-in-one [13.2.x] #42641

Merged
merged 3 commits into from
Aug 24, 2023

Conversation

amecca
Copy link
Contributor

@amecca amecca commented Aug 23, 2023

PR description:

This is a small fix addressing issues with a global configuration for a new All-in-one validation tool:

  • fix on the findAndChange macro to recognize all protocols in a search path,
  • automated parsing of the ROOT colors to the integer values,
  • fix on the problem with a decimals in the plot's right-corner label (e.g. 13.6 TeV)

PR validation:

Run the package tests:
scram b runtests use-ibeos

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Backport of #42608

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 23, 2023

A new Pull Request was created by @amecca for CMSSW_13_2_X.

It involves the following packages:

  • Alignment/OfflineValidation (alca)

@perrotta, @consuegs, @cmsbuild, @saumyaphor4252, @francescobrivio, @tvami can you please review it and eventually sign? Thanks.
@mmusich, @adewit, @tocheng, @tlampen this is something you requested to watch as well.
@perrotta, @dpiparo, @antoniovilela, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor

mmusich commented Aug 23, 2023

type bug-fix

@mmusich
Copy link
Contributor

mmusich commented Aug 23, 2023

@cmsbuild, please test

@mmusich
Copy link
Contributor

mmusich commented Aug 23, 2023

backport of #42608

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2991cf/34448/summary.html
COMMIT: a4c2916
CMSSW: CMSSW_13_2_X_2023-08-23-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/42641/34448/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 4 lines from the logs
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3196338
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3196313
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@perrotta
Copy link
Contributor

+alca

  • Issues listed in the PR description have been verified to be fixed by this PR by the authors who run the package test and checked its results

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit c3eb2e2 into cms-sw:CMSSW_13_2_X Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants