-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix on the findAndChange for a new All-in-one. #42608
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42608/36657
|
A new Pull Request was created by @TomasKello for master. It involves the following packages:
@perrotta, @consuegs, @cmsbuild, @saumyaphor4252, @francescobrivio, @tvami can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-174bbe/34362/summary.html Comparison SummarySummary:
|
Seems all is fine. After discussion, @amecca will yet add one more commit to this PR to preserve his authorship (I only did small changes). He will add an example of working configuration showing new feature (as there is never enough working examples). |
type bug-fix |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42608/36683
|
Pull request #42608 was updated. @perrotta, @consuegs, @cmsbuild, @saumyaphor4252, @francescobrivio, @tvami can you please check and sign again. |
@TomasKello, before re-launching tests, would you mind re-basing to avoid the merge in the commit history? |
f1407ad
to
75580dc
Compare
Done, please proceed. |
@cmsbuild please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-174bbe/34419/summary.html Comparison SummarySummary:
|
All tests passed, can we please merge? |
+alca |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
This is a small fix addressing issues with a global configuration for a new All-in-one validation tool:
PR validation:
Run the package tests:
scram b runtests use-ibeos
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
N/A
FYI @consuegs @henriettepetersen @amecca