Fix HGCAL Layer Clusters visualization in Fireworks - Backport CMSSW_13_2_X

[waredjeb]

This PR is a backport of #42519

Description

This PR fixes the HGCAL Layer Clusters (CaloClusters) visualization in Fireworks. The Layer Clusters collection changed name in CMSSW_13_2_X in #41589
With this PR Fireworks will check if the hgcalLayerClusters collection is present, if not it will try to read the hgcalMergeLayerClusters collection, in this way it is possible to read files produced before CMSSW_13_2_X with new releases.
Validation

Validation

• Tested on WF 20906.0

[cmsbuild]

A new Pull Request was created by @waredjeb (Wahid Redjeb) for CMSSW_13_2_X.

It involves the following packages:

• Fireworks/Calo (visualization)

@cmsbuild, @makortel, @Dr15Jones, @alja can you please review it and eventually sign? Thanks.
@alja this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

• Backported from Fix HGCAL Layer Clusters visualization in Fireworks #42519

[perrotta]

please test

[perrotta]

@waredjeb @alja perhaps a backport in 13_1 (Phase2 production release) is more relevant than this one in 13_2 (data taking release for HI)

[perrotta]

backport of #42519

[waredjeb]

@waredjeb @alja perhaps a backport in 13_1 (Phase2 production release) is more relevant than this one in 13_2 (data taking release for HI)

Hi @perrotta. This PR is meant to fix a problem created with #41589, which If understand correctly is in CMSSW_13_2_X. I'm wondering whether backporting this fix to CMSSW_13_1 could have any effects?

[perrotta]

Hi @perrotta. This PR is meant to fix a problem created with #41589, which If understand correctly is in CMSSW_13_2_X. I'm wondering whether backporting this fix to CMSSW_13_1 could have any effects?

Ok, thank you @waredjeb
No additional backports needed, then

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ed2fe8/34312/summary.html
COMMIT: 743c4ba
CMSSW: CMSSW_13_2_X_2023-08-15-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/42563/34312/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 13 lines to the logs
• Reco comparison results: 50 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3196338
• DQMHistoTests: Total failures: 225
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3196091
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 207 log files, 159 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[alja]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1