Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix HGCAL Layer Clusters visualization in Fireworks #42519

Merged
merged 1 commit into from
Aug 14, 2023

Conversation

waredjeb
Copy link
Contributor

@waredjeb waredjeb commented Aug 9, 2023

This PR fixes the HGCAL Layer Clusters (CaloClusters) visualization in Fireworks. The Layer Clusters collection changed name in CMSSW_13_2_X in #41589
With this PR Fireworks will check if the hgcalLayerClusters collection is present, if not it will try to read the hgcalMergeLayerClusters collection, in this way it is possible to read files produced before CMSSW_13_2_X with new releases.

Validation

  • Tested on WF 20906.0

Backport

Foreseen backport to CMSSW_13_2_X

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 9, 2023

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42519/36535

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 9, 2023

A new Pull Request was created by @waredjeb (Wahid Redjeb) for master.

It involves the following packages:

  • Fireworks/Calo (visualization)

@cmsbuild, @makortel, @Dr15Jones, @alja can you please review it and eventually sign? Thanks.
@alja this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@alja
Copy link
Contributor

alja commented Aug 13, 2023

+1
@waredjeb
The change is OK.
I'm just curious if it would be possible to choose the collection name from the process history?

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@waredjeb
Copy link
Contributor Author

+1 @waredjeb The change is OK. I'm just curious if it would be possible to choose the collection name from the process history?

Hi @alja thanks. That would be the best thing to do, but I couldn't find anything on this, I just supposed it wasn't possible

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-64286b/34256/summary.html
COMMIT: 193830b
CMSSW: CMSSW_13_3_X_2023-08-13-0000/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/42519/34256/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 13 lines to the logs
  • Reco comparison results: 6 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3152843
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3152818
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@perrotta
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants