Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup of HLT Phase-2 menu (#42351, #42352) [13_2_X] #42554

Merged

Conversation

missirol
Copy link
Contributor

backport of #42351
backport of #42352

PR description:

Cleanup of JME-related modules in the HLT Phase-2 menu. See #42351 and #42352 for further details.

Needed for HLT Phase-2 studies in 13_1_X (see #42512 (comment)).

@theochatzis

PR validation:

runTheMatrix.py -l 23634.0

If this PR is a backport, please specify the original PR and why you need to backport that PR. If this PR will be backported, please specify to which release cycle the backport is meant for:

#42351
#42352

Needed for HLT Phase-2 studies in 13_1_X (see #42512 (comment)).

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 12, 2023

A new Pull Request was created by @missirol (Marino Missiroli) for CMSSW_13_2_X.

It involves the following packages:

  • HLTrigger/Configuration (hlt)

@cmsbuild, @missirol, @Martin-Grunewald can you please review it and eventually sign? Thanks.
@rchatter, @SohamBhattacharya, @argiro, @Martin-Grunewald, @silviodonato, @thomreis, @wang0jin, @beaucero this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@missirol
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-299b50/34251/summary.html
COMMIT: 18f8ac1
CMSSW: CMSSW_13_2_X_2023-08-11-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/42554/34251/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 19 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 57 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3196338
  • DQMHistoTests: Total failures: 222
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3196094
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: found differences in 5 / 46 workflows

@missirol
Copy link
Contributor Author

+hlt

Spurious DQM differences compatible with #39754.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 229771f into cms-sw:CMSSW_13_2_X Aug 14, 2023
@missirol missirol deleted the devel_hltPhase2_42351n42352_132X branch August 14, 2023 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants