[HLT_Phase2] Removal of Preshower modules

[theochatzis]

PR description:

This PR is for removal of preshower modules (from Digis level) that come in Phase2 HLT and are used for PF and composite objects like PF based jets, MET as well as ECAL clusters used by EGamma/Muon.

PR validation:

The modified HLT configuration works with cmsRun and the counts in TriggerReport remain unchanged.
Also the distributions of eta and pt in PF candidates remain un-changed as shown here

@beaucero @SohamBhattacharya

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42352/36378

• This PR adds an extra 36KB to repository

[cmsbuild]

A new Pull Request was created by @theochatzis (Theo Chatzistavrou) for master.

It involves the following packages:

• HLTrigger/Configuration (hlt)

@cmsbuild, @missirol, @Martin-Grunewald can you please review it and eventually sign? Thanks.
@rchatter, @SohamBhattacharya, @argiro, @Martin-Grunewald, @missirol, @silviodonato, @thomreis, @wang0jin, @beaucero this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[missirol]

please test

[cmsbuild]

-1

Failed Tests: RelVals RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a59147/33869/summary.html
COMMIT: de1aef9
CMSSW: CMSSW_13_3_X_2023-07-24-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/42352/33869/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

• 24896.0

----- Begin Fatal Exception 25-Jul-2023 12:42:11 CEST-----------------------
An exception of category 'ProductNotFound' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 1 stream: 0
   [1] Running path 'HLTriggerFinalPath'
   [2] Prefetching for module TriggerSummaryProducerAOD/'hltTriggerSummaryAOD'
   [3] Prefetching for module EgammaHLTRecoEcalCandidateProducers/'hltEgammaCandidatesUnseeded'
   [4] Prefetching for module PFECALSuperClusterProducer/'hltParticleFlowSuperClusterECALUnseeded'
   [5] Calling method for module CorrectedECALPFClusterProducer/'hltParticleFlowClusterECALUnseeded'
Exception Message:
Principal::getByToken: Found zero products matching all criteria
Looking for type: std::vector<reco::PFCluster>
Looking for module label: particleFlowClusterPS
Looking for productInstanceName: 

   Additional Info:
      [a] If you wish to continue processing events after a ProductNotFound exception,
add "SkipEvent = cms.untracked.vstring('ProductNotFound')" to the "options" PSet in the configuration.

----- End Fatal Exception -------------------------------------------------

• 24900.0

----- Begin Fatal Exception 25-Jul-2023 12:42:17 CEST-----------------------
An exception of category 'ProductNotFound' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 1 stream: 0
   [1] Running path 'HLTriggerFinalPath'
   [2] Prefetching for module TriggerSummaryProducerAOD/'hltTriggerSummaryAOD'
   [3] Prefetching for module EgammaHLTRecoEcalCandidateProducers/'hltEgammaCandidatesUnseeded'
   [4] Prefetching for module PFECALSuperClusterProducer/'hltParticleFlowSuperClusterECALUnseeded'
   [5] Calling method for module CorrectedECALPFClusterProducer/'hltParticleFlowClusterECALUnseeded'
Exception Message:
Principal::getByToken: Found zero products matching all criteria
Looking for type: std::vector<reco::PFCluster>
Looking for module label: particleFlowClusterPS
Looking for productInstanceName: 

   Additional Info:
      [a] If you wish to continue processing events after a ProductNotFound exception,
add "SkipEvent = cms.untracked.vstring('ProductNotFound')" to the "options" PSet in the configuration.

----- End Fatal Exception -------------------------------------------------

• 24834.0

----- Begin Fatal Exception 25-Jul-2023 12:43:44 CEST-----------------------
An exception of category 'ProductNotFound' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 1 stream: 0
   [1] Running path 'HLTriggerFinalPath'
   [2] Prefetching for module TriggerSummaryProducerAOD/'hltTriggerSummaryAOD'
   [3] Prefetching for module EgammaHLTRecoEcalCandidateProducers/'hltEgammaCandidatesUnseeded'
   [4] Prefetching for module PFECALSuperClusterProducer/'hltParticleFlowSuperClusterECALUnseeded'
   [5] Calling method for module CorrectedECALPFClusterProducer/'hltParticleFlowClusterECALUnseeded'
Exception Message:
Principal::getByToken: Found zero products matching all criteria
Looking for type: std::vector<reco::PFCluster>
Looking for module label: particleFlowClusterPS
Looking for productInstanceName: 

   Additional Info:
      [a] If you wish to continue processing events after a ProductNotFound exception,
add "SkipEvent = cms.untracked.vstring('ProductNotFound')" to the "options" PSet in the configuration.

----- End Fatal Exception -------------------------------------------------

Expand to see more relval errors ...

• 25034.999
• 24834.911

RelVals-INPUT

• 20834.020834.0_TTbar_14TeV+2026D88/step2_TTbar_14TeV+2026D88.log
• 20834.50220834.502_TTbar_14TeV+2026D88_Patatrack_PixelOnlyGPU/step2_TTbar_14TeV+2026D88_Patatrack_PixelOnlyGPU.log
• 20834.50120834.501_TTbar_14TeV+2026D88_Patatrack_PixelOnlyCPU/step2_TTbar_14TeV+2026D88_Patatrack_PixelOnlyCPU.log

Expand to see more relval errors ...

• 23634.0
• 24834.0
• 24834.103
• 24834.5
• 24834.9
• 24900.0
• 24896.0
• 25034.114

[missirol]

@theochatzis , please have a look at the errors above (you can reproduce them offline with the workflows available via runTheMatrix.py, e.g. runTheMatrix.py -l 24834.0).

[theochatzis]

Thanks @missirol . I did a commit with the piece that was missing in the initial one and creating the error. Sorry for the inconvenience. With this the wf that produced the error seems to work.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42352/36388

• This PR adds an extra 36KB to repository

[cmsbuild]

Pull request #42352 was updated. @cmsbuild, @missirol, @Martin-Grunewald can you please check and sign again.

[Martin-Grunewald]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a59147/33875/summary.html
COMMIT: 2df03e3
CMSSW: CMSSW_13_3_X_2023-07-25-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/42352/33875/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 15 lines from the logs
• ROOTFileChecks: Some differences in event products or their sizes found
• Reco comparison results: 18 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3150117
• DQMHistoTests: Total failures: 3
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3150092
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 207 log files, 159 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[missirol]

+hlt

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1

[SohamBhattacharya]

Hi @theochatzis since we need to run the timing measurements on the Spring23 samples in 13_1_X, could you please make a backport of the PR to 13_1_X?