Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[13.2.X] Add SiStripApproximateClusterCollection as a simple format for RAW #42545

Merged

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Aug 11, 2023

backport of #42495

PR description:

Based on the issue "Dataformat compatibility issue for HI SiStrip cluster in RAW" (#39106)

Aim: changing Data-format (edmNew::DetSetVector) in RAW to be simple-enough for infinite backwards compatibility. -> It has to be readable by all future CMSSW releases.
Re-defining the corresponding final data-types directly in the ApproximatedClusters.
Need to be straightforward to convert from edmNew::DetSetVector.

The simplified data format has updated (recommended by Matti in 2022 Sep)
(master...makortel:cmssw:siStripApproximateClusterCollection_v2)

Target : 13_2_X release for the 2023 HeavyIon data-taking.

PR validation:

Tested in CMSSW_13_3_X_2023-08-02-1100, the basic test passed in the CMSSW PR instructions:

  • passes runTheMatrix.py -l 140.58 -t 4 -j 8 --ibeos

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Verbatim backport of #42495 to be used for 2023 Heavy Ion data-taking

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 11, 2023

A new Pull Request was created by @mmusich (Marco Musich) for CMSSW_13_2_X.

It involves the following packages:

  • Configuration/PyReleaseValidation (pdmv, upgrade)
  • DQM/SiStripMonitorApproximateCluster (dqm)
  • DataFormats/SiStripCluster (reconstruction)
  • RecoLocalTracker/SiStripClusterizer (reconstruction)

@bbilin, @emanueleusai, @srimanob, @clacaputo, @mandrenguyen, @cmsbuild, @AdrianoDee, @miquork, @pmandrik, @syuvivida, @nothingface0, @sunilUIET, @tjavaid, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks.
@echabert, @VourMa, @felicepantaleo, @yduhm, @robervalwalsh, @Martin-Grunewald, @fioriNTU, @threus, @slomeo, @makortel, @JanFSchulte, @missirol, @jlidrych, @GiacomoSguazzoni, @rovere, @VinInn, @jandrea, @alesaggio, @idebruyn, @mmusich, @mtosi, @fabiocos, @gbenelli, @gpetruc this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor Author

mmusich commented Aug 11, 2023

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a15027/34239/summary.html
COMMIT: 2af0ae8
CMSSW: CMSSW_13_2_X_2023-08-11-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/42545/34239/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 1 lines from the logs
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3196338
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3196316
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@mandrenguyen
Copy link
Contributor

+1

@srimanob
Copy link
Contributor

+Upgrade

From the upgrade side, only removing workflow and step.

@emanueleusai
Copy link
Member

+1

@sunilUIET
Copy link
Contributor

+pdmv

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit cfc01ed into cms-sw:CMSSW_13_2_X Aug 16, 2023
@mmusich mmusich deleted the mm_ApproxCluster_dataformat_13_2_X branch August 16, 2023 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants