Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add HLTFilter template HLTL1TMatchedJetsVBFFilter [13_2_X] #42544

Merged

Conversation

missirol
Copy link
Contributor

backport of #42543

PR description:

From the description of #42543:

This PR adds new HLTFilters which is meant to be used for an update of the VBF-parking triggers of the current HLT pp menu.

The new HLTFilters are instantiations of the plugin template HLTL1TMatchedJetsVBFFilter, which serves as an improved version of the EDProducer template L1TJetsMatching.

For further details, see also CMSHLT-2887.

Attn: @portalesHEP

PR validation:

Similar to #42543 (see #42543 (comment)).

If this PR is a backport, please specify the original PR and why you need to backport that PR. If this PR will be backported, please specify to which release cycle the backport is meant for:

#42543

Not needed for ppRef nor HIon, but useful to start the cleanup of the HLT pp menu ahead of 2024.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 11, 2023

A new Pull Request was created by @missirol (Marino Missiroli) for CMSSW_13_2_X.

It involves the following packages:

  • HLTrigger/JetMET (hlt)

@cmsbuild, @missirol, @Martin-Grunewald can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @silviodonato this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@missirol missirol force-pushed the devel_hltL1TMatchedPFJetsVBFFilter branch from 21aa99c to 9b288f5 Compare August 11, 2023 10:14
@cmsbuild
Copy link
Contributor

Pull request #42544 was updated. @cmsbuild, @missirol, @Martin-Grunewald can you please check and sign again.

@missirol missirol changed the title add HLTFilter template HLTL1TMatchedPFJetsVBFFilter [13_2_X] add HLTFilter template HLTL1TMatchedJetsVBFFilter [13_2_X] Aug 11, 2023
@missirol
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4be8a5/34227/summary.html
COMMIT: 9b288f5
CMSSW: CMSSW_13_2_X_2023-08-11-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/42544/34227/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 3 lines to the logs
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3196338
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3196310
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@missirol missirol force-pushed the devel_hltL1TMatchedPFJetsVBFFilter branch from 9b288f5 to d5cdd00 Compare August 11, 2023 16:02
@cmsbuild
Copy link
Contributor

Pull request #42544 was updated. @cmsbuild, @missirol, @Martin-Grunewald can you please check and sign again.

@missirol
Copy link
Contributor Author

please test

Minor technical changes in the last push. This should be the final version.

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4be8a5/34242/summary.html
COMMIT: d5cdd00
CMSSW: CMSSW_13_2_X_2023-08-11-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/42544/34242/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 9 lines from the logs
  • Reco comparison results: 12 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3196338
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3196310
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@missirol
Copy link
Contributor Author

+hlt

Addition of HLTFilters not used yet in any central workflow, and validated privately (see #42543).

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 0fe20e7 into cms-sw:CMSSW_13_2_X Aug 14, 2023
@missirol missirol deleted the devel_hltL1TMatchedPFJetsVBFFilter branch August 14, 2023 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants