simplify implementation of SiPixelQualityESProducer and use multiple instances of it

[missirol]

PR description:

This PR includes a change tested as part of #42492.

As a way to disentangle the SiPixelQuality ES product used by HLT from other ones used at times in other steps (e.g. the one with label "forDigitizer"), the implementation of the ESProducer is simplified to return just one ES product, and separate instances of the ESProducer are added to the python configuration. In order to load the 'extra' ESProducers only when appropriate, calls to makeProcessModifier are used in the cfi files to remove the modules from the cms.Process when the relevant modifiers are not enabled.

Merely technical. No changes expected (in terms of physics results).

PR validation:

A few selected wfs of runTheMatrix.py passed.

If this PR is a backport, please specify the original PR and why you need to backport that PR. If this PR will be backported, please specify to which release cycle the backport is meant for:

N/A

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42497/36501

• This PR adds an extra 36KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File CalibTracker/SiPixelESProducers/plugins/SiPixelQualityESProducer.cc modified in PR(s): From cmssw 12 4 11 patch3 #42461
  • File CalibTracker/SiPixelESProducers/python/SiPixelQualityESProducer_cfi.py modified in PR(s): From cmssw 12 4 11 patch3 #42461
  • File HLTrigger/Configuration/python/customizeHLTforCMSSW.py modified in PR(s): revert PR 40443 w/o introducing bricked pixels #42454, From cmssw 12 4 11 patch3 #42461

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42497/36501/code-format.patch
  e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42497/36501/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42497/36502

• This PR adds an extra 36KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File CalibTracker/SiPixelESProducers/plugins/SiPixelQualityESProducer.cc modified in PR(s): From cmssw 12 4 11 patch3 #42461
  • File CalibTracker/SiPixelESProducers/python/SiPixelQualityESProducer_cfi.py modified in PR(s): From cmssw 12 4 11 patch3 #42461
  • File HLTrigger/Configuration/python/customizeHLTforCMSSW.py modified in PR(s): revert PR 40443 w/o introducing bricked pixels #42454, From cmssw 12 4 11 patch3 #42461

[cmsbuild]

A new Pull Request was created by @missirol (Marino Missiroli) for master.

It involves the following packages:

• CalibTracker/Configuration (alca)
• CalibTracker/SiPixelESProducers (alca)
• CondTools/SiPixel (db)
• HLTrigger/Configuration (hlt)
• SimGeneral/MixingModule (simulation)

@perrotta, @Martin-Grunewald, @consuegs, @civanch, @mdhildreth, @cmsbuild, @missirol, @saumyaphor4252, @tvami, @francescobrivio can you please review it and eventually sign? Thanks.
@mroguljic, @echabert, @makortel, @robervalwalsh, @gbenelli, @tocheng, @VinInn, @Martin-Grunewald, @silviodonato, @dkotlins, @ferencek, @mmusich, @fabiocos, @slomeo, @tvami this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42497/36504

• This PR adds an extra 36KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File CalibTracker/SiPixelESProducers/plugins/SiPixelQualityESProducer.cc modified in PR(s): From cmssw 12 4 11 patch3 #42461
  • File CalibTracker/SiPixelESProducers/python/SiPixelQualityESProducer_cfi.py modified in PR(s): From cmssw 12 4 11 patch3 #42461
  • File HLTrigger/Configuration/python/customizeHLTforCMSSW.py modified in PR(s): revert PR 40443 w/o introducing bricked pixels #42454, From cmssw 12 4 11 patch3 #42461

[cmsbuild]

Pull request #42497 was updated. @perrotta, @Martin-Grunewald, @consuegs, @civanch, @mdhildreth, @cmsbuild, @missirol, @saumyaphor4252, @tvami, @francescobrivio can you please check and sign again.

[mmusich]

test parameters:

• workflows = 139.001, 141.042

[missirol]

please test

[cmsbuild]

Pull request #42497 was updated. @perrotta, @Martin-Grunewald, @consuegs, @civanch, @mdhildreth, @cmsbuild, @missirol, @saumyaphor4252, @tvami, @francescobrivio can you please check and sign again.

[missirol]

Another rebase was needed. I hope now this can proceed to review, and possibly integration.

[perrotta]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c586eb/34385/summary.html
COMMIT: d201ccc
CMSSW: CMSSW_13_3_X_2023-08-21-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/42497/34385/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 22 lines from the logs
• Reco comparison results: 2 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3242739
• DQMHistoTests: Total failures: 0
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3242717
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 211 log files, 163 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[missirol]

+hlt

[missirol]

@cms-sw/simulation-l2 @cms-sw/alca-l2 @cms-sw/db-l2 , could you please review this PR ?

[perrotta]

+alca

• confirming simplify implementation of SiPixelQualityESProducer and use multiple instances of it #42497 (comment)

[perrotta]

+db

[civanch]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1