-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes bug when SoA has not columns, only scalars [13.2.x] #42481
Conversation
backport #42109 |
type bugfix |
A new Pull Request was created by @fwyzard (Andrea Bocci) for CMSSW_13_2_X. It involves the following packages:
@cmsbuild, @makortel, @fwyzard can you please review it and eventually sign? Thanks. cms-bot commands are listed here
|
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a24479/34113/summary.html Comparison SummarySummary:
|
+heterogeneous |
This pull request is fully signed and it will be integrated in one of the next CMSSW_13_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
This PR fixes and issue in macro generation of code when an SoA contains only scalars and not column. Special cases were
introduced to handle this case gracefully.
PR validation:
New SoAs with no columns are added. A successful compilation is enough to validate this PR.
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
Backport of #42109 to 13.2.x .