Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes bug when SoA has not columns, only scalars [13.2.x] #42481

Merged
merged 1 commit into from
Aug 16, 2023

Conversation

fwyzard
Copy link
Contributor

@fwyzard fwyzard commented Aug 6, 2023

PR description:

This PR fixes and issue in macro generation of code when an SoA contains only scalars and not column. Special cases were
introduced to handle this case gracefully.

PR validation:

New SoAs with no columns are added. A successful compilation is enough to validate this PR.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Backport of #42109 to 13.2.x .

@fwyzard
Copy link
Contributor Author

fwyzard commented Aug 6, 2023

backport #42109

@fwyzard
Copy link
Contributor Author

fwyzard commented Aug 6, 2023

type bugfix

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 6, 2023

A new Pull Request was created by @fwyzard (Andrea Bocci) for CMSSW_13_2_X.

It involves the following packages:

  • DataFormats/SoATemplate (heterogeneous)

@cmsbuild, @makortel, @fwyzard can you please review it and eventually sign? Thanks.
@missirol, @rovere this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@fwyzard
Copy link
Contributor Author

fwyzard commented Aug 6, 2023

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 6, 2023

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a24479/34113/summary.html
COMMIT: 792466d
CMSSW: CMSSW_13_2_X_2023-08-06-0000/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/42481/34113/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 4 lines to the logs
  • Reco comparison results: 10 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3195634
  • DQMHistoTests: Total failures: 7
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3195605
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@fwyzard
Copy link
Contributor Author

fwyzard commented Aug 14, 2023

+heterogeneous

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@fwyzard fwyzard mentioned this pull request Aug 15, 2023
5 tasks
@perrotta
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit d03bf03 into cms-sw:CMSSW_13_2_X Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants