Fixes bug when SoA has not columns, only scalars.

[ericcano]

PR description:

This PR fixes and issue in macro generation of code when an SoA contains only scalars and not column. Special cases were
introduced to handle this case gracefully.

PR validation:

New SoAs with no columns are added. A successful compilation is enough to validate this PR.

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42109/36087

• This PR adds an extra 24KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File DataFormats/SoATemplate/test/SoALayoutAndView_t.cu modified in PR(s): SoA range checking: adds inter operability between range checked and non range checked #41928
  • File DataFormats/SoATemplate/test/SoALayoutAndView_t.hip.cc modified in PR(s): SoA range checking: adds inter operability between range checked and non range checked #41928

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42109/36087/code-format.patch
  e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42109/36087/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42109/36088

• This PR adds an extra 28KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File DataFormats/SoATemplate/test/SoALayoutAndView_t.cu modified in PR(s): SoA range checking: adds inter operability between range checked and non range checked #41928
  • File DataFormats/SoATemplate/test/SoALayoutAndView_t.hip.cc modified in PR(s): SoA range checking: adds inter operability between range checked and non range checked #41928

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42109/36088/code-format.patch
  e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42109/36088/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42109/36091

• This PR adds an extra 24KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File DataFormats/SoATemplate/test/SoALayoutAndView_t.cu modified in PR(s): SoA range checking: adds inter operability between range checked and non range checked #41928
  • File DataFormats/SoATemplate/test/SoALayoutAndView_t.hip.cc modified in PR(s): SoA range checking: adds inter operability between range checked and non range checked #41928

[cmsbuild]

A new Pull Request was created by @ericcano (Eric Cano) for master.

It involves the following packages:

• DataFormats/SoATemplate (heterogeneous)

@cmsbuild, @makortel, @fwyzard can you please review it and eventually sign? Thanks.
@missirol, @rovere this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[makortel]

enable gpu

[makortel]

@cmsbuild, please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8eae33/33418/summary.html
COMMIT: 792466d
CMSSW: CMSSW_13_2_X_2023-06-27-1100/el8_amd64_gcc11
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/42109/33418/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 13 lines from the logs
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3200270
• DQMHistoTests: Total failures: 3
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3200245
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 207 log files, 159 edm output root files, 48 DQM output files
• TriggerResults: no differences found

GPU Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 9 differences found in the comparisons
• DQMHistoTests: Total files compared: 3
• DQMHistoTests: Total histograms compared: 40086
• DQMHistoTests: Total failures: 222
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 39864
• DQMHistoTests: Total skipped: 0
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 2 files compared)
• Checked 8 log files, 6 edm output root files, 3 DQM output files
• TriggerResults: no differences found

[fwyzard]

LGTM

I'd like to test this on top of the Pixel changes that could make use of a scalar-only SoA.

[fwyzard]

+heterogeneous

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

please test

[cmsbuild]

-1

Failed Tests: GpuUnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8eae33/34269/summary.html
COMMIT: 792466d
CMSSW: CMSSW_13_3_X_2023-08-14-1100/el8_amd64_gcc11
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/42109/34269/install.sh to create a dev area with all the needed externals and cmssw changes.

GPU Unit Tests

I found errors in the following unit tests:

---> test testEigenGPUNoFit_t had ERRORS

Comparison Summary

Summary:

• You potentially added 19 lines to the logs
• Reco comparison results: 8 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3152843
• DQMHistoTests: Total failures: 3
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3152818
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 207 log files, 159 edm output root files, 48 DQM output files
• TriggerResults: no differences found

GPU Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 3
• DQMHistoTests: Total histograms compared: 40118
• DQMHistoTests: Total failures: 20
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 40098
• DQMHistoTests: Total skipped: 0
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 2 files compared)
• Checked 8 log files, 10 edm output root files, 3 DQM output files
• TriggerResults: no differences found

[fwyzard]

testEigenGPUNoFit_t does not use the SoA modified by this PR.

[fwyzard]

please test

[cmsbuild]

-1

Failed Tests: GpuUnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8eae33/34277/summary.html
COMMIT: 792466d
CMSSW: CMSSW_13_3_X_2023-08-14-2300/el8_amd64_gcc11
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/42109/34277/install.sh to create a dev area with all the needed externals and cmssw changes.

GPU Unit Tests

I found errors in the following unit tests:

---> test testEigenGPUNoFit_t had ERRORS

Comparison Summary

Summary:

• You potentially removed 7 lines from the logs
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3152843
• DQMHistoTests: Total failures: 0
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3152821
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 207 log files, 159 edm output root files, 48 DQM output files
• TriggerResults: no differences found

GPU Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 3
• DQMHistoTests: Total histograms compared: 40118
• DQMHistoTests: Total failures: 21
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 40097
• DQMHistoTests: Total skipped: 0
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 2 files compared)
• Checked 8 log files, 10 edm output root files, 3 DQM output files
• TriggerResults: no differences found

[fwyzard]

testEigenGPUNoFit_t is already failing in the current IB, at least on lxplus8-gpu:

[2023-08-15 14:07:32] fwyzard@lxplus8s05:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02798/el8_amd64_gcc11/cms/cmssw/CMSSW_13_3_X_2023-08-14-2300/test/el8_amd64_gcc11$ ./testEigenGPUNoFit_t
TEST EIGENVALUES
TEST INVERSE 3x3
TEST INVERSE 4x4
TEST INVERSE 5x5
testEigenGPUNoFit_t: /data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/5c9c7d5da4d193779c99c869bcc62014/opt/cmssw/el8_amd64_gcc11/cms/cmssw/CMSSW_13_3_X_2023-08-14-2300/src/RecoTracker/PixelTrackFitting/test/test_common.h:24: bool isEqualFuzzy(C1, C2, double) [with C1 = Eigen::Matrix<double, 5, 5>; C2 = Eigen::Matrix<double, 5, 5>]: Assertion `std::abs(a(i, j) - b(i, j)) < std::min(std::abs(a(i, j)), std::abs(b(i, j))) * epsilon' failed.
Aborted (core dumped)

[fwyzard]

testEigenGPUNoFit_t was already failing in the oldest IB I can still find, CMSSW_13_3_X_2023-08-06-0000:

[2023-08-15 14:10:49] fwyzard@lxplus8s05:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02797/el8_amd64_gcc11/cms/cmssw/CMSSW_13_3_X_2023-08-06-0000/test/el8_amd64_gcc11$ cmsenv

[2023-08-15 14:11:01] fwyzard@lxplus8s05:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02797/el8_amd64_gcc11/cms/cmssw/CMSSW_13_3_X_2023-08-06-0000/test/el8_amd64_gcc11$ ./testEigenGPUNoFit_t
TEST EIGENVALUES
TEST INVERSE 3x3
TEST INVERSE 4x4
TEST INVERSE 5x5
testEigenGPUNoFit_t: /data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/7a1027c19550f663ecdf792af6679f08/opt/cmssw/el8_amd64_gcc11/cms/cmssw/CMSSW_13_3_X_2023-08-06-0000/src/RecoTracker/PixelTrackFitting/test/test_common.h:24: bool isEqualFuzzy(C1, C2, double) [with C1 = Eigen::Matrix<double, 5, 5>; C2 = Eigen::Matrix<double, 5, 5>]: Assertion `std::abs(a(i, j) - b(i, j)) < std::min(std::abs(a(i, j)), std::abs(b(i, j))) * epsilon' failed.
Aborted (core dumped)

[fwyzard]

@perrotta, the test testEigenGPUNoFit_t is already failing in the IBs and in CMSSW_13_3_0_pre1.

While of course we should look into the reason and fix it, can we merge this PR (and its backport to 13.2.x) in the meantime ?

[makortel]

the test testEigenGPUNoFit_t is already failing in the IBs and in CMSSW_13_3_0_pre1.

While of course we should look into the reason and fix it

Just for completeness, this unit test failure is being tracked in #42460

[perrotta]

+1

• The failing unit test is independent from this PR: issue tracked in [GPU] Unit test testEigenGPUNoFit_t failing when testing inverse 5x5 #42460

[perrotta]

merge