Removal of StringCutObjectSelector from Muon trigger DQM

[caruta]

PR description:

This PR removes the "StringCutObjectSelector" from the Muon trigger DQM, with the aim of solving the memory issues faced during the 2022 rereco.
The cuts on the reco muons and trigger objects are now applied explicitly, since they are few and identical for all trigger paths.

• Most of the changes are in HLTMuonMatchAndPlot.cc and in HLTMuonMatchAndPlot.h to implement the new way of applying cuts on the muon and trigger objects
• The configuration files HLTMuonOfflineAnalyzer_cfi.py, HLTMuonOfflineAnalyzer_cff.py and HLTMuonOfflineAnalyzer_cosmics_cff.py have also been modified accordingly.

PR validation:

See master PR for validation description

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Backport of #42437

[cmsbuild]

A new Pull Request was created by @caruta for CMSSW_13_1_X.

It involves the following packages:

• DQMOffline/Trigger (dqm)

@nothingface0, @emanueleusai, @cmsbuild, @pmandrik, @syuvivida, @tjavaid, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks.
@mtosi, @Fedespring, @missirol, @HuguesBrun, @jhgoh, @trocino, @cericeci, @rociovilar this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

• Backported from Removal of StringCutObjectSelector from Muon trigger DQM #42437

[perrotta]

please test

[perrotta]

backport of #42437

[cmsbuild]

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6201fd/34053/summary.html
COMMIT: 2fa30b6
CMSSW: CMSSW_13_1_X_2023-08-02-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/42456/34053/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

The relvals timed out after 4 hours.

Comparison Summary

Summary:

• You potentially added 15 lines to the logs
• Reco comparison results: 12 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3186945
• DQMHistoTests: Total failures: 6
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3186917
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 207 log files, 159 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[emanueleusai]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_1_X IBs (but tests are reportedly failing) and once validation in the development release cycle CMSSW_13_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[emanueleusai]

please test

[perrotta]

+1

• Identical modifications as the ones already merged in. e.g., 13_0_X
• Tests were already successfull, see Removal of StringCutObjectSelector from Muon trigger DQM #42456 (comment), no need to wait the outcome of the new ones

[perrotta]

merge

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6201fd/34107/summary.html
COMMIT: 2fa30b6
CMSSW: CMSSW_13_1_X_2023-08-06-0000/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/42456/34107/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 11 lines to the logs
• Reco comparison results: 8 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3186945
• DQMHistoTests: Total failures: 4
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3186919
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 207 log files, 159 edm output root files, 48 DQM output files
• TriggerResults: no differences found