Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[13_0_X] Removal of StringCutObjectSelector from Muon trigger DQM #42386

Merged
merged 1 commit into from
Aug 3, 2023

Conversation

caruta
Copy link
Contributor

@caruta caruta commented Jul 27, 2023

PR description: Backport of #42348

This PR removes the "StringCutObjectSelector" from the Muon trigger DQM, with the aim of solving the memory issues faced during the 2022 rereco. The cuts on the reco muons and trigger objects are now applied explicitly, since they are few and identical for all trigger paths.

PR validation:

See master PR for validation description

Backport of #42348

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 27, 2023

A new Pull Request was created by @caruta for CMSSW_13_0_X.

It involves the following packages:

  • DQMOffline/Trigger (dqm)

@nothingface0, @emanueleusai, @cmsbuild, @pmandrik, @syuvivida, @tjavaid, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks.
@mtosi, @Fedespring, @missirol, @HuguesBrun, @jhgoh, @trocino, @cericeci, @rociovilar this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@caruta caruta marked this pull request as ready for review July 27, 2023 08:13
@emanueleusai
Copy link
Member

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2147dd/33927/summary.html
COMMIT: 106c3c4
CMSSW: CMSSW_13_0_X_2023-07-26-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/42386/33927/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 239 lines from the logs
  • Reco comparison results: 1 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3281270
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3281248
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 213 log files, 164 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@perrotta
Copy link
Contributor

perrotta commented Jul 29, 2023

backport of #42437

@emanueleusai
Copy link
Member

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 1, 2023

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

perrotta commented Aug 1, 2023

@caruta please synchronize this PR with the one in the master, which is now merged

@perrotta
Copy link
Contributor

perrotta commented Aug 1, 2023

backport of #42437

@perrotta
Copy link
Contributor

perrotta commented Aug 2, 2023

hold

@caruta please synchronize this PR with the one in the master, which is now merged

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 2, 2023

Pull request has been put on hold by @perrotta
They need to issue an unhold command to remove the hold state or L1 can unhold it for all

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 2, 2023

Pull request #42386 was updated. @nothingface0, @emanueleusai, @cmsbuild, @pmandrik, @syuvivida, @tjavaid, @micsucmed, @rvenditti can you please check and sign again.

@caruta
Copy link
Contributor Author

caruta commented Aug 2, 2023

hold

@caruta please synchronize this PR with the one in the master, which is now merged

The PR is updated now (@perrotta)

@perrotta
Copy link
Contributor

perrotta commented Aug 2, 2023

unhold

@perrotta
Copy link
Contributor

perrotta commented Aug 2, 2023

please test

@perrotta
Copy link
Contributor

perrotta commented Aug 2, 2023

Thank you @caruta
By the way: no 13_1_X backport? Is this not used in Phase2 MC?

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 2, 2023

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2147dd/34037/summary.html
COMMIT: dece846
CMSSW: CMSSW_13_0_X_2023-08-02-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/42386/34037/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 12 lines from the logs
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3281270
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3281248
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 213 log files, 164 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@emanueleusai
Copy link
Member

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 3, 2023

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

perrotta commented Aug 3, 2023

+1

@cmsbuild cmsbuild merged commit b40417d into cms-sw:CMSSW_13_0_X Aug 3, 2023
@caruta
Copy link
Contributor Author

caruta commented Aug 3, 2023

Thank you @caruta By the way: no 13_1_X backport? Is this not used in Phase2 MC?

I've created a backport also for 13_1_X to have everything aligned: #42456.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants