TopRecoilHook: fix warning about empty if

[iarspider]

PR description:

This PR fixes the following warning (produced for all platforms in CMSSW_13_3_X_2023-07-19-2300):

In file included from .../CMSSW_13_3_X_2023-07-19-2300/src/GeneratorInterface/Pythia8Interface/plugins/Pythia8Hadronizer.cc:22:
.../CMSSW_13_3_X_2023-07-19-2300/src/GeneratorInterface/Pythia8Interface/plugins/TopRecoilHook.h: In destructor 'virtual Pythia8::TopRecoilHook::~TopRecoilHook()':
  .../CMSSW_13_3_X_2023-07-19-2300/src/GeneratorInterface/Pythia8Interface/plugins/TopRecoilHook.h:38:9: warning: suggest braces around empty body in an 'if' statement [-Wempty-body]
    38 |         ;
      |         ^

As far as I can tell from the file history, this if block is actually not needed.

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42313/36341

• This PR adds an extra 12KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42313/36341/code-format.patch
  e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42313/36341/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42313/36342

• This PR adds an extra 16KB to repository

[cmsbuild]

A new Pull Request was created by @iarspider for master.

It involves the following packages:

• GeneratorInterface/Pythia8Interface (generators)

@SiewYan, @mkirsano, @Saptaparna, @cmsbuild, @alberto-sanchez, @menglu21, @GurpreetSinghChahal can you please review it and eventually sign? Thanks.
@alberto-sanchez, @mkirsano this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[iarspider]

please test

[iarspider]

Pinging @vslokenb as the author of #42180

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-71cc0e/33791/summary.html
COMMIT: eeae959
CMSSW: CMSSW_13_3_X_2023-07-19-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/42313/33791/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 13 lines from the logs
• Reco comparison results: 9 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3197149
• DQMHistoTests: Total failures: 6
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3197121
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 207 log files, 159 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[iarspider]

type bug-fix

[iarspider]

@cms-sw/generators-l2 gentle ping on this purely technical PR.

[perrotta]

@vslokenb made this comment on the identical PR #42370 (now closed):
"I believe this is just messy coding on my end/ a remnant of the code distributed by the pythia authors. Thanks for improving the logic."

I would consider that comment as a green light to proceed with the fix made by the original author of the code

[perrotta]

+1

• This fix was blessed by the original author, see TopRecoilHook: fix warning about empty if #42313 (comment), and the removed C++ lines of code did nothing at all: I think it can be merged even without and explicit @cms-sw/generators-l2 signature

[perrotta]

merge