Top recoil hook cleaned #42180
Top recoil hook cleaned #42180
Conversation
|
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42180/36178
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
|
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42180/36179
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42180/36181
|
|
A new Pull Request was created by @vslokenb for master. It involves the following packages:
@SiewYan, @mkirsano, @Saptaparna, @cmsbuild, @alberto-sanchez, @menglu21, @GurpreetSinghChahal can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42180/36183
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42180/36261
|
|
Pull request #42180 was updated. @SiewYan, @mkirsano, @Saptaparna, @cmsbuild, @alberto-sanchez, @menglu21, @GurpreetSinghChahal can you please check and sign again. |
|
+1 |
cmsbuild
added
generators-approved
fully-signed
tests-started
and removed
generators-pending
pending-signatures
tests-pending
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
|
seems I should assign the test again, should I do "-1" and launch the test |
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-922329/33747/summary.html Found compilation warnings Comparison SummarySummary:
|
|
+1 |
PR description:
Integration of recoilToTop code into CMSSW Pythia8 interface. Allows us the option to treat the top quark as the recoiler during gluon emission in t -> bW decay. Expect to see differences between recoilToTop and the current recoilToColoured options, particularly in B hadron sensitive variables. PR includes header file containing actual function, as well as edits to existing files Pythia8Hadronizer.cc and Py8Interface.cc to incorporate said changes. Python config file to for easy test and run of recoilToTop is included.
PR validation:
Compiles properly using
scram b -j 8andscram b codeformatPrivate samples generated with careful analysis conducted in Rivet to compare between the different recoiler options. No issues in using each of the options when running CMSSW. Only validated on CMSSW_13_2_0_pre1.